Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-30 Thread James Almer
On 4/30/2024 9:40 PM, Michael Niedermayer wrote: On Tue, Apr 30, 2024 at 08:29:07PM -0300, James Almer wrote: On 4/30/2024 8:25 PM, Michael Niedermayer wrote: On Sun, Apr 28, 2024 at 12:43:50AM -0300, James Almer wrote: On 4/27/2024 9:07 AM, Michael Niedermayer wrote: On Sat, Apr 27, 2024 at

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-30 Thread Michael Niedermayer
On Tue, Apr 30, 2024 at 08:29:07PM -0300, James Almer wrote: > On 4/30/2024 8:25 PM, Michael Niedermayer wrote: > > On Sun, Apr 28, 2024 at 12:43:50AM -0300, James Almer wrote: > > > On 4/27/2024 9:07 AM, Michael Niedermayer wrote: > > > > On Sat, Apr 27, 2024 at 12:44:18PM +0200, Andreas

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-30 Thread James Almer
On 4/30/2024 8:25 PM, Michael Niedermayer wrote: On Sun, Apr 28, 2024 at 12:43:50AM -0300, James Almer wrote: On 4/27/2024 9:07 AM, Michael Niedermayer wrote: On Sat, Apr 27, 2024 at 12:44:18PM +0200, Andreas Rheinhardt wrote: Michael Niedermayer: This allows detecting issues in side data

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-30 Thread Michael Niedermayer
On Sun, Apr 28, 2024 at 12:43:50AM -0300, James Almer wrote: > On 4/27/2024 9:07 AM, Michael Niedermayer wrote: > > On Sat, Apr 27, 2024 at 12:44:18PM +0200, Andreas Rheinhardt wrote: > > > Michael Niedermayer: > > > > This allows detecting issues in side data related code, same as what > > > >

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-27 Thread James Almer
On 4/27/2024 9:07 AM, Michael Niedermayer wrote: On Sat, Apr 27, 2024 at 12:44:18PM +0200, Andreas Rheinhardt wrote: Michael Niedermayer: This allows detecting issues in side data related code, same as what framecrc does for before already for packet data itself. Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-27 Thread Michael Niedermayer
On Sat, Apr 27, 2024 at 12:44:18PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > This allows detecting issues in side data related code, same as what > > framecrc does for before already for packet data itself. > > > > Signed-off-by: Michael Niedermayer > > --- > >

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

2024-04-27 Thread Andreas Rheinhardt
Michael Niedermayer: > This allows detecting issues in side data related code, same as what > framecrc does for before already for packet data itself. > > Signed-off-by: Michael Niedermayer > --- > libavformat/framecrcenc.c | 76 +- > tests/ref/fate/autorotate