Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: return AVERROR(EIO) rather than AVERROR_EOF on parse error

2016-08-02 Thread Nicolas George
Le quintidi 15 thermidor, an CCXXIV, Sophia Wang a écrit : > Thanks for the quick response. matroska_resync() is currently written to > only return AVERROR_EOF, so using that error code directly wouldn't be any > more informative. But your suggestion would work if matroska_resync() kept > the

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: return AVERROR(EIO) rather than AVERROR_EOF on parse error

2016-08-01 Thread Sophia Wang
Thanks for the quick response. matroska_resync() is currently written to only return AVERROR_EOF, so using that error code directly wouldn't be any more informative. But your suggestion would work if matroska_resync() kept the error code returned by avio_seek(). Would such a change warrant

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: return AVERROR(EIO) rather than AVERROR_EOF on parse error

2016-07-31 Thread Nicolas George
Le quartidi 14 thermidor, an CCXXIV, Sophia Wang a écrit : > Since matroska->done is only set to 1 in matroska_resync(), the choice > of error is made by checking the return value of matroska_resync() > rather than checking matroska->done directly on the next > while-iteration. This is not what

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: return AVERROR(EIO) rather than AVERROR_EOF on parse error

2016-07-23 Thread James Almer
On 7/23/2016 5:50 AM, Nicolas George wrote: > Le quintidi 5 thermidor, an CCXXIV, Sophia Wang a écrit : >> Signed-off-by: Sophia Wang >> --- >> libavformat/matroskadec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavformat/matroskadec.c

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: return AVERROR(EIO) rather than AVERROR_EOF on parse error

2016-07-23 Thread Nicolas George
Le quintidi 5 thermidor, an CCXXIV, Sophia Wang a écrit : > Signed-off-by: Sophia Wang > --- > libavformat/matroskadec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index f3d701f..c536605

[FFmpeg-devel] [PATCH] avformat/matroskadec: return AVERROR(EIO) rather than AVERROR_EOF on parse error

2016-07-22 Thread Sophia Wang
Signed-off-by: Sophia Wang --- libavformat/matroskadec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index f3d701f..c536605 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@