On Sat, Feb 06, 2016 at 02:46:19PM -0500, Ronald S. Bultje wrote:
> Hi,
>
> On Sat, Feb 6, 2016 at 10:50 AM, Nicolas George wrote:
>
> > L'octidi 18 pluviôse, an CCXXIV, James Almer a écrit :
> > > The couple times i dealt with a trac ticket that wasn't a bug i used
> > > "addressed" instead of
Hi,
On Sat, Feb 6, 2016 at 10:50 AM, Nicolas George wrote:
> L'octidi 18 pluviôse, an CCXXIV, James Almer a écrit :
> > The couple times i dealt with a trac ticket that wasn't a bug i used
> > "addressed" instead of "fixed".
>
> I would say it "addresses" a ticket if the ticket is valid but the
L'octidi 18 pluviôse, an CCXXIV, James Almer a écrit :
> The couple times i dealt with a trac ticket that wasn't a bug i used
> "addressed" instead of "fixed".
I would say it "addresses" a ticket if the ticket is valid but the commit
does not really fix the issue, for example print a helpful speci
On 2/6/2016 10:42 AM, Ronald S. Bultje wrote:
> Hi,
>
> On Sat, Feb 6, 2016 at 5:32 AM, Michael Niedermayer
> wrote:
>
>> On Fri, Feb 05, 2016 at 10:41:26AM -0500, Ronald S. Bultje wrote:
>>> Hi,
>>>
>>> On Fri, Feb 5, 2016 at 9:34 AM, Hendrik Leppkes
>> wrote:
>>>
On Fri, Feb 5, 2016 at 3
Hi,
On Sat, Feb 6, 2016 at 5:32 AM, Michael Niedermayer
wrote:
> On Fri, Feb 05, 2016 at 10:41:26AM -0500, Ronald S. Bultje wrote:
> > Hi,
> >
> > On Fri, Feb 5, 2016 at 9:34 AM, Hendrik Leppkes
> wrote:
> >
> > > On Fri, Feb 5, 2016 at 3:33 PM, Derek Buitenhuis
> > > wrote:
> > > > On 2/5/201
On Fri, Feb 05, 2016 at 10:41:26AM -0500, Ronald S. Bultje wrote:
> Hi,
>
> On Fri, Feb 5, 2016 at 9:34 AM, Hendrik Leppkes wrote:
>
> > On Fri, Feb 5, 2016 at 3:33 PM, Derek Buitenhuis
> > wrote:
> > > On 2/5/2016 2:19 PM, Michael Niedermayer wrote:
> > >> because the code builds the header a
Hi,
On Fri, Feb 5, 2016 at 9:34 AM, Hendrik Leppkes wrote:
> On Fri, Feb 5, 2016 at 3:33 PM, Derek Buitenhuis
> wrote:
> > On 2/5/2016 2:19 PM, Michael Niedermayer wrote:
> >> because the code builds the header a few lines above, i assume
> >> the header we just build is correct
> >
> > Perhaps
On Fri, Feb 05, 2016 at 03:34:48PM +0100, Hendrik Leppkes wrote:
> On Fri, Feb 5, 2016 at 3:33 PM, Derek Buitenhuis
> wrote:
> > On 2/5/2016 2:19 PM, Michael Niedermayer wrote:
> >> because the code builds the header a few lines above, i assume
> >> the header we just build is correct
> >
> > Perh
On Fri, Feb 5, 2016 at 3:33 PM, Derek Buitenhuis
wrote:
> On 2/5/2016 2:19 PM, Michael Niedermayer wrote:
>> because the code builds the header a few lines above, i assume
>> the header we just build is correct
>
> Perhaps you could elaborate what CID1351343 is then, in the commit
> messages.
>
A
On 2/5/2016 2:19 PM, Michael Niedermayer wrote:
> because the code builds the header a few lines above, i assume
> the header we just build is correct
Perhaps you could elaborate what CID1351343 is then, in the commit
messages.
- Derek
___
ffmpeg-devel
On Fri, Feb 05, 2016 at 02:05:57PM +, Derek Buitenhuis wrote:
> On 2/3/2016 11:20 PM, Michael Niedermayer wrote:
> > +ret = avpriv_mpegaudio_decode_header(&mpah, header);
> > +av_assert0(ret >= 0);
>
> Why is this an assert and not an normal check?
because the code builds the
On 2/3/2016 11:20 PM, Michael Niedermayer wrote:
> +ret = avpriv_mpegaudio_decode_header(&mpah, header);
> +av_assert0(ret >= 0);
Why is this an assert and not an normal check?
- Derek
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.or
Fixes: CID1351343
Signed-off-by: Michael Niedermayer
---
libavformat/mp3enc.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c
index 7296234..71f5178 100644
--- a/libavformat/mp3enc.c
+++ b/libavformat/mp3enc.c
@@ -192,7 +192,8
13 matches
Mail list logo
