Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-04-05 Thread Michael Fritscher
Good day, were the technical things (changes into standard network code) resolved in the mean time? I've the feeling that it is looking at the patch. On https://github.com/Haivision/srt/pull/140, there is at least a PR to make a debian package for it. I think the name is a minor problem

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-03-22 Thread Sven Dueking
> -Ursprüngliche Nachricht- > Von: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] Im Auftrag > von Nicolas George > Gesendet: Donnerstag, 22. März 2018 16:03 > An: FFmpeg development discussions and patches > Betreff: Re: [FFmpeg-devel] [PATCH] avformat/open

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-03-22 Thread Nicolas George
Sven Dueking (2018-03-16): > Ping !?!? I think I am actually expected to reply. I think that by reviewing the patch I gave the impression that I was promising to accept the patch in FFmpeg. It was not so, and I apologize if it was taken that way. The original patch contained significant changes

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-03-16 Thread Sven Dueking
> -Ursprüngliche Nachricht- > Von: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] Im Auftrag > von Sven Dueking > Gesendet: Mittwoch, 14. März 2018 08:39 > An: 'FFmpeg development discussions and patches' > Betreff: [FFmpeg-devel] [PATCH] avformat/opensrt: add Ha

[FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-03-14 Thread Sven Dueking
Updated patch according to latest feedback : - spelling errors and capitalization - renamed option "timeout" -> "rw_timeout" - changed max values for duration parameters to INT64_MAX 0001-avformat-opensrt-add-Haivision-Open-SRT-protocol.patch Description: Binary data

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-03-09 Thread wm4
mpeg-devel@ffmpeg.org > > Betreff: Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision > > Open SRT protocol > > > > On Wed, 21 Feb 2018 10:16:48 +0100 > > "Sven Dueking" <s...@nablet.com> wrote: > > > > > protocol requi

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-03-09 Thread Rostislav Pehlivanov
.org] Im Auftrag > > > von Sven Dueking > > > Gesendet: Dienstag, 27. Februar 2018 08:27 > > > An: 'FFmpeg development discussions and patches' > > > Betreff: Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision > > > Open SRT protocol > > &

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-03-09 Thread Nicolas George
Sven Dueking (2018-03-09): > Michael mentioned this : > newly added time based options should be in seconds the user can > achive micro or milli seconds by using suffixes also see > AV_OPT_TYPE_DURATION, it may fit here > > So, what shell we use ? A timeout is a duration of time before giving

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-03-09 Thread Sven Dueking
> -Ursprüngliche Nachricht- > Von: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] Im Auftrag > von wm4 > Gesendet: Freitag, 9. März 2018 08:21 > An: ffmpeg-devel@ffmpeg.org > Betreff: Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision > Open SRT pro

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-03-08 Thread wm4
On Wed, 21 Feb 2018 10:16:48 +0100 "Sven Dueking" wrote: > protocol requires libsrt (https://github.com/Haivision/srt) to be installed > > Signed-off-by: Sven Dueking > --- > MAINTAINERS | 1 + > configure | 5 + >

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-03-08 Thread Mike Goins
peg.org] Im Auftrag > > > von Sven Dueking > > > Gesendet: Dienstag, 27. Februar 2018 08:27 > > > An: 'FFmpeg development discussions and patches' > > > Betreff: Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision > > > Open SRT protocol > >

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-03-08 Thread Michael Niedermayer
An: 'FFmpeg development discussions and patches' > > Betreff: Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision > > Open SRT protocol > > > > > > > > > -Ursprüngliche Nachricht- > > > Von: Sven Dueking [mailto:s...@nablet.com] > &

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-03-05 Thread Sven Dueking
srt: add Haivision > Open SRT protocol > > > > > -Ursprüngliche Nachricht- > > Von: Sven Dueking [mailto:s...@nablet.com] > > Gesendet: Mittwoch, 21. Februar 2018 15:25 > > An: 'FFmpeg development discussions and patches' > > Betreff: AW: [FFmpeg

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-02-26 Thread Sven Dueking
> -Ursprüngliche Nachricht- > Von: Sven Dueking [mailto:s...@nablet.com] > Gesendet: Mittwoch, 21. Februar 2018 15:25 > An: 'FFmpeg development discussions and patches' > Betreff: AW: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision >

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-02-21 Thread Sven Dueking
> -Ursprüngliche Nachricht- > Von: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] Im Auftrag von > Michael Niedermayer > Gesendet: Mittwoch, 21. Februar 2018 14:35 > An: FFmpeg development discussions and patches > Betreff: Re: [FFmpeg-devel] [PATCH] avf

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-02-21 Thread Michael Niedermayer
On Wed, Feb 21, 2018 at 10:16:48AM +0100, Sven Dueking wrote: > protocol requires libsrt (https://github.com/Haivision/srt) to be installed > > Signed-off-by: Sven Dueking > --- > MAINTAINERS | 1 + > configure | 5 + > doc/protocols.texi

[FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-02-21 Thread Sven Dueking
protocol requires libsrt (https://github.com/Haivision/srt) to be installed Signed-off-by: Sven Dueking --- MAINTAINERS | 1 + configure | 5 + doc/protocols.texi | 134 ++- libavformat/Makefile| 1 +

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-02-12 Thread nablet developer
If you or any other developer is against someone receiving git write access you only need to object to the patch adding him to the MAINTAINERS file. Thats one of the reasons why there is a MAINTAINERs file. It would be ideal IMO if for each part of teh codebase at least one person with write

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-02-11 Thread Nicolas George
Hi. I had a look at the whole code. There are a few remarks below. Sorry for the delay, a lot of things on my place these days. Nablet Developer (2018-01-30): > protocol requires libsrt (https://github.com/Haivision/srt) to be > installed > > Signed-off-by: Nablet Developer >

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-02-09 Thread Michael Niedermayer
On Fri, Feb 09, 2018 at 02:28:41PM +0100, wm4 wrote: > On Fri, 9 Feb 2018 03:08:26 +0100 > Michael Niedermayer wrote: > > > On Tue, Jan 30, 2018 at 04:11:03PM -0500, Nablet Developer wrote: > > > protocol requires libsrt (https://github.com/Haivision/srt) to be > > >

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-02-09 Thread wm4
On Fri, 9 Feb 2018 03:08:26 +0100 Michael Niedermayer wrote: > On Tue, Jan 30, 2018 at 04:11:03PM -0500, Nablet Developer wrote: > > protocol requires libsrt (https://github.com/Haivision/srt) to be > > installed > > > > Signed-off-by: Nablet Developer

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-02-08 Thread Michael Niedermayer
On Tue, Jan 30, 2018 at 04:11:03PM -0500, Nablet Developer wrote: > protocol requires libsrt (https://github.com/Haivision/srt) to be > installed > > Signed-off-by: Nablet Developer > --- > MAINTAINERS | 1 + > configure | 9 + > doc/protocols.texi

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-02-08 Thread Nablet Developer
On 1/31/2018 4:11 AM, Nablet Developer wrote: protocol requires libsrt (https://github.com/Haivision/srt) to be installed Signed-off-by: Nablet Developer --- ping ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-01-30 Thread Nablet Developer
protocol requires libsrt (https://github.com/Haivision/srt) to be installed Signed-off-by: Nablet Developer --- MAINTAINERS | 1 + configure | 9 + doc/protocols.texi | 116 + libavformat/Makefile| 1 + libavformat/opensrt.c |

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-01-26 Thread Michael Niedermayer
On Mon, Jan 15, 2018 at 09:02:01AM -0500, Nablet Developer wrote: > protocol requires libsrt (https://github.com/Haivision/srt) to be > installed This overall looks good, a few issues/suggestions i spoted are below: [...] > +@table @option > +@item conntimeo=@var{milliseconds} > +Connection

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-01-24 Thread nablet developer
On 16-Jan-18 09:43, Michael Niedermayer wrote: if you will maintain this code then you may want to include a change to the MAINTAINERs file also does anyone have any more comments on this patch ? it seems to have not gotten much attention recently. There where reviews/comments a few months ago

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-01-15 Thread Michael Niedermayer
On Mon, Jan 15, 2018 at 09:02:01AM -0500, Nablet Developer wrote: > protocol requires libsrt (https://github.com/Haivision/srt) to be > installed > > Signed-off-by: Nablet Developer > --- > configure | 9 + > doc/protocols.texi | 116 + >

[FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-01-14 Thread Nablet Developer
protocol requires libsrt (https://github.com/Haivision/srt) to be installed Signed-off-by: Nablet Developer --- configure | 9 + doc/protocols.texi | 116 + libavformat/Makefile| 1 + libavformat/opensrt.c | 622

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-01-14 Thread Nablet Developer
On 1/13/2018 4:40 AM, Michael Niedermayer wrote: On Wed, Dec 13, 2017 at 03:31:04PM +0700, Nablet Developer wrote: [...] this is commented out ? yes, looks like leftover, thanks for pointing. will send updated patch soon. ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-01-12 Thread Michael Niedermayer
On Wed, Dec 13, 2017 at 03:31:04PM +0700, Nablet Developer wrote: [...] > @@ -3145,6 +3147,8 @@ libsmbclient_protocol_deps="libsmbclient gplv3" > libssh_protocol_deps="libssh" > mmsh_protocol_select="http_protocol" > mmst_protocol_select="network" > +opensrt_protocol_select="network" >

[FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2017-12-13 Thread Nablet Developer
protocol requires libsrt (https://github.com/Haivision/srt) to be installed Signed-off-by: Nablet Developer --- configure | 10 + doc/protocols.texi | 116 + libavformat/Makefile| 1 + libavformat/opensrt.c | 622