Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-25 Thread Michael Niedermayer
On Wed, Oct 24, 2018 at 04:50:07PM -0700, Alex Sukhanov wrote: > On Sat, Oct 13, 2018 at 5:17 PM Michael Niedermayer > wrote: > > > On Fri, Oct 12, 2018 at 01:13:45AM +0100, Derek Buitenhuis wrote: > > > On 11/10/2018 23:39, Alex Sukhanov wrote: > > > > The only "spec" I'm aware

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-24 Thread Alex Sukhanov
On Sat, Oct 13, 2018 at 5:17 PM Michael Niedermayer wrote: > On Fri, Oct 12, 2018 at 01:13:45AM +0100, Derek Buitenhuis wrote: > > On 11/10/2018 23:39, Alex Sukhanov wrote: > > > The only "spec" I'm aware of:https://wiki.multimedia.cx/index.php/IVF > > > > Yeah, not really a spec. > > > > I have

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-18 Thread Alex Sukhanov
On Mon, Oct 15, 2018 at 9:35 AM Vittorio Giovara wrote: > On Thu, Oct 11, 2018 at 5:28 PM Jan Ekström wrote: > > > On Thu, Oct 11, 2018 at 10:58 PM Alex Sukhanov > > wrote: > > > > > > Hi Mark, > > > > > > at Google we have some old service which is still running and it works > > only > > >

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-15 Thread Vittorio Giovara
On Thu, Oct 11, 2018 at 5:28 PM Jan Ekström wrote: > On Thu, Oct 11, 2018 at 10:58 PM Alex Sukhanov > wrote: > > > > Hi Mark, > > > > at Google we have some old service which is still running and it works > only > > with the IVF container. It would be great if ffmpeg could generate such > >

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-15 Thread Michael Niedermayer
On Sun, Oct 14, 2018 at 10:24:22AM -0300, James Almer wrote: > On 10/14/2018 9:59 AM, Michael Niedermayer wrote: > > On Sun, Oct 14, 2018 at 01:29:53PM +0300, Jan Ekström wrote: > >> On Sun, Oct 14, 2018 at 1:27 PM Jan Ekström wrote: > >>> > >>> On Sun, Oct 14, 2018 at 3:17 AM Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-14 Thread James Almer
On 10/14/2018 9:59 AM, Michael Niedermayer wrote: > On Sun, Oct 14, 2018 at 01:29:53PM +0300, Jan Ekström wrote: >> On Sun, Oct 14, 2018 at 1:27 PM Jan Ekström wrote: >>> >>> On Sun, Oct 14, 2018 at 3:17 AM Michael Niedermayer >>> wrote: On Fri, Oct 12, 2018 at 01:13:45AM +0100, Derek

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-14 Thread Michael Niedermayer
On Sun, Oct 14, 2018 at 01:29:53PM +0300, Jan Ekström wrote: > On Sun, Oct 14, 2018 at 1:27 PM Jan Ekström wrote: > > > > On Sun, Oct 14, 2018 at 3:17 AM Michael Niedermayer > > wrote: > > > > > > On Fri, Oct 12, 2018 at 01:13:45AM +0100, Derek Buitenhuis wrote: > > > > On 11/10/2018 23:39, Alex

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-14 Thread Jan Ekström
On Sun, Oct 14, 2018 at 3:17 AM Michael Niedermayer wrote: > > On Fri, Oct 12, 2018 at 01:13:45AM +0100, Derek Buitenhuis wrote: > > On 11/10/2018 23:39, Alex Sukhanov wrote: > > > The only "spec" I'm aware of:https://wiki.multimedia.cx/index.php/IVF > > > > Yeah, not really a spec. > > > > I

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-13 Thread Michael Niedermayer
On Fri, Oct 12, 2018 at 01:13:45AM +0100, Derek Buitenhuis wrote: > On 11/10/2018 23:39, Alex Sukhanov wrote: > > The only "spec" I'm aware of:https://wiki.multimedia.cx/index.php/IVF > > Yeah, not really a spec. > > I have no strong objections, I guess. so IIUC noone is against this ? if so i

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-11 Thread Derek Buitenhuis
On 11/10/2018 23:39, Alex Sukhanov wrote: > The only "spec" I'm aware of:https://wiki.multimedia.cx/index.php/IVF Yeah, not really a spec. I have no strong objections, I guess. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-11 Thread Alex Sukhanov
On Thu, Oct 11, 2018 at 2:47 PM Derek Buitenhuis wrote: > On 11/10/2018 22:21, Jan Ekström wrote: > > I'd probably disable creation of such files unless you enable a less > > standards-compliant strictness mode. > > Is there even an IVF spec, though? If not, there's not really such a > thing as

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-11 Thread Derek Buitenhuis
On 11/10/2018 22:21, Jan Ekström wrote: > I'd probably disable creation of such files unless you enable a less > standards-compliant strictness mode. Is there even an IVF spec, though? If not, there's not really such a thing as "standards-compliant". - Derek

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-11 Thread Jan Ekström
On Thu, Oct 11, 2018 at 10:58 PM Alex Sukhanov wrote: > > Hi Mark, > > at Google we have some old service which is still running and it works only > with the IVF container. It would be great if ffmpeg could generate such > videos so we could give them to the service then. Given that ffmpeg IVF >

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-11 Thread Alex Sukhanov
On Sat, Oct 6, 2018 at 10:37 AM Mark Thompson wrote: > On 05/10/18 21:45, Alex Sukhanov wrote: > > On Mon, Oct 1, 2018 at 11:01 AM wrote: > > > >> From: Alex Sukhanov > >> > >> --- > >> libavformat/ivfenc.c | 50 +--- > >> 1 file changed, 38

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-06 Thread Mark Thompson
On 05/10/18 21:45, Alex Sukhanov wrote: > On Mon, Oct 1, 2018 at 11:01 AM wrote: > >> From: Alex Sukhanov >> >> --- >> libavformat/ivfenc.c | 50 +--- >> 1 file changed, 38 insertions(+), 12 deletions(-) >> >> diff --git a/libavformat/ivfenc.c

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-05 Thread Alex Sukhanov
On Mon, Oct 1, 2018 at 11:01 AM wrote: > From: Alex Sukhanov > > --- > libavformat/ivfenc.c | 50 +--- > 1 file changed, 38 insertions(+), 12 deletions(-) > > diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c > index 66441a2a43..6410828533 100644

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-01 Thread Alex Sukhanov
On Sun, Sep 30, 2018 at 2:09 PM Jan Ekström wrote: > Sn Sun, Sep 30, 2018 at 8:56 PM wrote: > > > > ... > > +if (st->codecpar->codec_id == AV_CODEC_ID_H264) { > > +if (pkt->size >= 5 && AV_RB32(pkt->data) != 0x001 && > > + (AV_RB24(pkt->data) !=

[FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-01 Thread alx . sukhanov
From: Alex Sukhanov --- libavformat/ivfenc.c | 50 +--- 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c index 66441a2a43..6410828533 100644 --- a/libavformat/ivfenc.c +++ b/libavformat/ivfenc.c

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-01 Thread Paul B Mahol
On 10/1/18, Nicolas George wrote: > Paul B Mahol (2018-10-01): >> Same is given with AVERROR_BUG, instead of hard crashing with assert, >> which is >> very unprofessional. > > A program crashing seems very professional to me. The most professional > program ever, windows, has a long history of

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-01 Thread Nicolas George
Paul B Mahol (2018-10-01): > Same is given with AVERROR_BUG, instead of hard crashing with assert, which is > very unprofessional. A program crashing seems very professional to me. The most professional program ever, windows, has a long history of crashing. Fortunately, FFmpeg is not a

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-01 Thread Paul B Mahol
On 9/30/18, Nicolas George wrote: > Paul B Mahol (2018-09-30): >> > For consistency within a single function, an assert is the correct >> > choice. >> No, it is not. Asserts do not add any consistency. > > Asserts do not add consistency indeed. Their purpose is to check > consistency, which is

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-09-30 Thread Jan Ekström
On Mon, Oct 1, 2018 at 12:01 AM Jan Ekström wrote: > > Additionally, please make sure that the files created with these > changes can be demuxed with the FFmpeg IVF demuxer (ivfdec.c). I would > guess the H.264 stuff would work, but since the IVF demuxer utilizes > the ff_codec_bmp_tags list,

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-09-30 Thread James Almer
On 9/30/2018 6:01 PM, Jan Ekström wrote: > Sn Sun, Sep 30, 2018 at 8:56 PM wrote: >> >> ... >> +if (st->codecpar->codec_id == AV_CODEC_ID_H264) { >> +if (pkt->size >= 5 && AV_RB32(pkt->data) != 0x001 && >> + (AV_RB24(pkt->data) != 0x01 || >> +

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-09-30 Thread Jan Ekström
Sn Sun, Sep 30, 2018 at 8:56 PM wrote: > > ... > +if (st->codecpar->codec_id == AV_CODEC_ID_H264) { > +if (pkt->size >= 5 && AV_RB32(pkt->data) != 0x001 && > + (AV_RB24(pkt->data) != 0x01 || > +

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-09-30 Thread Nicolas George
Paul B Mahol (2018-09-30): > > For consistency within a single function, an assert is the correct > > choice. > No, it is not. Asserts do not add any consistency. Asserts do not add consistency indeed. Their purpose is to check consistency, which is exactly what needs testing here: the

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-09-30 Thread Paul B Mahol
On 9/30/18, Nicolas George wrote: > Paul B Mahol (2018-09-30): >> No, AVERROR_BUG is better. > > For consistency within a single function, an assert is the correct > choice. No, it is not. Asserts do not add any consistency. ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-09-30 Thread Nicolas George
Paul B Mahol (2018-09-30): > No, AVERROR_BUG is better. For consistency within a single function, an assert is the correct choice. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-09-30 Thread James Almer
On 9/28/2018 3:51 PM, alx.sukha...@gmail.com wrote: > From: Alex Sukhanov > > --- > libavformat/ivfenc.c | 41 - > 1 file changed, 36 insertions(+), 5 deletions(-) > > diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c > index

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-09-30 Thread Paul B Mahol
On 9/30/18, Carl Eugen Hoyos wrote: > 2018-09-28 20:51 GMT+02:00, alx.sukha...@gmail.com : >> From: Alex Sukhanov > >> if (par->codec_type != AVMEDIA_TYPE_VIDEO || >> !(par->codec_id == AV_CODEC_ID_AV1 || >> + par->codec_id == AV_CODEC_ID_H264 || >> +

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-09-30 Thread Carl Eugen Hoyos
2018-09-28 20:51 GMT+02:00, alx.sukha...@gmail.com : > From: Alex Sukhanov > if (par->codec_type != AVMEDIA_TYPE_VIDEO || > !(par->codec_id == AV_CODEC_ID_AV1 || > + par->codec_id == AV_CODEC_ID_H264 || > + par->codec_id == AV_CODEC_ID_HEVC || >

[FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-09-30 Thread alx . sukhanov
From: Alex Sukhanov --- libavformat/ivfenc.c | 41 - 1 file changed, 36 insertions(+), 5 deletions(-) diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c index 66441a2a43..68c36daf09 100644 --- a/libavformat/ivfenc.c +++ b/libavformat/ivfenc.c @@

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-09-27 Thread Carl Eugen Hoyos
2018-09-27 22:16 GMT+02:00, Jan Ekström : > On Thu, Sep 27, 2018 at 10:18 PM, wrote: >> From: Alex Sukhanov >> >> --- >> libavformat/ivfenc.c | 37 - >> 1 file changed, 32 insertions(+), 5 deletions(-) >> >> diff --git a/libavformat/ivfenc.c

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-09-27 Thread Jan Ekström
On Thu, Sep 27, 2018 at 10:18 PM, wrote: > From: Alex Sukhanov > > --- > libavformat/ivfenc.c | 37 - > 1 file changed, 32 insertions(+), 5 deletions(-) > > diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c > index 66441a2a43..9ff7894b88 100644 > ---

[FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-09-27 Thread alx . sukhanov
From: Alex Sukhanov --- libavformat/ivfenc.c | 37 - 1 file changed, 32 insertions(+), 5 deletions(-) diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c index 66441a2a43..9ff7894b88 100644 --- a/libavformat/ivfenc.c +++ b/libavformat/ivfenc.c @@ -38,17