Re: [FFmpeg-devel] [PATCH] avformat: add vividas demuxer

2018-12-19 Thread Tomas Härdin
tis 2018-12-18 klockan 22:58 +0100 skrev Paul B Mahol: > > On 12/18/18, Tomas Härdin wrote: > > sön 2018-12-16 klockan 22:28 +0100 skrev Paul B Mahol: > > > > > > > > > > +static void track_header(VividasDemuxContext *viv, AVFormatContext > > > *s,  uint8_t *buf, int size) > > > +{ > > > +[...]

Re: [FFmpeg-devel] [PATCH] avformat: add vividas demuxer

2018-12-18 Thread Paul B Mahol
On 12/18/18, Tomas Härdin wrote: > sön 2018-12-16 klockan 22:28 +0100 skrev Paul B Mahol: >> > >> +static void track_header(VividasDemuxContext *viv, AVFormatContext >> *s, uint8_t *buf, int size) >> +{ >> +[...] >> +if (avio_tell(pb) < off) { >> +int num_data; >> +

Re: [FFmpeg-devel] [PATCH] avformat: add vividas demuxer

2018-12-18 Thread Tomas Härdin
sön 2018-12-16 klockan 22:28 +0100 skrev Paul B Mahol: > > > +static void track_header(VividasDemuxContext *viv, AVFormatContext *s,   > uint8_t *buf, int size) > +{ > +[...] > +if (avio_tell(pb) < off) { > +int num_data; > +int xd_size = 0; > +int data_

[FFmpeg-devel] [PATCH] avformat: add vividas demuxer

2018-12-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/vividas.c| 715 +++ 3 files changed, 717 insertions(+) create mode 100644 libavformat/vividas.c diff --git a/libavformat/Makefile b/libavformat

Re: [FFmpeg-devel] [PATCH] avformat: add vividas demuxer

2018-12-16 Thread Tomas Härdin
lör 2018-12-15 klockan 20:06 +0100 skrev Paul B Mahol: > > Signed-off-by: Paul B Mahol > + > +static void put_v(uint8_t *p, int v) This should take unsigned > +{ > +if (v>>28) > +*p++ = ((v>>28)&0x7f)|0x80; > +if (v>>21) > +*p++ = ((v>>21)&0x7f)|0x80; > +if (v>>14) >

[FFmpeg-devel] [PATCH] avformat: add vividas demuxer

2018-12-15 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/vividas.c| 715 +++ 3 files changed, 717 insertions(+) create mode 100644 libavformat/vividas.c diff --git a/libavformat/Makefile b/libavformat

Re: [FFmpeg-devel] [PATCH] avformat: add vividas demuxer

2018-12-10 Thread James Almer
On 12/10/2018 9:05 AM, Paul B Mahol wrote: > +static uint32_t get_v(uint8_t *p) > +{ > +uint32_t v = 0; > + > +do { > +v <<= 7; > +v += *p & 0x7f; > +} while (*p++ & 0x80); > + > +return v; > +} More than four or so iterations will overflow uint32_t. > +AVInputForm

Re: [FFmpeg-devel] [PATCH] avformat: add vividas demuxer

2018-12-10 Thread Michael Niedermayer
On Mon, Dec 10, 2018 at 01:05:05PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/vividas.c| 708 +++ > 3 files changed, 710 insertions(+) > create mode 1

[FFmpeg-devel] [PATCH] avformat: add vividas demuxer

2018-12-10 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/vividas.c| 708 +++ 3 files changed, 710 insertions(+) create mode 100644 libavformat/vividas.c diff --git a/libavformat/Makefile b/libavformat