Re: [FFmpeg-devel] [PATCH] avutil: add API for mb_types

2017-11-13 Thread Moritz Barsnick
On Sun, Nov 12, 2017 at 00:21:54 +0100, Michael Niedermayer wrote: Some nitpicking, since it's doxygen: > +#define AV_BLOCK_TYPE_FLAG_INTRA 0x001///< Block is a intra > block, else inter ^ an > +#define AV

Re: [FFmpeg-devel] [PATCH] avutil: add API for mb_types

2017-11-12 Thread Clément Bœsch
On Sun, Nov 12, 2017 at 01:55:14AM +, Rostislav Pehlivanov wrote: [...] > The range should be derived from the codec ID. The frame doesn't contain the codec ID, so this information should be added to that struct somehow (it needs to reach the filters who are agnostics). [...] -- Clément B.

Re: [FFmpeg-devel] [PATCH] avutil: add API for mb_types

2017-11-11 Thread Rostislav Pehlivanov
On 12 November 2017 at 01:44, Ronald S. Bultje wrote: > Hi, > > On Sat, Nov 11, 2017 at 6:21 PM, Michael Niedermayer > > wrote: > > > +/** > > + * Width and height of the block. > > + */ > > +uint8_t w, h; > > > > av1 already has up to 128x128 block sizes, so I'm assuming this wo

Re: [FFmpeg-devel] [PATCH] avutil: add API for mb_types

2017-11-11 Thread Ronald S. Bultje
Hi, On Sat, Nov 11, 2017 at 6:21 PM, Michael Niedermayer wrote: > +/** > + * Width and height of the block. > + */ > +uint8_t w, h; > av1 already has up to 128x128 block sizes, so I'm assuming this won't be enough for av2. Maybe that's Ok, but it's easy to make it (u)int16_t now

[FFmpeg-devel] [PATCH] avutil: add API for mb_types

2017-11-11 Thread Michael Niedermayer
This is based on motion_type.h Signed-off-by: Michael Niedermayer --- libavutil/block_type.h | 89 ++ 1 file changed, 89 insertions(+) create mode 100644 libavutil/block_type.h diff --git a/libavutil/block_type.h b/libavutil/block_type.h new file