Re: [FFmpeg-devel] [PATCH] dashdec: Fix segfault on decoding segment timeline

2018-01-28 Thread Steven Liu
>>> >>> libavformat/dashdec.c | 11 --- >>> 1 file changed, 4 insertions(+), 7 deletions(-) >>> >>> diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c >>> index 2492f1d..cdb7ba5 100644 >>> --- a/libavformat/dashdec.c >>> +++ b/libavformat/dashdec.c >>> @@ -1083,15 +1083,12 @@

Re: [FFmpeg-devel] [PATCH] dashdec: Fix segfault on decoding segment timeline

2018-01-28 Thread Steven Liu
> 在 2018年1月28日,上午9:09,Brendan McGrath 写道: > > Just making sure this patch hasn't been overlooked. > > To better explain the existing issue - the value of 'pls->first_seq_no' comes > from the 'startNumber' attribute of the 'SegmentTemplate' element. > > The

Re: [FFmpeg-devel] [PATCH] dashdec: Fix segfault on decoding segment timeline

2018-01-27 Thread Brendan McGrath
Just making sure this patch hasn't been overlooked. To better explain the existing issue - the value of 'pls->first_seq_no' comes from the 'startNumber' attribute of the 'SegmentTemplate' element. The 'pls->timelines' array represents the elements within the 'SegmentTimeline' element. So

[FFmpeg-devel] [PATCH] dashdec: Fix segfault on decoding segment timeline

2018-01-19 Thread Brendan McGrath
If first_seq_no is not within the bounds of timelines then a segfault will occur. This patch removes the use of first_seq_no within the timelines array It also adds first_seq_no to the value returned by calc_next_seg_no_from_timelines (which allows for different values of 'startNumber')