Re: [FFmpeg-devel] [PATCH] ivfdec/ivfenc: Match behaviour of libvpx and chromium

2019-10-01 Thread Calvin Walton
On Tue, 2019-10-01 at 13:56 -0400, Calvin Walton wrote: > The ffmpeg code read and wrote a 64bit duration field (in timebase > units) in the ivf > header, where the libvpx and chromium code instead use a 32bit frame > count field, and > then 32bits of unused (reserved?) space. > > Switch ffmpeg

Re: [FFmpeg-devel] [PATCH] ivfdec/ivfenc: Match behaviour of libvpx and chromium

2019-10-01 Thread Calvin Walton
On Tue, 2019-10-01 at 15:26 -0300, James Almer wrote: > On 10/1/2019 2:56 PM, Calvin Walton wrote: > > libavformat/ivfdec.c | 3 ++- > > libavformat/ivfenc.c | 11 --- > > 2 files changed, 6 insertions(+), 8 deletions(-) > > > > diff --git a/libavformat/ivfdec.c b/libavformat/ivfdec.c >

Re: [FFmpeg-devel] [PATCH] ivfdec/ivfenc: Match behaviour of libvpx and chromium

2019-10-01 Thread Raphaƫl Zumer
This is a superset of my patch(es). It should match the behavior of libvpx more closely, but the validity of the change from duration to number of frames depends on your interpretation of the reference implementation, which comments the field as "length". On Tue, 2019-10-01 at 23:41 +0530, Gyan

Re: [FFmpeg-devel] [PATCH] ivfdec/ivfenc: Match behaviour of libvpx and chromium

2019-10-01 Thread Gyan
On 01-10-2019 11:53 PM, James Almer wrote: On 10/1/2019 3:11 PM, Gyan wrote: On 01-10-2019 11:26 PM, Calvin Walton wrote: The ffmpeg code read and wrote a 64bit duration field (in timebase units) in the ivf header, where the libvpx and chromium code instead use a 32bit frame count field,

Re: [FFmpeg-devel] [PATCH] ivfdec/ivfenc: Match behaviour of libvpx and chromium

2019-10-01 Thread James Almer
On 10/1/2019 2:56 PM, Calvin Walton wrote: > The ffmpeg code read and wrote a 64bit duration field (in timebase units) in > the ivf > header, where the libvpx and chromium code instead use a 32bit frame count > field, and > then 32bits of unused (reserved?) space. > > Switch ffmpeg to match the

Re: [FFmpeg-devel] [PATCH] ivfdec/ivfenc: Match behaviour of libvpx and chromium

2019-10-01 Thread James Almer
On 10/1/2019 3:11 PM, Gyan wrote: > > > On 01-10-2019 11:26 PM, Calvin Walton wrote: >> The ffmpeg code read and wrote a 64bit duration field (in timebase >> units) in the ivf >> header, where the libvpx and chromium code instead use a 32bit frame >> count field, and >> then 32bits of unused

Re: [FFmpeg-devel] [PATCH] ivfdec/ivfenc: Match behaviour of libvpx and chromium

2019-10-01 Thread Gyan
On 01-10-2019 11:26 PM, Calvin Walton wrote: The ffmpeg code read and wrote a 64bit duration field (in timebase units) in the ivf header, where the libvpx and chromium code instead use a 32bit frame count field, and then 32bits of unused (reserved?) space. Switch ffmpeg to match the

[FFmpeg-devel] [PATCH] ivfdec/ivfenc: Match behaviour of libvpx and chromium

2019-10-01 Thread Calvin Walton
The ffmpeg code read and wrote a 64bit duration field (in timebase units) in the ivf header, where the libvpx and chromium code instead use a 32bit frame count field, and then 32bits of unused (reserved?) space. Switch ffmpeg to match the behaviour of libvpx & chromium. Note that libvpx writes