Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-19 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > > >> +case AV_PIX_FMT_GBRP: > > >> +ctx->vpx_cs = VPX_CS_SRGB; > > > > > > This is only available since libvpx 1.4.0, so you need to wrap all this > > > new code inside some preprocessor checks. I think VPX_IMAGE_ABI_VERSION > > > >= 3 should do it

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-19 Thread Carl Eugen Hoyos
Hendrik Leppkes gmail.com> writes: > Well that would be nice and all, but in many of those > cases the code is never re-indented afterwards I am happy to fix them if you point me to them. The only reason I did not reindent in the past was to make merges easier. Carl Eugen __

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-19 Thread Hendrik Leppkes
On Fri, Feb 19, 2016 at 8:16 AM, James Zern wrote: > On Thu, Feb 18, 2016 at 3:02 PM, Hendrik Leppkes wrote: >> On Thu, Feb 18, 2016 at 11:59 PM, Carl Eugen Hoyos wrote: >>> On Thursday 18 February 2016 09:40:01 pm Nicolas George wrote: Initial patch by Carl Eugen Hoyos. Fix trac

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-18 Thread James Zern
On Thu, Feb 18, 2016 at 3:02 PM, Hendrik Leppkes wrote: > On Thu, Feb 18, 2016 at 11:59 PM, Carl Eugen Hoyos wrote: >> On Thursday 18 February 2016 09:40:01 pm Nicolas George wrote: >>> Initial patch by Carl Eugen Hoyos. >>> >>> Fix trac ticket #5249. >> >> Patch with (automatic) support for 8, 1

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-18 Thread James Zern
On Thu, Feb 18, 2016 at 3:34 PM, Carl Eugen Hoyos wrote: >> Alternatively we could bump the minimum required version and remove most of >> the existing checks. 1.3.0 is pretty old by now and it would let us clean >> these files. > > I would prefer if this could be done independently (and afterward

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-18 Thread James Zern
On Thu, Feb 18, 2016 at 3:10 PM, James Almer wrote: > On 2/18/2016 7:59 PM, Carl Eugen Hoyos wrote: >> +case AV_PIX_FMT_GBRP: >> +ctx->vpx_cs = VPX_CS_SRGB; > > This is only available since libvpx 1.4.0, so you need to wrap all this new > code inside some preprocessor checks. I think V

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-18 Thread Carl Eugen Hoyos
On Friday 19 February 2016 12:18:06 am James Almer wrote: > On 2/18/2016 8:10 PM, James Almer wrote: > > On 2/18/2016 7:59 PM, Carl Eugen Hoyos wrote: > >> +case AV_PIX_FMT_GBRP: > >> +ctx->vpx_cs = VPX_CS_SRGB; > > > > This is only available since libvpx 1.4.0, so you need to wrap all

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-18 Thread James Almer
On 2/18/2016 8:10 PM, James Almer wrote: > On 2/18/2016 7:59 PM, Carl Eugen Hoyos wrote: >> +case AV_PIX_FMT_GBRP: >> +ctx->vpx_cs = VPX_CS_SRGB; > > This is only available since libvpx 1.4.0, so you need to wrap all this new > code inside some preprocessor checks. I think VPX_IMAGE_AB

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-18 Thread Carl Eugen Hoyos
On Friday 19 February 2016 12:02:59 am Hendrik Leppkes wrote: > On Thu, Feb 18, 2016 at 11:59 PM, Carl Eugen Hoyos wrote: > > On Thursday 18 February 2016 09:40:01 pm Nicolas George wrote: > >> Initial patch by Carl Eugen Hoyos. > >> > >> Fix trac ticket #5249. > > > > Patch with (automatic) suppo

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-18 Thread James Almer
On 2/18/2016 7:59 PM, Carl Eugen Hoyos wrote: > +case AV_PIX_FMT_GBRP: > +ctx->vpx_cs = VPX_CS_SRGB; This is only available since libvpx 1.4.0, so you need to wrap all this new code inside some preprocessor checks. I think VPX_IMAGE_ABI_VERSION >= 3 should do it, but better wait for Ja

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-18 Thread Hendrik Leppkes
On Thu, Feb 18, 2016 at 11:59 PM, Carl Eugen Hoyos wrote: > On Thursday 18 February 2016 09:40:01 pm Nicolas George wrote: >> Initial patch by Carl Eugen Hoyos. >> >> Fix trac ticket #5249. > > Patch with (automatic) support for 8, 10 and 12 bit gbr attached. > > Please comment, Carl Eugen This l

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-18 Thread Carl Eugen Hoyos
On Thursday 18 February 2016 09:40:01 pm Nicolas George wrote: > Initial patch by Carl Eugen Hoyos. > > Fix trac ticket #5249. Patch with (automatic) support for 8, 10 and 12 bit gbr attached. Please comment, Carl Eugen diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 8992497..c

[FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

2016-02-18 Thread Nicolas George
Initial patch by Carl Eugen Hoyos. Fix trac ticket #5249. Signed-off-by: Nicolas George --- libavcodec/libvpx.c| 1 + libavcodec/libvpxenc.c | 1 + 2 files changed, 2 insertions(+) This is probably quite incomplete (high bit depth?), and there should probably be a consistency check or aut