Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-11-07 Thread Michael Niedermayer
On Tue, Nov 04, 2014 at 12:26:27AM +0530, arwa arif wrote: Okay. I would try to complete it by tomorrow. any news about this ? i know this isnt trivial to update to the other reference ... On Mon, Nov 3, 2014 at 8:02 PM, Stefano Sabatini stefa...@gmail.com wrote: On date Monday 2014-11-03

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-11-03 Thread arwa arif
Okay. I would try to complete it by tomorrow. On Mon, Nov 3, 2014 at 8:02 PM, Stefano Sabatini stefa...@gmail.com wrote: On date Monday 2014-11-03 12:09:50 +0530, arwa arif encoded: I mailed Sergio (Hyllian) and this is his message - You can look at this thread:

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-11-02 Thread Michael Niedermayer
On Sun, Nov 02, 2014 at 09:09:51AM +0530, arwa arif wrote: On Sun, Nov 2, 2014 at 3:36 AM, Michael Niedermayer michae...@gmx.at wrote: On Sat, Nov 01, 2014 at 11:35:11PM +0530, arwa arif wrote: Scale2x and xBR are very different. But they have implemented xBR also in their source code.

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-11-02 Thread Stefano Sabatini
On date Sunday 2014-11-02 13:28:05 +0100, Michael Niedermayer encoded: On Sun, Nov 02, 2014 at 09:09:51AM +0530, arwa arif wrote: [...] The reference code I used was https://github.com/carlosascari/2xBR-Filter;. I see, and i understand now where the abs bug in your code came from i dont

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-11-02 Thread Timothy Gu
On Sunday, November 2, 2014, Stefano Sabatini stefa...@gmail.com wrote: On date Sunday 2014-11-02 13:28:05 +0100, Michael Niedermayer encoded: On Sun, Nov 02, 2014 at 09:09:51AM +0530, arwa arif wrote: [...] The reference code I used was https://github.com/carlosascari/2xBR-Filter;.

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-11-02 Thread Timothy Gu
On Sunday, November 2, 2014, Timothy Gu timothyg...@gmail.com wrote: Found a C++ implementation: http://sourceforge.net/p/paintown/code/HEAD/tree/trunk/src/util/graphics/sdl/xbr.cpp It says xBR 3.3b and I'm not sure what variant that is in the filthy pants blog. It's close to C and

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-11-02 Thread Nicolas George
Le duodi 12 brumaire, an CCXXIII, Stefano Sabatini a écrit : This blog mentions Hyllian xBR algorithm: http://board.byuu.org/viewtopic.php?f=10t=2248 but the link above is dead. There is a version in the Wayback Machine:

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-11-02 Thread arwa arif
I mailed Sergio (Hyllian) and this is his message - You can look at this thread: http://www.libretro.com/forums/viewtopic.php?f=6t=134 And there are some c/c++ implementations out there like this: https://github.com/yoyofr/iFBA/blob/master/fba_src/src/intf/video/scalers/xbr.cpp I'm not

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-11-01 Thread Stefano Sabatini
On date Saturday 2014-11-01 04:27:24 +0530, arwa arif encoded: [...] On Fri, Oct 31, 2014 at 6:31 PM, Stefano Sabatini stefa...@gmail.com From 9b6b1d546247cf61b2f696835fb8a5e782d353ea Mon Sep 17 00:00:00 2001 From: Arwa Arif arwaarif1...@gmail.com Date: Thu, 30 Oct 2014 22:06:20 +0530

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-11-01 Thread Michael Niedermayer
On Sat, Nov 01, 2014 at 07:30:32PM +0530, arwa arif wrote: On Sat, Nov 1, 2014 at 4:40 PM, Stefano Sabatini stefa...@gmail.com wrote: On date Saturday 2014-11-01 04:27:24 +0530, arwa arif encoded: [...] On Fri, Oct 31, 2014 at 6:31 PM, Stefano Sabatini stefa...@gmail.com From

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-11-01 Thread arwa arif
Scale2x and xBR are very different. But they have implemented xBR also in their source code. Anyways, I found a good link -- http://imgur.com/a/XAwx5; for reference pictures. But, the answers are coming out to be different. Not sure, why this is happening. Maybe, it is because of different

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-11-01 Thread Michael Niedermayer
On Sat, Nov 01, 2014 at 11:35:11PM +0530, arwa arif wrote: Scale2x and xBR are very different. But they have implemented xBR also in their source code. Anyways, I found a good link -- http://imgur.com/a/XAwx5; for reference pictures. But, the answers are coming out to be different. Not sure,

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-11-01 Thread arwa arif
On Sun, Nov 2, 2014 at 3:36 AM, Michael Niedermayer michae...@gmx.at wrote: On Sat, Nov 01, 2014 at 11:35:11PM +0530, arwa arif wrote: Scale2x and xBR are very different. But they have implemented xBR also in their source code. Anyways, I found a good link -- http://imgur.com/a/XAwx5; for

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-31 Thread Stefano Sabatini
On date Friday 2014-10-31 01:36:46 +0530, arwa arif encoded: [...] From b9b56b594f856fef8b113b283df2d2045e8357f7 Mon Sep 17 00:00:00 2001 From: Arwa Arif arwaarif1...@gmail.com Date: Thu, 30 Oct 2014 22:06:20 +0530 Subject: [PATCH] [PATCH]lvafi: add xbr filter typo: lavfi: ---

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-31 Thread Michael Niedermayer
On Sat, Nov 01, 2014 at 04:27:24AM +0530, arwa arif wrote: On Fri, Oct 31, 2014 at 6:31 PM, Stefano Sabatini stefa...@gmail.com wrote: On date Friday 2014-10-31 01:36:46 +0530, arwa arif encoded: [...] From b9b56b594f856fef8b113b283df2d2045e8357f7 Mon Sep 17 00:00:00 2001 From:

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-30 Thread arwa arif
On Wed, Oct 29, 2014 at 3:36 AM, Clément Bœsch u...@pkh.me wrote: On Tue, Oct 28, 2014 at 10:51:27PM +0100, Michael Niedermayer wrote: On Tue, Oct 28, 2014 at 07:16:45PM +0100, Clément Bœsch wrote: On Tue, Oct 28, 2014 at 06:30:34PM +0100, Stefano Sabatini wrote: [...] How much

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-30 Thread Stefano Sabatini
On date Thursday 2014-10-30 18:23:35 +0530, arwa arif encoded: On Wed, Oct 29, 2014 at 3:36 AM, Clément Bœsch u...@pkh.me wrote: On Tue, Oct 28, 2014 at 10:51:27PM +0100, Michael Niedermayer wrote: On Tue, Oct 28, 2014 at 07:16:45PM +0100, Clément Bœsch wrote: On Tue, Oct 28, 2014 at

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-30 Thread arwa arif
On Thu, Oct 30, 2014 at 9:34 PM, Stefano Sabatini stefa...@gmail.com wrote: On date Thursday 2014-10-30 18:23:35 +0530, arwa arif encoded: On Wed, Oct 29, 2014 at 3:36 AM, Clément Bœsch u...@pkh.me wrote: On Tue, Oct 28, 2014 at 10:51:27PM +0100, Michael Niedermayer wrote: On Tue, Oct

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-28 Thread Clément Bœsch
On Tue, Oct 28, 2014 at 01:45:06PM +0530, arwa arif wrote: On Tue, Oct 28, 2014 at 1:25 AM, Clément Bœsch u...@pkh.me wrote: On Mon, Oct 27, 2014 at 08:54:11PM +0100, Clément Bœsch wrote: [...] Can you add a FATE test similar to this? See tests/fate/filter-video.mak. similar to hqx I

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-28 Thread arwa arif
On Tue, Oct 28, 2014 at 1:52 PM, Clément Bœsch u...@pkh.me wrote: On Tue, Oct 28, 2014 at 01:45:06PM +0530, arwa arif wrote: On Tue, Oct 28, 2014 at 1:25 AM, Clément Bœsch u...@pkh.me wrote: On Mon, Oct 27, 2014 at 08:54:11PM +0100, Clément Bœsch wrote: [...] Can you add a FATE

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-28 Thread Stefano Sabatini
On date Tuesday 2014-10-28 13:45:06 +0530, arwa arif encoded: On Tue, Oct 28, 2014 at 1:25 AM, Clément Bœsch u...@pkh.me wrote: On Mon, Oct 27, 2014 at 08:54:11PM +0100, Clément Bœsch wrote: [...] Can you add a FATE test similar to this? See tests/fate/filter-video.mak. similar to

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-28 Thread Clément Bœsch
On Tue, Oct 28, 2014 at 06:30:34PM +0100, Stefano Sabatini wrote: [...] How much effort would it take to implement the remaining scaling modes? According to https://ffmpeg.org/pipermail/ffmpeg-devel/2014-October/164574.html I think 4x can be done fast enough, but 3x will take time. [...]

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-28 Thread mike . gorchak . qnx
Sent from my BlackBerry 10 smartphone on the Rogers network.   Original Message   From: Michael Niedermayer Sent: Tuesday, October 28, 2014 17:51 To: FFmpeg development discussions and patches Reply To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] lavfi: add xbr

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-28 Thread mike . gorchak . qnx
Sent from my BlackBerry 10 smartphone on the Rogers network.   Original Message   From: Michael Niedermayer Sent: Tuesday, October 28, 2014 17:51 To: FFmpeg development discussions and patches Reply To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] lavfi: add xbr

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-28 Thread mike . gorchak . qnx
‎Ыы Sent from my BlackBerry 10 smartphone on the Rogers network.   Original Message   From: Michael Niedermayer Sent: Tuesday, October 28, 2014 17:51 To: FFmpeg development discussions and patches Reply To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] lavfi: add

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-28 Thread Clément Bœsch
On Tue, Oct 28, 2014 at 10:51:27PM +0100, Michael Niedermayer wrote: On Tue, Oct 28, 2014 at 07:16:45PM +0100, Clément Bœsch wrote: On Tue, Oct 28, 2014 at 06:30:34PM +0100, Stefano Sabatini wrote: [...] How much effort would it take to implement the remaining scaling modes?

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-27 Thread arwa arif
On Mon, Oct 27, 2014 at 12:40 AM, Clément Bœsch u...@pkh.me wrote: On Mon, Oct 27, 2014 at 12:28:35AM +0530, arwa arif wrote: 1. I think I understood what is giving you segmentation fault. The mask that I am creating is going out of bounds for the boundary pixels. I will try to fix it.

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-27 Thread Nicolas George
Le sextidi 6 brumaire, an CCXXIII, arwa arif a écrit : I have done all the changes except rgb to yuv conversion. I will most probably do it by tonight. +/*Convert RGB to Y'UV*/ +int y = r * .299000 + g * .587000 + b * .114000; +int u = r * -.168736 + g * -.331264 + b * .50;

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-27 Thread Clément Bœsch
On Mon, Oct 27, 2014 at 10:02:25AM +0100, Nicolas George wrote: Le sextidi 6 brumaire, an CCXXIII, arwa arif a écrit : I have done all the changes except rgb to yuv conversion. I will most probably do it by tonight. +/*Convert RGB to Y'UV*/ +int y = r * .299000 + g * .587000 + b

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-27 Thread Clément Bœsch
On Tue, Oct 28, 2014 at 01:07:30AM +0530, arwa arif wrote: [...] From 9c5fa6fa8f6091149570cded8ee65d232ae88e97 Mon Sep 17 00:00:00 2001 From: Arwa Arif arwaarif1...@gmail.com Date: Sat, 25 Oct 2014 22:04:51 +0530 Subject: [PATCH] [PATCH]lavfi: add xbr filter Makefile allfilters.c

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-27 Thread Clément Bœsch
On Mon, Oct 27, 2014 at 08:54:11PM +0100, Clément Bœsch wrote: [...] Can you add a FATE test similar to this? See tests/fate/filter-video.mak. similar to hqx I meant -- Clément B. pgpnPv6t6IHk6.pgp Description: PGP signature ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-26 Thread Michael Niedermayer
On Sun, Oct 26, 2014 at 02:51:48PM +0530, arwa arif wrote: I think the segmentation fault is maybe because of wrong input format. The code runs for rgb24 only. I have attached the updated patch along with the tested input file. I was not able to attach a video file. So, for now I am attaching

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-26 Thread arwa arif
The code is running fine on my laptop. What seg-fault log are you getting? Also, I looked on internet for converting rgb to yuv with integers, I got these equations. http://stackoverflow.com/questions/4979504/fast-rgb-yuv-conversion-in-opencl On Sun, Oct 26, 2014 at 4:27 PM, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-26 Thread Michael Niedermayer
On Sun, Oct 26, 2014 at 07:21:41PM +0530, arwa arif wrote: The code is running fine on my laptop. What seg-fault log are you getting? gdb --args ./ffplay_g images.jpeg -vf xbr,xbr ... Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fffeb1a6700 (LWP 11984)]

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-26 Thread Clément Bœsch
On Sun, Oct 26, 2014 at 02:51:48PM +0530, arwa arif wrote: [...] +/** +* Mixes a pixel A, with pixel B, with B's transperancy set to 'a' +* In other words, A is a solid color (bottom) and B is a transparent color (top) +**/ +static int mix(AVFrame *in,int x1,int y1,int x2,int y2,int a,int

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-26 Thread arwa arif
1. I think I understood what is giving you segmentation fault. The mask that I am creating is going out of bounds for the boundary pixels. I will try to fix it. But, I am curious why is it working on my laptop? 2. Thank you Clement for the mode part. It made the code look smaller. Also, I chose

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-25 Thread arwa arif
On Sat, Oct 25, 2014 at 1:01 AM, Michael Niedermayer michae...@gmx.at wrote: On Fri, Oct 24, 2014 at 10:34:32PM +0530, arwa arif wrote: I have taken care of aal the things mentioned except the floating point. I will update the floating point part till tomorrow. For now, I have attached

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-25 Thread arwa arif
Please ignore the previous mail. I attached the wrong patch. New patch is attached with this mail. On Sat, Oct 25, 2014 at 10:06 PM, arwa arif arwaarif1...@gmail.com wrote: On Sat, Oct 25, 2014 at 1:01 AM, Michael Niedermayer michae...@gmx.at wrote: On Fri, Oct 24, 2014 at 10:34:32PM

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-25 Thread arwa arif
On Sat, Oct 25, 2014 at 10:14 PM, arwa arif arwaarif1...@gmail.com wrote: Please ignore the previous mail. I attached the wrong patch. New patch is attached with this mail. On Sat, Oct 25, 2014 at 10:06 PM, arwa arif arwaarif1...@gmail.com wrote: On Sat, Oct 25, 2014 at 1:01 AM, Michael

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-25 Thread Nicolas George
Le quartidi 4 brumaire, an CCXXIII, arwa arif a écrit : please post a new patch instead of a patch on top of a previous patch libavfilter/vf_xbr.c | 303 ++ 1 file changed, 303 insertions(+) create mode 100644 libavfilter/vf_xbr.c This

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-25 Thread arwa arif
Can you please specify what is meant by stand-alone changes? Do I need to add the non-default functions in different commit? I am not very sure if I understood it right. Apart from that, I have updated the patch. On Sat, Oct 25, 2014 at 10:16 PM, Nicolas George geo...@nsup.org wrote: Le

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-25 Thread Nicolas George
Le quartidi 4 brumaire, an CCXXIII, arwa arif a écrit : Can you please specify what is meant by stand-alone changes? I believe it was already specified in my original message: such as moving code into a shared function, and pore importantly: it does not seem to apply here. Apart from that, I

[FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-24 Thread arwa arif
From a4b2a4fecbb147b285cf8609d9c0144081e3c40a Mon Sep 17 00:00:00 2001 From: Arwa Arif arwaarif1...@gmail.com Date: Fri, 24 Oct 2014 16:49:40 +0530 Subject: [PATCH] lvafi: add xBR filter Makefile allfilter.c --- libavfilter/Makefile |1 + libavfilter/allfilters.c |1 +

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-24 Thread arwa arif
I have taken care of aal the things mentioned except the floating point. I will update the floating point part till tomorrow. For now, I have attached the patch updated till now. On Fri, Oct 24, 2014 at 7:28 PM, Clément Bœsch u...@pkh.me wrote: On Fri, Oct 24, 2014 at 07:01:11PM +0530, arwa

Re: [FFmpeg-devel] [PATCH] lavfi: add xbr filter

2014-10-24 Thread Michael Niedermayer
On Fri, Oct 24, 2014 at 10:34:32PM +0530, arwa arif wrote: I have taken care of aal the things mentioned except the floating point. I will update the floating point part till tomorrow. For now, I have attached the patch updated till now. [...] vf_xbr.c | 418