Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50
tis 2020-08-18 klockan 15:21 +0100 skrev Mark Himsley: > Sorry to drag up this old thread: > > On Mon, 19 Aug 2019 at 17:55, Thomas Mundt > wrote: > ... > > I can give you the parameters that I use for IMX50. Not sure if these are > > the best. Got the intra matrix values from an original imx file. > > > > NTSC: -c:v mpeg2video -pix_fmt yuv422p -aspect 16:9 -top 1 -flags > > +ildct+ilme+low_delay -color_range tv -color_trc smpte170m -color_primaries > > smpte170m -colorspace smpte170m -chroma_sample_location topleft > > -signal_standard bt601 -dc 10 -intra_vlc 1 -non_linear_quant 1 -ps 1 -g 1 > > -qscale:v 1 -qmin 1 -qmax 12 -b:v 4841 -minrate 4841 -maxrate > > 4841 -bufsize 1668329 -rc_init_occupancy 1668329 -rc_min_vbv_use 1 > > -rc_max_vbv_use 1 -profile:v 0 -level:v 5 -intra_matrix > > 8,16,16,17,19,22,23,31,16,16,17,19,20,23,29,29,19,17,19,22,19,25,28 > > ,35,17,19,19,20,25,28,25,33,17,19,22,25,26,25,31,31,17,19,17,20,26, > > 28,35,36,19,19,19,20,22,29,32,35,16,17,19,22,25,31,28,45 > > > > PAL: -c:v mpeg2video -pix_fmt yuv422p -aspect 16:9 -top 1 -flags > > +ildct+ilme+low_delay -color_range tv -color_trc smpte170m -color_primaries > > bt470bg -colorspace bt470bg -chroma_sample_location topleft > > -signal_standard bt601 -dc 10 -intra_vlc 1 -non_linear_quant 1 -ps 1 -g 1 > > -qscale:v 1 -qmin 1 -qmax 12 -b:v 5000 -minrate 5000 -maxrate > > 5000 -bufsize 200 -rc_init_occupancy 200 -rc_min_vbv_use 1 > > -rc_max_vbv_use 1 -profile:v 0 -level:v 5 -intra_matrix > > 8,16,16,17,19,22,23,31,16,16,17,19,20,23,29,29,19,17,19,22,19,25,28 > > ,35,17,19,19,20,25,28,25,33,17,19,22,25,26,25,31,31,17,19,17,20,26, > > 28,35,36,19,19,19,20,22,29,32,35,16,17,19,22,25,31,28,45 > > > > Regards, > > Thomas > > As it stands, FFmpeg from `master` cannot create 3/1001 FPS IMX50, > and it has to be patched to allow 4841 to be the valid bitrate, > not 48410 which is in the source code. > Is there any movement on this issue? > Why is 4840 in the source code as a variant on 5000 when it > just does not work? > Is it not better to put 4841 into the source code? The problem is that bitrate is an integer, whereas CBR NTSC bitrate is fractional. The muxer could be made to accept a narrow range of bitrate metadata values of course. The real problem is rate control in the MPEG-2 encoder. It is currently not possible to create 50 Mbps CBR NTSC essence with lavc, so this whole discussion became moot. The proper fix for this is to implement CBR encoding via a "bytes per packet" field. /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50
Sorry to drag up this old thread: On Mon, 19 Aug 2019 at 17:55, Thomas Mundt wrote: ... > I can give you the parameters that I use for IMX50. Not sure if these are > the best. Got the intra matrix values from an original imx file. > > NTSC: -c:v mpeg2video -pix_fmt yuv422p -aspect 16:9 -top 1 -flags > +ildct+ilme+low_delay -color_range tv -color_trc smpte170m -color_primaries > smpte170m -colorspace smpte170m -chroma_sample_location topleft > -signal_standard bt601 -dc 10 -intra_vlc 1 -non_linear_quant 1 -ps 1 -g 1 > -qscale:v 1 -qmin 1 -qmax 12 -b:v 4841 -minrate 4841 -maxrate > 4841 -bufsize 1668329 -rc_init_occupancy 1668329 -rc_min_vbv_use 1 > -rc_max_vbv_use 1 -profile:v 0 -level:v 5 -intra_matrix > 8,16,16,17,19,22,23,31,16,16,17,19,20,23,29,29,19,17,19,22,19,25,28,35,17,19,19,20,25,28,25,33,17,19,22,25,26,25,31,31,17,19,17,20,26,28,35,36,19,19,19,20,22,29,32,35,16,17,19,22,25,31,28,45 > > PAL: -c:v mpeg2video -pix_fmt yuv422p -aspect 16:9 -top 1 -flags > +ildct+ilme+low_delay -color_range tv -color_trc smpte170m -color_primaries > bt470bg -colorspace bt470bg -chroma_sample_location topleft > -signal_standard bt601 -dc 10 -intra_vlc 1 -non_linear_quant 1 -ps 1 -g 1 > -qscale:v 1 -qmin 1 -qmax 12 -b:v 5000 -minrate 5000 -maxrate > 5000 -bufsize 200 -rc_init_occupancy 200 -rc_min_vbv_use 1 > -rc_max_vbv_use 1 -profile:v 0 -level:v 5 -intra_matrix > 8,16,16,17,19,22,23,31,16,16,17,19,20,23,29,29,19,17,19,22,19,25,28,35,17,19,19,20,25,28,25,33,17,19,22,25,26,25,31,31,17,19,17,20,26,28,35,36,19,19,19,20,22,29,32,35,16,17,19,22,25,31,28,45 > > Regards, > Thomas As it stands, FFmpeg from `master` cannot create 3/1001 FPS IMX50, and it has to be patched to allow 4841 to be the valid bitrate, not 48410 which is in the source code. Is there any movement on this issue? Why is 4840 in the source code as a variant on 5000 when it just does not work? Is it not better to put 4841 into the source code? -- Mark Himsley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50
tor 2019-08-22 klockan 09:17 -0700 skrev Baptiste Coudurier: > Hi Tomas > > > > On Aug 22, 2019, at 3:47 AM, Tomas Härdin wrote: > > > > ons 2019-08-21 klockan 12:47 -0700 skrev Baptiste Coudurier: > > > Hey guys, > > > > > > Yeah, it’s been an issue for quite some time, s356m mentions: > > > "When used as a signal source for the type D-10 recording format, the > > > bit stream is carried by SDTI-CP, as defined in SMPTE 326M, using > > > recommended operating point bit rates as defined in this annex. Other > > > bit rates may be used. However, users are cautioned that other system > > > design parameters within the studio may not support all bit rates. > > > > > > Table A.1 indicates recommended operating points to simplify studio > > > operations and to provide users with a tool to be used in designing > > > systems." > > > > > > Then specifies the exact value of the sequence_header bit_rate_value, > > > 50mit/s being “1E848h”, "To be used when compliant with EBU D84 and > > > D85" > > > > mpeg12enc.c does this, if I read it correctly. 4840 / 400 = > > 124999.6 which gets rounded up to 125000. > > Oh, that’s good actually. > > > > I don’t think it is a good idea to produce files with the wrong > > > bit_rate value, and I know for a fact that many file analyzers in use > > > today will simply reject the d-10 essence. > > > > Would writing 5000 in mxfenc for values in the range > > [4840,5000] make it pass? > > If the d-10 mpeg-2 essence has the right bit_rate value, the analyzer works. > Thinking about this, and assuming the seq header bit_rate_value is correctly > set, > Could we infer the D-10 UL after the first frame according to the mpeg-2 > essence ? > That would guarantee correctness and eliminate the hackish bitrate check. We could write a tentative D-10 UL and change it if any packet is off, or maybe error out with a suggestion to pester the relevant people for a proper CBR encoding option :] If the output file isn't seekable (quite probable when dealing with tape formats) then writing the header will have to be delayed until the first packet has been inspected We're definitely going to need something in the manual for this, since D-10 is used in lots of places /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50
Hi Tomas > On Aug 22, 2019, at 3:47 AM, Tomas Härdin wrote: > > ons 2019-08-21 klockan 12:47 -0700 skrev Baptiste Coudurier: >> Hey guys, >> >> >>> On Aug 19, 2019, at 9:54 AM, Thomas Mundt wrote: >>> >>> Am Fr., 16. Aug. 2019 um 23:31 Uhr schrieb Tomas Härdin >>> : tor 2019-08-15 klockan 13:55 +0200 skrev Thomas Mundt: > Am Do., 15. Aug. 2019 um 11:01 Uhr schrieb Tomas Härdin < tjop...@acc.umu.se >> : >> ons 2019-08-14 klockan 22:18 +0200 skrev Thomas Mundt: >>> >>> New patch attached. >> >> Looks OK. I'll push in a few days if no one else has any comments >> > > Thanks. Would you mind porting it to branches 4.1 and 4.2? I'm not quite sure what the process is for that. I have confirmed that the problem exists in 4.1 and 4.2 and that your patch fixes it. I think we also might want to put a note somewhere in the documentation how to make NTSC IMX50 files. >> >> Yeah, it’s been an issue for quite some time, s356m mentions: >> "When used as a signal source for the type D-10 recording format, the >> bit stream is carried by SDTI-CP, as defined in SMPTE 326M, using >> recommended operating point bit rates as defined in this annex. Other >> bit rates may be used. However, users are cautioned that other system >> design parameters within the studio may not support all bit rates. >> >> Table A.1 indicates recommended operating points to simplify studio >> operations and to provide users with a tool to be used in designing >> systems." >> >> Then specifies the exact value of the sequence_header bit_rate_value, >> 50mit/s being “1E848h”, "To be used when compliant with EBU D84 and >> D85" > > mpeg12enc.c does this, if I read it correctly. 4840 / 400 = > 124999.6 which gets rounded up to 125000. Oh, that’s good actually. >> I don’t think it is a good idea to produce files with the wrong >> bit_rate value, and I know for a fact that many file analyzers in use >> today will simply reject the d-10 essence. > > Would writing 5000 in mxfenc for values in the range > [4840,5000] make it pass? If the d-10 mpeg-2 essence has the right bit_rate value, the analyzer works. Thinking about this, and assuming the seq header bit_rate_value is correctly set, Could we infer the D-10 UL after the first frame according to the mpeg-2 essence ? That would guarantee correctness and eliminate the hackish bitrate check. Thanks! — Baptiste ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50
ons 2019-08-21 klockan 12:47 -0700 skrev Baptiste Coudurier: > Hey guys, > > > > On Aug 19, 2019, at 9:54 AM, Thomas Mundt wrote: > > > > Am Fr., 16. Aug. 2019 um 23:31 Uhr schrieb Tomas Härdin > > : > > > tor 2019-08-15 klockan 13:55 +0200 skrev Thomas Mundt: > > > > Am Do., 15. Aug. 2019 um 11:01 Uhr schrieb Tomas Härdin < > > > tjop...@acc.umu.se > > > > > : > > > > > ons 2019-08-14 klockan 22:18 +0200 skrev Thomas Mundt: > > > > > > > > > > > > New patch attached. > > > > > > > > > > Looks OK. I'll push in a few days if no one else has any comments > > > > > > > > > > > > > Thanks. Would you mind porting it to branches 4.1 and 4.2? > > > > > > I'm not quite sure what the process is for that. I have confirmed that > > > the problem exists in 4.1 and 4.2 and that your patch fixes it. > > > > > > I think we also might want to put a note somewhere in the documentation > > > how to make NTSC IMX50 files. > > > > > Yeah, it’s been an issue for quite some time, s356m mentions: > "When used as a signal source for the type D-10 recording format, the > bit stream is carried by SDTI-CP, as defined in SMPTE 326M, using > recommended operating point bit rates as defined in this annex. Other > bit rates may be used. However, users are cautioned that other system > design parameters within the studio may not support all bit rates. > > Table A.1 indicates recommended operating points to simplify studio > operations and to provide users with a tool to be used in designing > systems." > > Then specifies the exact value of the sequence_header bit_rate_value, > 50mit/s being “1E848h”, "To be used when compliant with EBU D84 and > D85" mpeg12enc.c does this, if I read it correctly. 4840 / 400 = 124999.6 which gets rounded up to 125000. > I don’t think it is a good idea to produce files with the wrong > bit_rate value, and I know for a fact that many file analyzers in use > today will simply reject the d-10 essence. Would writing 5000 in mxfenc for values in the range [4840,5000] make it pass? > The current code is simply a hack, and IMHO the right solution is to > put an option to force the ratecontrol to behave as people want for > NTSC D-10. I’ve submitted a patch for that but Michael wanted it as > an option. An option to set the exact desired packet size would be useful for other things too, so sounds like a good idea. /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50
Hey guys,
> On Aug 19, 2019, at 9:54 AM, Thomas Mundt wrote:
>
> Am Fr., 16. Aug. 2019 um 23:31 Uhr schrieb Tomas Härdin > :
>
>> tor 2019-08-15 klockan 13:55 +0200 skrev Thomas Mundt:
>>> Am Do., 15. Aug. 2019 um 11:01 Uhr schrieb Tomas Härdin <
>> tjop...@acc.umu.se
:
ons 2019-08-14 klockan 22:18 +0200 skrev Thomas Mundt:
> Hi Tomas,
>
> Am Mi., 14. Aug. 2019 um 12:42 Uhr schrieb Tomas Härdin <
tjop...@acc.umu.se
>> :
>> tis 2019-08-13 klockan 22:03 +0200 skrev Thomas Mundt:
>>> Hi,
>>>
>>> attached patch fixes ticket #8077.
>>> Please comment.
>>
>> Probably OK, bitrates lower than 5000 are fine in D-10
>> according to
>> S356m.
>>
>>> } else if ((sc->video_bit_rate >= 4840) &&
>> (sc->video_bit_rate <=
>>> 5000) && (mxf->time_base.den != 25)) {
>>
>> You could drop the extra parentheses, else it should be fine.
>>
>
> New patch attached.
Looks OK. I'll push in a few days if no one else has any comments
>>>
>>> Thanks. Would you mind porting it to branches 4.1 and 4.2?
>>
>> I'm not quite sure what the process is for that. I have confirmed that
>> the problem exists in 4.1 and 4.2 and that your patch fixes it.
>>
>> I think we also might want to put a note somewhere in the documentation
>> how to make NTSC IMX50 files.
>>
Yeah, it’s been an issue for quite some time, s356m mentions:
"When used as a signal source for the type D-10 recording format, the bit
stream is carried by SDTI-CP, as defined in SMPTE 326M, using recommended
operating point bit rates as defined in this annex. Other bit rates may be
used. However, users are cautioned that other system design parameters within
the studio may not support all bit rates.
Table A.1 indicates recommended operating points to simplify studio operations
and to provide users with a tool to be used in designing systems."
Then specifies the exact value of the sequence_header bit_rate_value, 50mit/s
being “1E848h”, "To be used when compliant with EBU D84 and D85"
I don’t think it is a good idea to produce files with the wrong bit_rate value,
and I know for a fact that many file analyzers in use today will simply reject
the d-10 essence.
The current code is simply a hack, and IMHO the right solution is to put an
option to force the ratecontrol to behave as people want for NTSC D-10. I’ve
submitted a patch for that but Michael wanted it as an option.
—
Baptiste
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50
Am Fr., 16. Aug. 2019 um 23:31 Uhr schrieb Tomas Härdin :
> tor 2019-08-15 klockan 13:55 +0200 skrev Thomas Mundt:
> > Am Do., 15. Aug. 2019 um 11:01 Uhr schrieb Tomas Härdin <
> tjop...@acc.umu.se
> > > :
> > > ons 2019-08-14 klockan 22:18 +0200 skrev Thomas Mundt:
> > > > Hi Tomas,
> > > >
> > > > Am Mi., 14. Aug. 2019 um 12:42 Uhr schrieb Tomas Härdin <
> > > tjop...@acc.umu.se
> > > > > :
> > > > > tis 2019-08-13 klockan 22:03 +0200 skrev Thomas Mundt:
> > > > > > Hi,
> > > > > >
> > > > > > attached patch fixes ticket #8077.
> > > > > > Please comment.
> > > > >
> > > > > Probably OK, bitrates lower than 5000 are fine in D-10
> according to
> > > > > S356m.
> > > > >
> > > > > > } else if ((sc->video_bit_rate >= 4840) &&
> (sc->video_bit_rate <=
> > > > > > 5000) && (mxf->time_base.den != 25)) {
> > > > >
> > > > > You could drop the extra parentheses, else it should be fine.
> > > > >
> > > >
> > > > New patch attached.
> > >
> > > Looks OK. I'll push in a few days if no one else has any comments
> > >
> >
> > Thanks. Would you mind porting it to branches 4.1 and 4.2?
>
> I'm not quite sure what the process is for that. I have confirmed that
> the problem exists in 4.1 and 4.2 and that your patch fixes it.
>
> I think we also might want to put a note somewhere in the documentation
> how to make NTSC IMX50 files.
>
I can give you the parameters that I use for IMX50. Not sure if these are
the best. Got the intra matrix values from an original imx file.
NTSC: -c:v mpeg2video -pix_fmt yuv422p -aspect 16:9 -top 1 -flags
+ildct+ilme+low_delay -color_range tv -color_trc smpte170m -color_primaries
smpte170m -colorspace smpte170m -chroma_sample_location topleft
-signal_standard bt601 -dc 10 -intra_vlc 1 -non_linear_quant 1 -ps 1 -g 1
-qscale:v 1 -qmin 1 -qmax 12 -b:v 4841 -minrate 4841 -maxrate
4841 -bufsize 1668329 -rc_init_occupancy 1668329 -rc_min_vbv_use 1
-rc_max_vbv_use 1 -profile:v 0 -level:v 5 -intra_matrix
8,16,16,17,19,22,23,31,16,16,17,19,20,23,29,29,19,17,19,22,19,25,28,35,17,19,19,20,25,28,25,33,17,19,22,25,26,25,31,31,17,19,17,20,26,28,35,36,19,19,19,20,22,29,32,35,16,17,19,22,25,31,28,45
PAL: -c:v mpeg2video -pix_fmt yuv422p -aspect 16:9 -top 1 -flags
+ildct+ilme+low_delay -color_range tv -color_trc smpte170m -color_primaries
bt470bg -colorspace bt470bg -chroma_sample_location topleft
-signal_standard bt601 -dc 10 -intra_vlc 1 -non_linear_quant 1 -ps 1 -g 1
-qscale:v 1 -qmin 1 -qmax 12 -b:v 5000 -minrate 5000 -maxrate
5000 -bufsize 200 -rc_init_occupancy 200 -rc_min_vbv_use 1
-rc_max_vbv_use 1 -profile:v 0 -level:v 5 -intra_matrix
8,16,16,17,19,22,23,31,16,16,17,19,20,23,29,29,19,17,19,22,19,25,28,35,17,19,19,20,25,28,25,33,17,19,22,25,26,25,31,31,17,19,17,20,26,28,35,36,19,19,19,20,22,29,32,35,16,17,19,22,25,31,28,45
Regards,
Thomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50
On 8/16/2019 7:32 PM, Tomas Härdin wrote:
> fre 2019-08-16 klockan 19:26 -0300 skrev James Almer:
>> On 8/16/2019 6:31 PM, Tomas Härdin wrote:
>>> tor 2019-08-15 klockan 13:55 +0200 skrev Thomas Mundt:
Am Do., 15. Aug. 2019 um 11:01 Uhr schrieb Tomas Härdin :
> ons 2019-08-14 klockan 22:18 +0200 skrev Thomas Mundt:
>> Hi Tomas,
>>
>> Am Mi., 14. Aug. 2019 um 12:42 Uhr schrieb Tomas Härdin <
> tjop...@acc.umu.se
>>> :
>>> tis 2019-08-13 klockan 22:03 +0200 skrev Thomas Mundt:
Hi,
attached patch fixes ticket #8077.
Please comment.
>>>
>>> Probably OK, bitrates lower than 5000 are fine in D-10 according to
>>> S356m.
>>>
} else if ((sc->video_bit_rate >= 4840) && (sc->video_bit_rate <=
5000) && (mxf->time_base.den != 25)) {
>>>
>>> You could drop the extra parentheses, else it should be fine.
>>>
>>
>> New patch attached.
>
> Looks OK. I'll push in a few days if no one else has any comments
>
Thanks. Would you mind porting it to branches 4.1 and 4.2?
>>>
>>> I'm not quite sure what the process is for that. I have confirmed that
>>> the problem exists in 4.1 and 4.2 and that your patch fixes it.
>>>
>>> I think we also might want to put a note somewhere in the documentation
>>> how to make NTSC IMX50 files.
>>>
>>> /Tomas
>>
>> Use git cherry-pick -x $hash while in the 4.1 and 4.2 branches.
>> If there are no conflicts, it will be applied and committed without
>> extra work. If there are conflicts, it will ask you to solve them and
>> then manually commit the changes.
>>
>> There shouldn't be any conflicts with 4.2 since that branch was cut a
>> few weeks ago, but i can't say with 4.1 since there were several changes
>> since 4.1 was cut.
>
> It applies fine to both 4.1 and 4.2, and master of course. I'm more
> thinking in terms of what goes in the changelog, documentation and so
> on. Judging by "11.1 Criteria for Point Releases" fixing a regression
> like this is certainly OK, and documentation about it as well.
>
> It's getting late, I'll think about this tomorrow.
>
> /Tomas
Michael updates Changelog to list every backported patch at the time of
a point release, but nothing stops you from pushing a second commit to
the branches adding the line yourself if you want.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50
fre 2019-08-16 klockan 19:26 -0300 skrev James Almer:
> On 8/16/2019 6:31 PM, Tomas Härdin wrote:
> > tor 2019-08-15 klockan 13:55 +0200 skrev Thomas Mundt:
> > > Am Do., 15. Aug. 2019 um 11:01 Uhr schrieb Tomas Härdin
> > > > > > :
> > > > ons 2019-08-14 klockan 22:18 +0200 skrev Thomas Mundt:
> > > > > Hi Tomas,
> > > > >
> > > > > Am Mi., 14. Aug. 2019 um 12:42 Uhr schrieb Tomas Härdin <
> > > > tjop...@acc.umu.se
> > > > > > :
> > > > > > tis 2019-08-13 klockan 22:03 +0200 skrev Thomas Mundt:
> > > > > > > Hi,
> > > > > > >
> > > > > > > attached patch fixes ticket #8077.
> > > > > > > Please comment.
> > > > > >
> > > > > > Probably OK, bitrates lower than 5000 are fine in D-10
> > > > > > according to
> > > > > > S356m.
> > > > > >
> > > > > > > } else if ((sc->video_bit_rate >= 4840) &&
> > > > > > > (sc->video_bit_rate <=
> > > > > > > 5000) && (mxf->time_base.den != 25)) {
> > > > > >
> > > > > > You could drop the extra parentheses, else it should be fine.
> > > > > >
> > > > >
> > > > > New patch attached.
> > > >
> > > > Looks OK. I'll push in a few days if no one else has any comments
> > > >
> > >
> > > Thanks. Would you mind porting it to branches 4.1 and 4.2?
> >
> > I'm not quite sure what the process is for that. I have confirmed that
> > the problem exists in 4.1 and 4.2 and that your patch fixes it.
> >
> > I think we also might want to put a note somewhere in the documentation
> > how to make NTSC IMX50 files.
> >
> > /Tomas
>
> Use git cherry-pick -x $hash while in the 4.1 and 4.2 branches.
> If there are no conflicts, it will be applied and committed without
> extra work. If there are conflicts, it will ask you to solve them and
> then manually commit the changes.
>
> There shouldn't be any conflicts with 4.2 since that branch was cut a
> few weeks ago, but i can't say with 4.1 since there were several changes
> since 4.1 was cut.
It applies fine to both 4.1 and 4.2, and master of course. I'm more
thinking in terms of what goes in the changelog, documentation and so
on. Judging by "11.1 Criteria for Point Releases" fixing a regression
like this is certainly OK, and documentation about it as well.
It's getting late, I'll think about this tomorrow.
/Tomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50
On 8/16/2019 6:31 PM, Tomas Härdin wrote:
> tor 2019-08-15 klockan 13:55 +0200 skrev Thomas Mundt:
>> Am Do., 15. Aug. 2019 um 11:01 Uhr schrieb Tomas Härdin >> :
>>> ons 2019-08-14 klockan 22:18 +0200 skrev Thomas Mundt:
Hi Tomas,
Am Mi., 14. Aug. 2019 um 12:42 Uhr schrieb Tomas Härdin <
>>> tjop...@acc.umu.se
> :
> tis 2019-08-13 klockan 22:03 +0200 skrev Thomas Mundt:
>> Hi,
>>
>> attached patch fixes ticket #8077.
>> Please comment.
>
> Probably OK, bitrates lower than 5000 are fine in D-10 according to
> S356m.
>
>> } else if ((sc->video_bit_rate >= 4840) && (sc->video_bit_rate <=
>> 5000) && (mxf->time_base.den != 25)) {
>
> You could drop the extra parentheses, else it should be fine.
>
New patch attached.
>>>
>>> Looks OK. I'll push in a few days if no one else has any comments
>>>
>>
>> Thanks. Would you mind porting it to branches 4.1 and 4.2?
>
> I'm not quite sure what the process is for that. I have confirmed that
> the problem exists in 4.1 and 4.2 and that your patch fixes it.
>
> I think we also might want to put a note somewhere in the documentation
> how to make NTSC IMX50 files.
>
> /Tomas
Use git cherry-pick -x $hash while in the 4.1 and 4.2 branches.
If there are no conflicts, it will be applied and committed without
extra work. If there are conflicts, it will ask you to solve them and
then manually commit the changes.
There shouldn't be any conflicts with 4.2 since that branch was cut a
few weeks ago, but i can't say with 4.1 since there were several changes
since 4.1 was cut.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50
tor 2019-08-15 klockan 13:55 +0200 skrev Thomas Mundt:
> Am Do., 15. Aug. 2019 um 11:01 Uhr schrieb Tomas Härdin > :
> > ons 2019-08-14 klockan 22:18 +0200 skrev Thomas Mundt:
> > > Hi Tomas,
> > >
> > > Am Mi., 14. Aug. 2019 um 12:42 Uhr schrieb Tomas Härdin <
> > tjop...@acc.umu.se
> > > > :
> > > > tis 2019-08-13 klockan 22:03 +0200 skrev Thomas Mundt:
> > > > > Hi,
> > > > >
> > > > > attached patch fixes ticket #8077.
> > > > > Please comment.
> > > >
> > > > Probably OK, bitrates lower than 5000 are fine in D-10 according to
> > > > S356m.
> > > >
> > > > > } else if ((sc->video_bit_rate >= 4840) && (sc->video_bit_rate <=
> > > > > 5000) && (mxf->time_base.den != 25)) {
> > > >
> > > > You could drop the extra parentheses, else it should be fine.
> > > >
> > >
> > > New patch attached.
> >
> > Looks OK. I'll push in a few days if no one else has any comments
> >
>
> Thanks. Would you mind porting it to branches 4.1 and 4.2?
I'm not quite sure what the process is for that. I have confirmed that
the problem exists in 4.1 and 4.2 and that your patch fixes it.
I think we also might want to put a note somewhere in the documentation
how to make NTSC IMX50 files.
/Tomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50
Am Do., 15. Aug. 2019 um 11:01 Uhr schrieb Tomas Härdin :
> ons 2019-08-14 klockan 22:18 +0200 skrev Thomas Mundt:
> > Hi Tomas,
> >
> > Am Mi., 14. Aug. 2019 um 12:42 Uhr schrieb Tomas Härdin <
> tjop...@acc.umu.se
> > > :
> > > tis 2019-08-13 klockan 22:03 +0200 skrev Thomas Mundt:
> > > > Hi,
> > > >
> > > > attached patch fixes ticket #8077.
> > > > Please comment.
> > >
> > > Probably OK, bitrates lower than 5000 are fine in D-10 according to
> > > S356m.
> > >
> > > > } else if ((sc->video_bit_rate >= 4840) && (sc->video_bit_rate <=
> > > > 5000) && (mxf->time_base.den != 25)) {
> > >
> > > You could drop the extra parentheses, else it should be fine.
> > >
> >
> > New patch attached.
>
> Looks OK. I'll push in a few days if no one else has any comments
>
Thanks. Would you mind porting it to branches 4.1 and 4.2?
> > > The real fix is of course to add an explicit CBR mode to lavc, but
> > > that's a bit more involved than this fix.
> >
> > IMX is being used less and less. Maybe it´s not worth the effort.
>
> It's not the only case where CBR MPEG-2 is desireable I think.
> Certainly outside my concern however. Maybe something for x262? Since
> x264 has such a mode I wouldn't be surprised if x262 does as well.
>
Yeah, a CBR option would definitely make it easier for users.
So far I have not dealt with x262.
Regards,
Thomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50
ons 2019-08-14 klockan 22:18 +0200 skrev Thomas Mundt:
> Hi Tomas,
>
> Am Mi., 14. Aug. 2019 um 12:42 Uhr schrieb Tomas Härdin > :
> > tis 2019-08-13 klockan 22:03 +0200 skrev Thomas Mundt:
> > > Hi,
> > >
> > > attached patch fixes ticket #8077.
> > > Please comment.
> >
> > Probably OK, bitrates lower than 5000 are fine in D-10 according to
> > S356m.
> >
> > > } else if ((sc->video_bit_rate >= 4840) && (sc->video_bit_rate <=
> > > 5000) && (mxf->time_base.den != 25)) {
> >
> > You could drop the extra parentheses, else it should be fine.
> >
>
> New patch attached.
Looks OK. I'll push in a few days if no one else has any comments
> > The real fix is of course to add an explicit CBR mode to lavc, but
> > that's a bit more involved than this fix.
>
> IMX is being used less and less. Maybe it´s not worth the effort.
It's not the only case where CBR MPEG-2 is desireable I think.
Certainly outside my concern however. Maybe something for x262? Since
x264 has such a mode I wouldn't be surprised if x262 does as well.
/Tomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50
Hi Tomas,
Am Mi., 14. Aug. 2019 um 12:42 Uhr schrieb Tomas Härdin :
> tis 2019-08-13 klockan 22:03 +0200 skrev Thomas Mundt:
> > Hi,
> >
> > attached patch fixes ticket #8077.
> > Please comment.
>
> Probably OK, bitrates lower than 5000 are fine in D-10 according to
> S356m.
>
> > } else if ((sc->video_bit_rate >= 4840) && (sc->video_bit_rate <=
> > 5000) && (mxf->time_base.den != 25)) {
>
> You could drop the extra parentheses, else it should be fine.
>
New patch attached.
The real fix is of course to add an explicit CBR mode to lavc, but
> that's a bit more involved than this fix.
IMX is being used less and less. Maybe it´s not worth the effort.
Regards,
Thomas
0001-libavformat-mxfenc-Allow-more-bitrates-for-NTSC-IMX5.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50
tis 2019-08-13 klockan 22:03 +0200 skrev Thomas Mundt:
> Hi,
>
> attached patch fixes ticket #8077.
> Please comment.
Probably OK, bitrates lower than 5000 are fine in D-10 according to
S356m.
> } else if ((sc->video_bit_rate >= 4840) && (sc->video_bit_rate <=
> 5000) && (mxf->time_base.den != 25)) {
You could drop the extra parentheses, else it should be fine.
The real fix is of course to add an explicit CBR mode to lavc, but
that's a bit more involved than this fix. Removing the padding from the
old code was probably a mistake, we should come up with a better
solution. Baptiste?
It bears repeating that S356m explicitly allows VBR (still intra-only)
so long as the frames are no larger than 25 and 208541 for PAL and
NTSC respectively. I don't recall whether the MXF file itself needs to
be CBR (via KLV fill).
/Tomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH] libavformat/mxfenc: Allow more bitrates for NTSC IMX50
Hi, attached patch fixes ticket #8077. Please comment. Regards, Thomas 0001-libavformat-mxfenc-Allow-more-bitrates-for-NTSC-IMX5.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
