Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

2019-06-04 Thread Reimar Döffinger
On 04.06.2019, at 15:07, Andreas Håkon wrote: > Hi, > > I need to admit that I'm completely wrong in the end. After spending a lot > of time on a patch to solve the problem (making the MPEG-2 QSV encoder > compatible with broadcasts), I discovered that this solution works: > > $ ffmpeg ...

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

2019-06-04 Thread Andreas Håkon
Hi, I need to admit that I'm completely wrong in the end. After spending a lot of time on a patch to solve the problem (making the MPEG-2 QSV encoder compatible with broadcasts), I discovered that this solution works: $ ffmpeg ... -c:v mpeg2_qsv -bsf:v 'dump_extra' -f mpegts ... Using this

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

2019-06-04 Thread Andreas Håkon
Hi A. Rheinhardt , > > Take note that the "dump_extra" filter with the parameter "remove" can be > > used to remove > > the repetition. But contrary to popular belief (IMHO), there is no way to > > repeat these > > headers using a bitstream filter. So for this reason this patch is > >

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

2019-06-04 Thread Andreas Rheinhardt
Andreas Håkon: > On Thursday, 30 de May de 2019 20:48, Reimar Döffinger > wrote: >> I admit this also applies to the native mpeg2 encoder, so this might be a >> design issue >> in FFmpeg, but it's the background why it feels a bit wrong to do it in the >> encoder... > > Take note that the

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

2019-06-04 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Thursday, 30 de May de 2019 20:48, Reimar Döffinger wrote: > On 28.05.2019, at 12:48, Andreas Håkonandreas.ha...@protonmail.com wrote: > > > Hi, > > This patch supersedes #13105 (https://patchwork.ffmpeg.org/patch/13105/) > > A new (simpler and

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

2019-05-30 Thread Reimar Döffinger
On 28.05.2019, at 12:48, Andreas Håkon wrote: > Hi, > > This patch supersedes #13105 (https://patchwork.ffmpeg.org/patch/13105/) > > A new (simpler and more robust) implementationof of the reinsertion of the > missing headers in the MPEG-2 bitstream from the HW QSV encoder. > > The problem

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

2019-05-30 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Andreas Håkon > Sent: Tuesday, May 28, 2019 6:48 PM > To: FFmpeg development discussions and patches > > Subject: [FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing > headers [v2] >

[FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

2019-05-28 Thread Andreas Håkon
Hi, This patch supersedes #13105 (https://patchwork.ffmpeg.org/patch/13105/) A new (simpler and more robust) implementationof of the reinsertion of the missing headers in the MPEG-2 bitstream from the HW QSV encoder. The problem is quite simple: The bitstream generated by the MPEG-2 QSV encoder