Re: [FFmpeg-devel] [PATCH] mov: better check dref atome validity

2014-08-21 Thread Derek Buitenhuis
On 8/21/2014 4:13 PM, Michael Niedermayer wrote: > can you provide a link ? Provided on IRC. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] mov: better check dref atome validity

2014-08-21 Thread Michael Niedermayer
On Thu, Aug 21, 2014 at 01:55:05PM +0100, Derek Buitenhuis wrote: > On 8/21/2014 12:09 PM, Christophe Gisquet wrote: > > I'm not sure it is the best fix, but I don't think this could happen > > in any valid file, nor it would help to swallow the error. > > Perhaps off-topic, but the source drop fr

Re: [FFmpeg-devel] [PATCH] mov: better check dref atome validity

2014-08-21 Thread Christophe Gisquet
Hi, 2014-08-21 14:55 GMT+02:00 Derek Buitenhuis : > On 8/21/2014 12:09 PM, Christophe Gisquet wrote: >> I'm not sure it is the best fix, but I don't think this could happen >> in any valid file, nor it would help to swallow the error. > > Perhaps off-topic, but the source drop from Elemental seems

Re: [FFmpeg-devel] [PATCH] mov: better check dref atome validity

2014-08-21 Thread Derek Buitenhuis
On 8/21/2014 12:09 PM, Christophe Gisquet wrote: > I'm not sure it is the best fix, but I don't think this could happen > in any valid file, nor it would help to swallow the error. Perhaps off-topic, but the source drop from Elemental seems to include completely rewritten dref code -- is it worth

[FFmpeg-devel] [PATCH] mov: better check dref atome validity

2014-08-21 Thread Christophe Gisquet
Hi, the fuzzed file from ticket #3866 somehow ends on reading a dref atom, where a size element is not validated. The reading then skips that arbitrary amount without reporting an issue. I'm not sure it is the best fix, but I don't think this could happen in any valid file, nor it would help to s