Re: [FFmpeg-devel] [PATCH] movtextdec: Use default style information from movtext header

2015-08-12 Thread Clément Bœsch
On Wed, Aug 12, 2015 at 06:24:32PM +0530, Niklesh Lalwani wrote: [...] +#define BOTTOM_LEFT 1 +#define BOTTOM_CENTER 2 +#define BOTTOM_RIGHT3 +#define MIDDLE_LEFT 4 +#define MIDDLE_CENTER 5 +#define MIDDLE_RIGHT6 +#define TOP_LEFT7 +#define TOP_CENTER 8

Re: [FFmpeg-devel] [PATCH] movtextdec: Use default style information from movtext header

2015-08-12 Thread Philip Langdale
On Wed, 12 Aug 2015 18:24:32 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: From: Niklesh niklesh.lalw...@iitb.ac.in As suggested, posting the combined patch with the fate changes. The patch sets the default style in ASS from the default style information present in the movtext

[FFmpeg-devel] [PATCH] movtextdec: Use default style information from movtext header

2015-08-12 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in As suggested, posting the combined patch with the fate changes. The patch sets the default style in ASS from the default style information present in the movtext header. Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c

[FFmpeg-devel] [PATCH] movtextdec: Use default style information from movtext header

2015-08-09 Thread Niklesh Lalwani
From: Niklesh niklesh.lalw...@iitb.ac.in Sets the default style in ASS from the default style information present in movtext header Signed-off-by: Niklesh niklesh.lalw...@iitb.ac.in --- libavcodec/movtextdec.c | 82 ++--- 1 file changed, 78

Re: [FFmpeg-devel] [PATCH] movtextdec: Use default style information from movtext header

2015-08-09 Thread Philip Langdale
On Mon, 10 Aug 2015 01:18:58 +0530 Niklesh Lalwani niklesh.lalw...@iitb.ac.in wrote: + +typedef struct { +char *font; +int fontsize; +int color; +int back_color; +int bold; +int italic; +int underline; +int alignment; +}

Re: [FFmpeg-devel] [PATCH] movtextdec: Use default style information from movtext header

2015-08-09 Thread Niklesh Lalwani
+ +typedef struct { +char *font; +int fontsize; +int color; +int back_color; +int bold; +int italic; +int underline; +int alignment; +} Movtext_default; + This name is inconsistent. Use MovTextDefault. Yes, makes sense. Updated patch

Re: [FFmpeg-devel] [PATCH] movtextdec: Use default style information from movtext header

2015-08-09 Thread Michael Niedermayer
On Mon, Aug 10, 2015 at 01:18:58AM +0530, Niklesh Lalwani wrote: + +typedef struct { +char *font; +int fontsize; +int color; +int back_color; +int bold; +int italic; +int underline; +int alignment; +} Movtext_default; + This