Re: [FFmpeg-devel] [PATCH]Do not add extradata size to bitmapinfoheader size

2014-09-28 Thread Reimar Döffinger
On Sat, Sep 27, 2014 at 10:51:25AM +0200, Carl Eugen Hoyos wrote: Hi! Attached patch is one of two patches necessary to fix ticket #1304. The MSDN documentation indicates that the palette is not part of the bitmapinfoheader but the bitmapinfoheader is part of the bitmapinfo structure that

Re: [FFmpeg-devel] [PATCH]Do not add extradata size to bitmapinfoheader size

2014-09-28 Thread Reimar Döffinger
On Sun, Sep 28, 2014 at 09:50:43AM +0200, Reimar Döffinger wrote: On Sat, Sep 27, 2014 at 10:51:25AM +0200, Carl Eugen Hoyos wrote: Hi! Attached patch is one of two patches necessary to fix ticket #1304. The MSDN documentation indicates that the palette is not part of the

Re: [FFmpeg-devel] [PATCH]Do not add extradata size to bitmapinfoheader size

2014-09-28 Thread Carl Eugen Hoyos
Reimar Döffinger Reimar.Doeffinger at gmx.de writes: On Sun, Sep 28, 2014 at 09:50:43AM +0200, Reimar Döffinger wrote: On Sat, Sep 27, 2014 at 10:51:25AM +0200, Carl Eugen Hoyos wrote: Hi! Attached patch is one of two patches necessary to fix ticket #1304. The MSDN documentation

Re: [FFmpeg-devel] [PATCH]Do not add extradata size to bitmapinfoheader size

2014-09-28 Thread Reimar Döffinger
On Sun, Sep 28, 2014 at 08:06:40AM +, Carl Eugen Hoyos wrote: biSize must be calculated so that it points to the palette, so if you have both extradata and palette you absolutely need to add the extradata size: This is wrong afaict. Or do we misunderstand each other?

[FFmpeg-devel] [PATCH]Do not add extradata size to bitmapinfoheader size

2014-09-27 Thread Carl Eugen Hoyos
Hi! Attached patch is one of two patches necessary to fix ticket #1304. The MSDN documentation indicates that the palette is not part of the bitmapinfoheader but the bitmapinfoheader is part of the bitmapinfo structure that also contains the palette. An alternative is to add the extradata_size

Re: [FFmpeg-devel] [PATCH]Do not add extradata size to bitmapinfoheader size

2014-09-27 Thread Michael Niedermayer
On Sat, Sep 27, 2014 at 10:51:25AM +0200, Carl Eugen Hoyos wrote: Hi! Attached patch is one of two patches necessary to fix ticket #1304. The MSDN documentation indicates that the palette is not part of the bitmapinfoheader but the bitmapinfoheader is part of the bitmapinfo structure that