Re: [FFmpeg-devel] [PATCH]lavc: Allow very high bitrates in AVCPBProperties after next version bump

2019-01-12 Thread Carl Eugen Hoyos
2019-01-11 1:07 GMT+01:00, James Almer : > On 1/10/2019 6:27 PM, Carl Eugen Hoyos wrote: >> Hi! >> >> I don't know how urgent this is and how easily this can be triggered >> with AVCPBProperties but we had issues with bitrates > INT32MAX in the >> past, so looking at this code before realizing the

Re: [FFmpeg-devel] [PATCH]lavc: Allow very high bitrates in AVCPBProperties after next version bump

2019-01-11 Thread Derek Buitenhuis
On 11/01/2019 00:07, James Almer wrote: > Probalby correct. bitrate fields in AVCodecContext are all int64_t, and > AVCPBProperties fields are usually set to those. Only semi-related: Is it useful to properly clip the bitrate to INT_MAX/INT_MIN where we set it currently (behind deprecation guards,

Re: [FFmpeg-devel] [PATCH]lavc: Allow very high bitrates in AVCPBProperties after next version bump

2019-01-10 Thread James Almer
On 1/10/2019 6:27 PM, Carl Eugen Hoyos wrote: > Hi! > > I don't know how urgent this is and how easily this can be triggered > with AVCPBProperties but we had issues with bitrates > INT32MAX in the > past, so looking at this code before realizing the qsv bitrate issue > is Intel-related I thought

[FFmpeg-devel] [PATCH]lavc: Allow very high bitrates in AVCPBProperties after next version bump

2019-01-10 Thread Carl Eugen Hoyos
Hi! I don't know how urgent this is and how easily this can be triggered with AVCPBProperties but we had issues with bitrates > INT32MAX in the past, so looking at this code before realizing the qsv bitrate issue is Intel-related I thought this patch cannot hurt. Please comment, Carl Eugen From 6