Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-12 Thread Rostislav Pehlivanov
On 12 May 2018 at 20:40, Paul B Mahol wrote: > On 5/12/18, Rostislav Pehlivanov wrote: > > On 1 May 2018 at 20:39, Paul B Mahol wrote: > > > >> Signed-off-by: Paul B Mahol > >> --- > >> libavcodec/avcodec.h | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/libavcodec/avcodec.h

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-12 Thread Paul B Mahol
On 5/12/18, Rostislav Pehlivanov wrote: > On 1 May 2018 at 20:39, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/avcodec.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h >> index fb0c6fae70..3a8f69243c 100644 >>

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-12 Thread Rostislav Pehlivanov
On 1 May 2018 at 20:39, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/avcodec.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index fb0c6fae70..3a8f69243c 100644 > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcod

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-02 Thread wm4
On Wed, 2 May 2018 17:49:05 +0100 Rostislav Pehlivanov wrote: > On 2 May 2018 at 17:39, wm4 wrote: > > > On Wed, 2 May 2018 13:44:48 +0200 > > Nicolas George wrote: > > > > > Vittorio Giovara (2018-05-01): > > > > Well no, let's step back a little. > > > > > > > > First of all there is no

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-02 Thread Rostislav Pehlivanov
On 2 May 2018 at 17:39, wm4 wrote: > On Wed, 2 May 2018 13:44:48 +0200 > Nicolas George wrote: > > > Vittorio Giovara (2018-05-01): > > > Well no, let's step back a little. > > > > > > First of all there is no stigma about adding fields to AVCodecContext, > > > in fact, the more, the merrier, ri

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-02 Thread wm4
On Wed, 2 May 2018 13:44:48 +0200 Nicolas George wrote: > Vittorio Giovara (2018-05-01): > > Well no, let's step back a little. > > > > First of all there is no stigma about adding fields to AVCodecContext, > > in fact, the more, the merrier, right? > > > > Secondly, there _is_ concern about ad

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-02 Thread Paul B Mahol
On 5/2/18, Nicolas George wrote: > Paul B Mahol (2018-05-02): >> Patches and actual proposals are better than agreeing of some written >> text that glorifies status quo. > > Depends on the quality of the patches. Depends on who sends patches and reviewer. _

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-02 Thread Nicolas George
Paul B Mahol (2018-05-02): > Patches and actual proposals are better than agreeing of some written > text that glorifies status quo. Depends on the quality of the patches. -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-de

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-02 Thread Paul B Mahol
On 5/2/18, Nicolas George wrote: > Vittorio Giovara (2018-05-01): >> Well no, let's step back a little. >> >> First of all there is no stigma about adding fields to AVCodecContext, >> in fact, the more, the merrier, right? >> >> Secondly, there _is_ concern about adding a field to AVCodec (not avc

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-02 Thread Nicolas George
Vittorio Giovara (2018-05-01): > Well no, let's step back a little. > > First of all there is no stigma about adding fields to AVCodecContext, > in fact, the more, the merrier, right? > > Secondly, there _is_ concern about adding a field to AVCodec (not avctx), > since is a delicate point of entr

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-01 Thread wm4
On Tue, 1 May 2018 16:46:37 -0400 Vittorio Giovara wrote: > -- > > On 5/1/2018 4:39 PM, Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > > --- > > libavcodec/avcodec.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > > index fb

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-01 Thread Vittorio Giovara
-- On Wed May 2 01:45:47 EEST 2018 Rostislav Pehlivanov wrote: > I agree with you, they need to be gone. The purpose of the patchset also > isn't just to get rid of them, its to have a good api to handle color > ranges and how it ought to be handled by filters and codecs. His only > objection was

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-01 Thread Rostislav Pehlivanov
On 1 May 2018 at 22:06, Paul B Mahol wrote: > On 5/1/18, Vittorio Giovara wrote: > > -- > > > > On 5/1/2018 4:39 PM, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol > >> --- > >> libavcodec/avcodec.h | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/libavcodec/avcodec.h b/

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-01 Thread Paul B Mahol
On 5/1/18, Vittorio Giovara wrote: > -- > > On 5/1/2018 4:39 PM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/avcodec.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h >> index fb0c6fae70..3a8f69243c 100644 >> ---

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-01 Thread Vittorio Giovara
-- On 5/1/2018 4:39 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/avcodec.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index fb0c6fae70..3a8f69243c 100644 > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcod

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-01 Thread Paul B Mahol
On 5/1/18, James Almer wrote: > On 5/1/2018 4:39 PM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/avcodec.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h >> index fb0c6fae70..3a8f69243c 100644 >> --- a/libavcode

Re: [FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-01 Thread James Almer
On 5/1/2018 4:39 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/avcodec.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index fb0c6fae70..3a8f69243c 100644 > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h

[FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2018-05-01 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/avcodec.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index fb0c6fae70..3a8f69243c 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -3433,6 +3433,7 @@ typedef struct AVCodec { uint8_

[FFmpeg-devel] [PATCH 01/24] avcodec: add color_range to AVCodec struct

2017-12-13 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/avcodec.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 5db6a81320..be00bad528 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -3376,6 +3376,7 @@ typedef struct AVCodec { uint8_