On Thu, Oct 09, 2014 at 12:02:26PM +, Nedeljko Babic wrote:
softfloat uses if (a.mant + 0x4000 0) to normalize
0x4000U + 0x4000U is 0 for int32 and thus not part of the
range though -1 would be, is that a problem ?
we could use a.mant + 0x4000 = 0 in that case
the
softfloat uses if (a.mant + 0x4000 0) to normalize
0x4000U + 0x4000U is 0 for int32 and thus not part of the
range though -1 would be, is that a problem ?
we could use a.mant + 0x4000 = 0 in that case
the main difference i see to aac is that it shifts up if its too small
while
On Thu, Oct 09, 2014 at 12:02:26PM +, Nedeljko Babic wrote:
softfloat uses if (a.mant + 0x4000 0) to normalize
0x4000U + 0x4000U is 0 for int32 and thus not part of the
range though -1 would be, is that a problem ?
we could use a.mant + 0x4000 = 0 in that case
the
Hi again,
but I do agree that it is more maintainable to have one float emulation and I
am willing to integrate our emulation in softfloat.
However, there is a difference in some conventions used (for example is it
more
important to represent exactly 0.5 or 1, order of fields in struct
Hi
On Mon, Oct 06, 2014 at 10:40:51AM +, Nedeljko Babic wrote:
Hi and sorry for such a late response.
It looks that I misplaced this mail...
From: Djordje Pesut djordje.pe...@imgtec.com
Add float emulation
Signed-off-by: Nedeljko Babic nedeljko.ba...@imgtec.com
---
On Mon, Sep 01, 2014 at 07:55:40PM +0200, Nedeljko Babic wrote:
From: Djordje Pesut djordje.pe...@imgtec.com
Add float emulation
Signed-off-by: Nedeljko Babic nedeljko.ba...@imgtec.com
---
libavcodec/float_emu.h | 295
+
+/* Rounding to zero used for simplicity */
+static av_always_inline aac_float_t float_add(aac_float_t a, aac_float_t b)
+{
+int diff;
+
+if (a.mant == 0)
+return b;
+
+if (b.mant == 0)
+return a;
+
+diff = a.expo - b.expo;
+
+if (diff 0) //
From: Djordje Pesut djordje.pe...@imgtec.com
Add float emulation
Signed-off-by: Nedeljko Babic nedeljko.ba...@imgtec.com
---
libavcodec/float_emu.h | 295 +
libavcodec/float_emu_tab.c | 293
2 files
On Mon, Sep 01, 2014 at 07:55:40PM +0200, Nedeljko Babic wrote:
+/* Rounding to zero used for simplicity */
+static av_always_inline aac_float_t float_add(aac_float_t a, aac_float_t b)
+{
+int diff;
+
+if (a.mant == 0)
+return b;
+
+if (b.mant == 0)
+return a;
...@gmx.de]
Poslato: 7. avgust 2014 22:12
Za: FFmpeg development discussions and patches
Tema: Re: [FFmpeg-devel] [PATCH 02/14] libavcodec: Implementation of
AAC_fixed_decoder (LC-module) [2/5]
On Thu, Aug 07, 2014 at 09:51:36AM +, Nedeljko Babic wrote:
+Q30(0.95), Q30(0.9922480620), Q30
Thanks on your review,
On Fri, Aug 01, 2014 at 03:53:08PM +0200, Nedeljko Babic wrote:
+#if !defined(_AAC_FLOAT_EMU_)
+#define _AAC_FLOAT_EMU_
That is not out usual style
1) We use #ifndef
2) Identifiers starting with _ + upper case letter are reserved by POSIX
and never should be used
3) The
On Thu, Aug 07, 2014 at 09:51:36AM +, Nedeljko Babic wrote:
+Q30(0.95), Q30(0.9922480620), Q30(0.9846153846),
Q30(0.9770992366),
I'm a bit unsure btw. if this makes more sense than coding the converted
numbers.
It feels like it combines the disadvantages, since it neither
From: Djordje Pesut djordje.pe...@imgtec.com
Add float emulation
Signed-off-by: Nedeljko Babic nedeljko.ba...@imgtec.com
---
libavcodec/aac_float_emu.h | 698 +
libavcodec/float_emu.h | 400 ++
libavcodec/float_emu_tab.c |
On Fri, Aug 01, 2014 at 03:53:08PM +0200, Nedeljko Babic wrote:
+#if !defined(_AAC_FLOAT_EMU_)
+#define _AAC_FLOAT_EMU_
That is not out usual style
1) We use #ifndef
2) Identifiers starting with _ + upper case letter are reserved by POSIX
and never should be used
3) The naming convention is
14 matches
Mail list logo
