Re: [FFmpeg-devel] [PATCH 08/25] fftools/ffplay: support only limited color range

2017-12-17 Thread Nicolas George
Marton Balint (2017-12-17): > If this works, that means color_ranges are ignored for RGB. We can do that, > but please document every color_range field explicitly that they only affect > YUV, nothing else. This is very ugly. I can accept that only if several persons who know about colorspaces and

Re: [FFmpeg-devel] [PATCH 08/25] fftools/ffplay: support only limited color range

2017-12-17 Thread Marton Balint
On Sat, 16 Dec 2017, Paul B Mahol wrote: On 12/16/17, Marton Balint wrote: On Sat, 16 Dec 2017, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- fftools/ffplay.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 08/25] fftools/ffplay: support only limited color range

2017-12-17 Thread wm4
On Sat, 16 Dec 2017 11:12:28 +0100 Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > fftools/ffplay.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/fftools/ffplay.c b/fftools/ffplay.c > index 10a917194d..f023c81575

Re: [FFmpeg-devel] [PATCH 08/25] fftools/ffplay: support only limited color range

2017-12-17 Thread Nicolas George
Paul B Mahol (2017-12-16): > Not really. This is just ffplay nuisance. Marton and I do not think so. Your patches, your burden of the proof. Rejected as is. -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 08/25] fftools/ffplay: support only limited color range

2017-12-16 Thread Paul B Mahol
On 12/16/17, Nicolas George wrote: > Marton Balint (2017-12-16): >> I am afraid this wont work, because ffplay supports full range RGB as >> well. >> Unless there is a way to specify allowed pixel format / color range >> combinations (which is the only way to mimic existing

Re: [FFmpeg-devel] [PATCH 08/25] fftools/ffplay: support only limited color range

2017-12-16 Thread Nicolas George
Marton Balint (2017-12-16): > I am afraid this wont work, because ffplay supports full range RGB as well. > Unless there is a way to specify allowed pixel format / color range > combinations (which is the only way to mimic existing behaviour as far as I > see), you have to use hacks like configure

Re: [FFmpeg-devel] [PATCH 08/25] fftools/ffplay: support only limited color range

2017-12-16 Thread Paul B Mahol
On 12/16/17, Marton Balint wrote: > > > On Sat, 16 Dec 2017, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol >> --- >> fftools/ffplay.c | 6 +- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/fftools/ffplay.c b/fftools/ffplay.c >>

Re: [FFmpeg-devel] [PATCH 08/25] fftools/ffplay: support only limited color range

2017-12-16 Thread Marton Balint
On Sat, 16 Dec 2017, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- fftools/ffplay.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 10a917194d..f023c81575 100644 --- a/fftools/ffplay.c +++

[FFmpeg-devel] [PATCH 08/25] fftools/ffplay: support only limited color range

2017-12-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- fftools/ffplay.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 10a917194d..f023c81575 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -1822,6 +1822,7 @@ fail: static