Re: [FFmpeg-devel] [PATCH 1/2] lavfi: check links properties after configuring them.

2017-11-02 Thread Nicolas George
Le primidi 11 brumaire, an CCXXVI, Clement Boesch a écrit : > My bad, you're right, I was looking at the wrong header with the same > variable names. Dismiss my comment. Ok, series pushed. > I'd say that a counter is unlikely to require a sign vs unsigned > optimization (and if it does and we kno

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: check links properties after configuring them.

2017-11-01 Thread Clément Bœsch
On Wed, Nov 01, 2017 at 11:01:22PM +0100, Nicolas George wrote: > Le primidi 11 brumaire, an CCXXVI, Clement Boesch a écrit : > > nb_filters and nb_outputs are signed so the counters better be the same > > type. > > I re-checked, I think you are mistaken. > My bad, you're right, I was looking at

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: check links properties after configuring them.

2017-11-01 Thread Nicolas George
Le primidi 11 brumaire, an CCXXVI, Clement Boesch a écrit : > nb_filters and nb_outputs are signed so the counters better be the same > type. I re-checked, I think you are mistaken. > I think we already had that discussion but I'd rather have the counters > signed so the compiler can exploit the

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: check links properties after configuring them.

2017-11-01 Thread Clément Bœsch
On Wed, Nov 01, 2017 at 09:39:52PM +0100, Nicolas George wrote: > For now, check the image size. > Inspired by a patch from Paul B Mahol. > > Invalid sizes would be detected later by allocation failures, > detecting problems earlier is cleaner. > > Signed-off-by: Nicolas George > --- > libavfil

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: check links properties after configuring them.

2017-11-01 Thread Paul B Mahol
On 11/1/17, Nicolas George wrote: > For now, check the image size. > Inspired by a patch from Paul B Mahol. > > Invalid sizes would be detected later by allocation failures, > detecting problems earlier is cleaner. > > Signed-off-by: Nicolas George > --- > libavfilter/avfiltergraph.c | 24 ++

[FFmpeg-devel] [PATCH 1/2] lavfi: check links properties after configuring them.

2017-11-01 Thread Nicolas George
For now, check the image size. Inspired by a patch from Paul B Mahol. Invalid sizes would be detected later by allocation failures, detecting problems earlier is cleaner. Signed-off-by: Nicolas George --- libavfilter/avfiltergraph.c | 24 1 file changed, 24 insertions(+