Re: [FFmpeg-devel] [PATCH 1/2] lavu: add a gamma field to AVMasteringDisplayMetadata

2017-09-20 Thread wm4
On Wed, 20 Sep 2017 15:28:26 -0300 James Almer wrote: > On 9/20/2017 3:18 PM, wm4 wrote: > > On Wed, 20 Sep 2017 04:00:27 +0100 > > Rostislav Pehlivanov wrote: > > > >> PNG exposes it and its required in order to correctly display some images, > >> particularly images crafted to contain 2 dif

Re: [FFmpeg-devel] [PATCH 1/2] lavu: add a gamma field to AVMasteringDisplayMetadata

2017-09-20 Thread James Almer
On 9/20/2017 3:18 PM, wm4 wrote: > On Wed, 20 Sep 2017 04:00:27 +0100 > Rostislav Pehlivanov wrote: > >> PNG exposes it and its required in order to correctly display some images, >> particularly images crafted to contain 2 different images which appear >> differently depending on whether the gam

Re: [FFmpeg-devel] [PATCH 1/2] lavu: add a gamma field to AVMasteringDisplayMetadata

2017-09-20 Thread wm4
On Wed, 20 Sep 2017 12:58:14 -0300 James Almer wrote: > On 9/20/2017 12:47 PM, Rostislav Pehlivanov wrote: > > On 20 September 2017 at 16:05, Hendrik Leppkes wrote: > > > >> On Wed, Sep 20, 2017 at 4:34 PM, Rostislav Pehlivanov > >> wrote: > >>> On 20 September 2017 at 12:55, Vittorio Giov

Re: [FFmpeg-devel] [PATCH 1/2] lavu: add a gamma field to AVMasteringDisplayMetadata

2017-09-20 Thread wm4
On Wed, 20 Sep 2017 04:00:27 +0100 Rostislav Pehlivanov wrote: > PNG exposes it and its required in order to correctly display some images, > particularly images crafted to contain 2 different images which appear > differently depending on whether the gamma has been taken into account. > > Signe

Re: [FFmpeg-devel] [PATCH 1/2] lavu: add a gamma field to AVMasteringDisplayMetadata

2017-09-20 Thread Hendrik Leppkes
On Wed, Sep 20, 2017 at 5:47 PM, Rostislav Pehlivanov wrote: > On 20 September 2017 at 16:05, Hendrik Leppkes wrote: > >> On Wed, Sep 20, 2017 at 4:34 PM, Rostislav Pehlivanov >> wrote: >> > On 20 September 2017 at 12:55, Vittorio Giovara < >> vittorio.giov...@gmail.com> >> > wrote: >> > >> >> d

Re: [FFmpeg-devel] [PATCH 1/2] lavu: add a gamma field to AVMasteringDisplayMetadata

2017-09-20 Thread James Almer
On 9/20/2017 12:58 PM, Vittorio Giovara wrote: >> * In my opinion we should not add new fields to structures that map 1:1 to > *>* something defined elsewhere (with the exception of booleans). > *>* I think this should be a separate side data and type, ie AVGammaResponse, > *>* that can of course r

Re: [FFmpeg-devel] [PATCH 1/2] lavu: add a gamma field to AVMasteringDisplayMetadata

2017-09-20 Thread Vittorio Giovara
>* In my opinion we should not add new fields to structures that map 1:1 to *>* something defined elsewhere (with the exception of booleans). *>* I think this should be a separate side data and type, ie AVGammaResponse, *>* that can of course reside in the same header. *>* -- *>* Vittorio *>* _

Re: [FFmpeg-devel] [PATCH 1/2] lavu: add a gamma field to AVMasteringDisplayMetadata

2017-09-20 Thread James Almer
On 9/20/2017 12:05 PM, Hendrik Leppkes wrote: > On Wed, Sep 20, 2017 at 4:34 PM, Rostislav Pehlivanov > wrote: >> On 20 September 2017 at 12:55, Vittorio Giovara >> wrote: >> >>> diff --git a/libavutil/mastering_display_metadata.h >>> b/libavutil/mastering_display_metadata.h >>> index 847b0b62c6.

Re: [FFmpeg-devel] [PATCH 1/2] lavu: add a gamma field to AVMasteringDisplayMetadata

2017-09-20 Thread James Almer
On 9/20/2017 12:47 PM, Rostislav Pehlivanov wrote: > On 20 September 2017 at 16:05, Hendrik Leppkes wrote: > >> On Wed, Sep 20, 2017 at 4:34 PM, Rostislav Pehlivanov >> wrote: >>> On 20 September 2017 at 12:55, Vittorio Giovara < >> vittorio.giov...@gmail.com> >>> wrote: >>> diff --git a/li

Re: [FFmpeg-devel] [PATCH 1/2] lavu: add a gamma field to AVMasteringDisplayMetadata

2017-09-20 Thread Rostislav Pehlivanov
On 20 September 2017 at 16:05, Hendrik Leppkes wrote: > On Wed, Sep 20, 2017 at 4:34 PM, Rostislav Pehlivanov > wrote: > > On 20 September 2017 at 12:55, Vittorio Giovara < > vittorio.giov...@gmail.com> > > wrote: > > > >> diff --git a/libavutil/mastering_display_metadata.h > >> b/libavutil/mast

Re: [FFmpeg-devel] [PATCH 1/2] lavu: add a gamma field to AVMasteringDisplayMetadata

2017-09-20 Thread Hendrik Leppkes
On Wed, Sep 20, 2017 at 4:34 PM, Rostislav Pehlivanov wrote: > On 20 September 2017 at 12:55, Vittorio Giovara > wrote: > >> diff --git a/libavutil/mastering_display_metadata.h >> b/libavutil/mastering_display_metadata.h >> index 847b0b62c6..3de58bf468 100644 >> --- a/libavutil/mastering_display_

Re: [FFmpeg-devel] [PATCH 1/2] lavu: add a gamma field to AVMasteringDisplayMetadata

2017-09-20 Thread Rostislav Pehlivanov
On 20 September 2017 at 12:55, Vittorio Giovara wrote: > diff --git a/libavutil/mastering_display_metadata.h > b/libavutil/mastering_display_metadata.h > index 847b0b62c6..3de58bf468 100644 > --- a/libavutil/mastering_display_metadata.h > +++ b/libavutil/mastering_display_metadata.h > @@ -66,6 +6

Re: [FFmpeg-devel] [PATCH 1/2] lavu: add a gamma field to AVMasteringDisplayMetadata

2017-09-20 Thread Vittorio Giovara
diff --git a/libavutil/mastering_display_metadata.h b/libavutil/mastering_display_metadata.h index 847b0b62c6..3de58bf468 100644 --- a/libavutil/mastering_display_metadata.h +++ b/libavutil/mastering_display_metadata.h @@ -66,6 +66,16 @@ typedef struct AVMasteringDisplayMetadata { */ int

[FFmpeg-devel] [PATCH 1/2] lavu: add a gamma field to AVMasteringDisplayMetadata

2017-09-19 Thread Rostislav Pehlivanov
PNG exposes it and its required in order to correctly display some images, particularly images crafted to contain 2 different images which appear differently depending on whether the gamma has been taken into account. Signed-off-by: Rostislav Pehlivanov --- libavutil/mastering_display_metadata.h