Re: [FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-14 Thread Will Kelleher
On 12/14, Nicolas George wrote: > Le quartidi 24 frimaire, an CCXXIV, Hendrik Leppkes a écrit : > > It can be both, ffmpeg also has a mode to forward the source types, if > > the user really wants that. But its of course not on by default. > > Ok. Then I suggest to fix the commit message: the scen

Re: [FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-14 Thread Will Kelleher
On 12/14, Ivan Uskov wrote: > Hello Will, > > Friday, December 11, 2015, 6:47:28 PM, you wrote: > > WK> Since adaptive_i support is broken, this allows the QSV encoder to use > scene- > WK> change hints from the input stream if force_key_frames = source is used. > The > WK> result will be impr

Re: [FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-14 Thread Nicolas George
Le quartidi 24 frimaire, an CCXXIV, Hendrik Leppkes a écrit : > It can be both, ffmpeg also has a mode to forward the source types, if > the user really wants that. But its of course not on by default. Ok. Then I suggest to fix the commit message: the scene-change hints come from the application.

Re: [FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-14 Thread Hendrik Leppkes
On Mon, Dec 14, 2015 at 9:46 AM, Nicolas George wrote: > Le quartidi 24 frimaire, an CCXXIV, Hendrik Leppkes a écrit : >> Strictly speaking, by default the input frames will not have pict_type >> set, unless you explicitly instruct ffmpeg to set it. So it is >> optional. > > Are you sure these "hi

Re: [FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-14 Thread Nicolas George
Le quartidi 24 frimaire, an CCXXIV, Hendrik Leppkes a écrit : > Strictly speaking, by default the input frames will not have pict_type > set, unless you explicitly instruct ffmpeg to set it. So it is > optional. Are you sure these "hints" come from the source? Reading the patch, it seems to make t

Re: [FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-14 Thread Hendrik Leppkes
On Mon, Dec 14, 2015 at 9:02 AM, Ivan Uskov wrote: > Hello Will, > > Friday, December 11, 2015, 6:47:28 PM, you wrote: > > WK> Since adaptive_i support is broken, this allows the QSV encoder to use > scene- > WK> change hints from the input stream if force_key_frames = source is used. > The > W

Re: [FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-14 Thread Ivan Uskov
Hello Will, Friday, December 11, 2015, 6:47:28 PM, you wrote: WK> Since adaptive_i support is broken, this allows the QSV encoder to use scene- WK> change hints from the input stream if force_key_frames = source is used. The WK> result will be improved transcoding quality at scene change bound

[FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-11 Thread Will Kelleher
Since adaptive_i support is broken, this allows the QSV encoder to use scene- change hints from the input stream if force_key_frames = source is used. The result will be improved transcoding quality at scene change boundaries. Signed-off-by: Will Kelleher --- libavcodec/qsvenc.c | 11 ++