Re: [FFmpeg-devel] [PATCH 1/2] vf_paletteuse: Add error checking to apply_palette

2018-01-02 Thread Derek Buitenhuis
On 1/2/2018 10:16 PM, Clément Bœsch wrote: > I don't think you'll be much off by always assuming ENOMEM here when > getting a NULL out frame, I think that's the common idiom when a function > supposed to return allocated stuff returns NULL. > > But that's not very important, feel free to push as

Re: [FFmpeg-devel] [PATCH 1/2] vf_paletteuse: Add error checking to apply_palette

2018-01-02 Thread Clément Bœsch
On Tue, Jan 02, 2018 at 10:02:25PM +, Derek Buitenhuis wrote: > On 1/2/2018 9:52 PM, Clément Bœsch wrote: > > not exactly sure why you haven't just checked if `out` wasn't NULL, but it > > should be fine that way too if you prefer it. > > > > I guess that's only to provide a finer grain error

Re: [FFmpeg-devel] [PATCH 1/2] vf_paletteuse: Add error checking to apply_palette

2018-01-02 Thread Derek Buitenhuis
On 1/2/2018 9:52 PM, Clément Bœsch wrote: > not exactly sure why you haven't just checked if `out` wasn't NULL, but it > should be fine that way too if you prefer it. > > I guess that's only to provide a finer grain error handling? It would make > sense if ff_get_video_buffer was returning a

Re: [FFmpeg-devel] [PATCH 1/2] vf_paletteuse: Add error checking to apply_palette

2018-01-02 Thread Clément Bœsch
On Mon, Jan 01, 2018 at 11:28:36AM -0500, Derek Buitenhuis wrote: > This fixes a segfault caused by passing NULL to ff_filter_frame > when an error occurs. > > Signed-off-by: Derek Buitenhuis > --- > libavfilter/vf_paletteuse.c | 25 - > 1

[FFmpeg-devel] [PATCH 1/2] vf_paletteuse: Add error checking to apply_palette

2018-01-01 Thread Derek Buitenhuis
This fixes a segfault caused by passing NULL to ff_filter_frame when an error occurs. Signed-off-by: Derek Buitenhuis --- libavfilter/vf_paletteuse.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git