Re: [FFmpeg-devel] [PATCH 1/4] lavfi: add filter messages infrastructure.

2014-07-30 Thread Nicolas George
Le duodi 12 thermidor, an CCXXII, Michael Niedermayer a écrit : > heres some valgrind output: Thanks for the precisions. I was unable to reproduce any of it, despite running FATE through valgrind. Either the bug went away when I changed the allocation of the frame or there is something very strang

Re: [FFmpeg-devel] [PATCH 1/4] lavfi: add filter messages infrastructure.

2014-07-30 Thread Michael Niedermayer
On Wed, Jul 30, 2014 at 05:14:07PM +0200, Michael Niedermayer wrote: > On Wed, Jul 30, 2014 at 03:52:34PM +0200, Nicolas George wrote: > > Le sextidi 6 thermidor, an CCXXII, Nicolas George a écrit : > > > Le sextidi 6 thermidor, an CCXXII, Michael Niedermayer a écrit : > > > > the 4 patch set seems

Re: [FFmpeg-devel] [PATCH 1/4] lavfi: add filter messages infrastructure.

2014-07-30 Thread Michael Niedermayer
On Wed, Jul 30, 2014 at 03:52:34PM +0200, Nicolas George wrote: > Le sextidi 6 thermidor, an CCXXII, Nicolas George a écrit : > > Le sextidi 6 thermidor, an CCXXII, Michael Niedermayer a écrit : > > > the 4 patch set seems to break fate > > > TESTswr-resample-s16p-48000-2626 > > > stddev:3.

Re: [FFmpeg-devel] [PATCH 1/4] lavfi: add filter messages infrastructure.

2014-07-30 Thread Nicolas George
Le sextidi 6 thermidor, an CCXXII, Nicolas George a écrit : > Le sextidi 6 thermidor, an CCXXII, Michael Niedermayer a écrit : > > the 4 patch set seems to break fate > > TESTswr-resample-s16p-48000-2626 > > stddev:3.88 PSNR: 84.54 MAXDIFF: 15 bytes:96000/20416 > > Test swr-resamp

Re: [FFmpeg-devel] [PATCH 1/4] lavfi: add filter messages infrastructure.

2014-07-29 Thread Clément Bœsch
On Tue, Jul 29, 2014 at 05:14:22PM +0200, Nicolas George wrote: > Le primidi 11 thermidor, an CCXXII, Clément Bœsch a écrit : > > What other kind of messages do you have in mind? > > I had thought about something to handle timestamps discontinuities / lost > frames, but not very deeply. > > > "me

Re: [FFmpeg-devel] [PATCH 1/4] lavfi: add filter messages infrastructure.

2014-07-29 Thread Nicolas George
Le primidi 11 thermidor, an CCXXII, Clément Bœsch a écrit : > What other kind of messages do you have in mind? I had thought about something to handle timestamps discontinuities / lost frames, but not very deeply. > "messages" sounds very user specific though. Like, it makes almost believe > that

Re: [FFmpeg-devel] [PATCH 1/4] lavfi: add filter messages infrastructure.

2014-07-29 Thread Clément Bœsch
On Thu, Jul 24, 2014 at 03:39:42PM +0200, Nicolas George wrote: > Messaages are passed as frames with a negative format code, Messages* > only to filter that declare supporting them. > The only message for now is EOF; this mechanism augments > the current mechanism based on request_frame() return

Re: [FFmpeg-devel] [PATCH 1/4] lavfi: add filter messages infrastructure.

2014-07-28 Thread Michael Niedermayer
On Tue, Jul 29, 2014 at 01:29:16AM +0200, Nicolas George wrote: > Le decadi 10 thermidor, an CCXXII, Michael Niedermayer a écrit : > > Breaks ABI, AVFrame size is depending on libavutil and may be non > > constant for a libavfilter build > > That was intentional (that makes the code simpler with l

Re: [FFmpeg-devel] [PATCH 1/4] lavfi: add filter messages infrastructure.

2014-07-28 Thread Nicolas George
Le decadi 10 thermidor, an CCXXII, Michael Niedermayer a écrit : > Breaks ABI, AVFrame size is depending on libavutil and may be non > constant for a libavfilter build That was intentional (that makes the code simpler with less error checks): the frame is only allocated and used internally, so thi

Re: [FFmpeg-devel] [PATCH 1/4] lavfi: add filter messages infrastructure.

2014-07-28 Thread Michael Niedermayer
On Thu, Jul 24, 2014 at 03:39:42PM +0200, Nicolas George wrote: [...] > @@ -1162,6 +1205,17 @@ int ff_filter_frame(AVFilterLink *link, AVFrame *frame) > } > } > > +int ff_filter_link_close(AVFilterLink *link, int64_t pts) > +{ > +AVFrame frame = { }; Breaks ABI, AVFrame size is depend

Re: [FFmpeg-devel] [PATCH 1/4] lavfi: add filter messages infrastructure.

2014-07-24 Thread Nicolas George
Le sextidi 6 thermidor, an CCXXII, Michael Niedermayer a écrit : > the 4 patch set seems to break fate > TESTswr-resample-s16p-48000-2626 > stddev:3.88 PSNR: 84.54 MAXDIFF: 15 bytes:96000/20416 > Test swr-resample-s16p-8000-44100 failed. Look at > tests/data/fate/swr-resample-s16

Re: [FFmpeg-devel] [PATCH 1/4] lavfi: add filter messages infrastructure.

2014-07-24 Thread Michael Niedermayer
On Thu, Jul 24, 2014 at 03:39:42PM +0200, Nicolas George wrote: > Messaages are passed as frames with a negative format code, > only to filter that declare supporting them. > The only message for now is EOF; this mechanism augments > the current mechanism based on request_frame() returning > AVERRO

[FFmpeg-devel] [PATCH 1/4] lavfi: add filter messages infrastructure.

2014-07-24 Thread Nicolas George
Messaages are passed as frames with a negative format code, only to filter that declare supporting them. The only message for now is EOF; this mechanism augments the current mechanism based on request_frame() returning AVERROR_EOF, with the advantage that the EOF message carries a timestamp. The me