Re: [FFmpeg-devel] [PATCH 1/5] avcodec/cbs: add helper functions and macros to read and write signed values

2019-04-16 Thread James Almer
On 4/16/2019 8:27 PM, Mark Thompson wrote: > On 16/04/2019 23:54, James Almer wrote: >> On 4/16/2019 7:45 PM, Mark Thompson wrote: >>> On 15/04/2019 22:17, James Almer wrote: Signed-off-by: James Almer --- libavcodec/cbs.c | 79 +++

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/cbs: add helper functions and macros to read and write signed values

2019-04-16 Thread Mark Thompson
On 16/04/2019 23:54, James Almer wrote: > On 4/16/2019 7:45 PM, Mark Thompson wrote: >> On 15/04/2019 22:17, James Almer wrote: >>> Signed-off-by: James Almer >>> --- >>> libavcodec/cbs.c | 79 +++ >>> libavcodec/cbs_internal.h | 20 +- >>> 2

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/cbs: add helper functions and macros to read and write signed values

2019-04-16 Thread James Almer
On 4/16/2019 7:45 PM, Mark Thompson wrote: > On 15/04/2019 22:17, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/cbs.c | 79 +++ >> libavcodec/cbs_internal.h | 20 +- >> 2 files changed, 98 insertions(+), 1 deletion(-) >

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/cbs: add helper functions and macros to read and write signed values

2019-04-16 Thread Mark Thompson
On 15/04/2019 22:17, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/cbs.c | 79 +++ > libavcodec/cbs_internal.h | 20 +- > 2 files changed, 98 insertions(+), 1 deletion(-) Looks like a sensible addition, some comments

[FFmpeg-devel] [PATCH 1/5] avcodec/cbs: add helper functions and macros to read and write signed values

2019-04-15 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs.c | 79 +++ libavcodec/cbs_internal.h | 20 +- 2 files changed, 98 insertions(+), 1 deletion(-) diff --git a/libavcodec/cbs.c b/libavcodec/cbs.c index c388be896b..726bd582f5 100644 ---