[FFmpeg-devel] [PATCH 10/15] avformat/matroskaenc: Avoid seeking when writing level 1 elements

2019-04-19 Thread Andreas Rheinhardt
Up until now, the writing process for level 1 elements (those elements for which CRC-32 elements are written by default) was this in case the output was seekable: Write the EBML ID, write an "unkown length" EBML number of the desired length, then write the element into a dynamic buffer, then write

Re: [FFmpeg-devel] [PATCH 10/15] avformat/matroskaenc: Avoid seeking when writing level 1 elements

2019-04-02 Thread Andreas Rheinhardt via ffmpeg-devel
Hendrik Leppkes: > On Tue, Apr 2, 2019 at 5:55 PM Andreas Rheinhardt via ffmpeg-devel > wrote: >> >> Hello, >> >> thanks for taking a look at this. >> >> Hendrik Leppkes: >>> On Tue, Apr 2, 2019 at 3:36 PM Andreas Rheinhardt via ffmpeg-devel >>> wrote: Up until now, the writing process

Re: [FFmpeg-devel] [PATCH 10/15] avformat/matroskaenc: Avoid seeking when writing level 1 elements

2019-04-02 Thread James Almer
On 4/2/2019 1:23 PM, Hendrik Leppkes wrote: > On Tue, Apr 2, 2019 at 5:55 PM Andreas Rheinhardt via ffmpeg-devel > wrote: >> >> Hello, >> >> thanks for taking a look at this. >> >> Hendrik Leppkes: >>> On Tue, Apr 2, 2019 at 3:36 PM Andreas Rheinhardt via ffmpeg-devel >>> wrote: Up unti

Re: [FFmpeg-devel] [PATCH 10/15] avformat/matroskaenc: Avoid seeking when writing level 1 elements

2019-04-02 Thread Andreas Rheinhardt via ffmpeg-devel
Hendrik Leppkes: > On Tue, Apr 2, 2019 at 3:36 PM Andreas Rheinhardt via ffmpeg-devel > wrote: >> @@ -383,8 +388,8 @@ static void >> end_ebml_master_crc32_preliminary(AVIOContext *pb, AVIOContext **dyn >> uint8_t *buf; >> int size = avio_get_dyn_buf(*dyn_cp, &buf); >> >> +pu

Re: [FFmpeg-devel] [PATCH 10/15] avformat/matroskaenc: Avoid seeking when writing level 1 elements

2019-04-02 Thread Hendrik Leppkes
On Tue, Apr 2, 2019 at 3:36 PM Andreas Rheinhardt via ffmpeg-devel wrote: > @@ -383,8 +388,8 @@ static void end_ebml_master_crc32_preliminary(AVIOContext > *pb, AVIOContext **dyn > uint8_t *buf; > int size = avio_get_dyn_buf(*dyn_cp, &buf); > > +put_ebml_num(pb, size, master

Re: [FFmpeg-devel] [PATCH 10/15] avformat/matroskaenc: Avoid seeking when writing level 1 elements

2019-04-02 Thread Hendrik Leppkes
On Tue, Apr 2, 2019 at 5:55 PM Andreas Rheinhardt via ffmpeg-devel wrote: > > Hello, > > thanks for taking a look at this. > > Hendrik Leppkes: > > On Tue, Apr 2, 2019 at 3:36 PM Andreas Rheinhardt via ffmpeg-devel > > wrote: > >> > >> Up until now, the writing process for level 1 elements (those

Re: [FFmpeg-devel] [PATCH 10/15] avformat/matroskaenc: Avoid seeking when writing level 1 elements

2019-04-02 Thread Andreas Rheinhardt via ffmpeg-devel
Hello, thanks for taking a look at this. Hendrik Leppkes: > On Tue, Apr 2, 2019 at 3:36 PM Andreas Rheinhardt via ffmpeg-devel > wrote: >> >> Up until now, the writing process for level 1 elements (those elements >> for which CRC-32 elements are written by default) was this in case the >> output

Re: [FFmpeg-devel] [PATCH 10/15] avformat/matroskaenc: Avoid seeking when writing level 1 elements

2019-04-02 Thread Hendrik Leppkes
On Tue, Apr 2, 2019 at 3:36 PM Andreas Rheinhardt via ffmpeg-devel wrote: > > Up until now, the writing process for level 1 elements (those elements > for which CRC-32 elements are written by default) was this in case the > output was seekable: Write the EBML ID, write an "unkown length" EBML > nu

[FFmpeg-devel] [PATCH 10/15] avformat/matroskaenc: Avoid seeking when writing level 1 elements

2019-04-02 Thread Andreas Rheinhardt via ffmpeg-devel
Up until now, the writing process for level 1 elements (those elements for which CRC-32 elements are written by default) was this in case the output was seekable: Write the EBML ID, write an "unkown length" EBML number of the desired length, then write the element into a dynamic buffer, then write