Re: [FFmpeg-devel] [PATCH 10/18] cbs: Remove superfluous checks for ff_cbs_delete_unit

2019-06-17 Thread Andreas Rheinhardt
James Almer: > On 6/17/2019 12:42 AM, Andreas Rheinhardt wrote: >> ff_cbs_delete_unit never fails if the index of the unit to delete is >> valid; document this behaviour explicitly and remove the checks for >> whether ff_cbs_delete_unit failed, because all the callers of >> ff_cbs_delete_unit

Re: [FFmpeg-devel] [PATCH 10/18] cbs: Remove superfluous checks for ff_cbs_delete_unit

2019-06-17 Thread James Almer
On 6/17/2019 12:42 AM, Andreas Rheinhardt wrote: > ff_cbs_delete_unit never fails if the index of the unit to delete is > valid; document this behaviour explicitly and remove the checks for > whether ff_cbs_delete_unit failed, because all the callers of > ff_cbs_delete_unit already make sure that

[FFmpeg-devel] [PATCH 10/18] cbs: Remove superfluous checks for ff_cbs_delete_unit

2019-06-16 Thread Andreas Rheinhardt
ff_cbs_delete_unit never fails if the index of the unit to delete is valid; document this behaviour explicitly and remove the checks for whether ff_cbs_delete_unit failed, because all the callers of ff_cbs_delete_unit already make sure that the index is valid. Signed-off-by: Andreas Rheinhardt