Re: [FFmpeg-devel] [PATCH 12/37] avformat/matroskadec: Improve read error/EOF checks II

2019-06-23 Thread James Almer
On 6/23/2019 1:01 PM, Andreas Rheinhardt wrote: > James Almer: >> On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: >>> This commit fixes a number of bugs: >>> >>> 1. There was no check that no read error/EOF occured during >>> ebml_read_uint, ebml_read_sint and ebml_read_float. >>> 2. ebml_read_asci

Re: [FFmpeg-devel] [PATCH 12/37] avformat/matroskadec: Improve read error/EOF checks II

2019-06-23 Thread Andreas Rheinhardt
James Almer: > On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: >> This commit fixes a number of bugs: >> >> 1. There was no check that no read error/EOF occured during >> ebml_read_uint, ebml_read_sint and ebml_read_float. >> 2. ebml_read_ascii and ebml_read_binary did sometimes not forward >> erro

Re: [FFmpeg-devel] [PATCH 12/37] avformat/matroskadec: Improve read error/EOF checks II

2019-06-23 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > This commit fixes a number of bugs: > > 1. There was no check that no read error/EOF occured during > ebml_read_uint, ebml_read_sint and ebml_read_float. > 2. ebml_read_ascii and ebml_read_binary did sometimes not forward > error codes; instead the

[FFmpeg-devel] [PATCH 12/37] avformat/matroskadec: Improve read error/EOF checks II

2019-05-16 Thread Andreas Rheinhardt
This commit fixes a number of bugs: 1. There was no check that no read error/EOF occured during ebml_read_uint, ebml_read_sint and ebml_read_float. 2. ebml_read_ascii and ebml_read_binary did sometimes not forward error codes; instead they simply returned AVERROR(EIO). 3. In particular, AVERROR_EO