Re: [FFmpeg-devel] [PATCH 2/2] avcodec/snowenc: Replace "return -1" by named constants

2017-09-24 Thread Carl Eugen Hoyos
2017-09-25 1:16 GMT+02:00 James Almer : > On 9/24/2017 8:06 PM, Carl Eugen Hoyos wrote: >> 2017-09-23 3:14 GMT+02:00 James Almer : >>> On 9/22/2017 10:01 PM, Michael Niedermayer wrote: >> +if((ret = ff_rate_control_init(>m)) < 0) +

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/snowenc: Replace "return -1" by named constants

2017-09-24 Thread James Almer
On 9/24/2017 8:06 PM, Carl Eugen Hoyos wrote: > 2017-09-23 3:14 GMT+02:00 James Almer : >> On 9/22/2017 10:01 PM, Michael Niedermayer wrote: > >>> +if((ret = ff_rate_control_init(>m)) < 0) >>> +return ret; >> >> ret = foo(); >> if (ret < 0) >> return

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/snowenc: Replace "return -1" by named constants

2017-09-24 Thread Carl Eugen Hoyos
2017-09-23 3:14 GMT+02:00 James Almer : > On 9/22/2017 10:01 PM, Michael Niedermayer wrote: >> +if((ret = ff_rate_control_init(>m)) < 0) >> +return ret; > > ret = foo(); > if (ret < 0) > return ret; > > No more combined assignment and comparisons for >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/snowenc: Replace "return -1" by named constants

2017-09-23 Thread Michael Niedermayer
On Fri, Sep 22, 2017 at 10:14:01PM -0300, James Almer wrote: > On 9/22/2017 10:01 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/snowenc.c | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/snowenc: Replace "return -1" by named constants

2017-09-22 Thread James Almer
On 9/22/2017 10:01 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/snowenc.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/snowenc.c b/libavcodec/snowenc.c > index

[FFmpeg-devel] [PATCH 2/2] avcodec/snowenc: Replace "return -1" by named constants

2017-09-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/snowenc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/snowenc.c b/libavcodec/snowenc.c index bb113d0a2b..f5497f958c 100644 --- a/libavcodec/snowenc.c +++ b/libavcodec/snowenc.c