Re: [FFmpeg-devel] [PATCH 2/2] avformat/matroskaenc: write a DisplayUnit element when aspect ratio is unknown

2016-10-15 Thread Dave Rice
> On Oct 15, 2016, at 7:54 PM, Kieran O Leary wrote: > > Hi, > > On Sat, Oct 15, 2016 at 11:09 PM, James Almer wrote: > >> >> -#sar 0: 1/1 >> +#sar 0: 0/1 >> > > This commit looks very useful. A few archivists (including myself) > encountered this issue, so this is a wonderful contribution

Re: [FFmpeg-devel] [PATCH 2/2] avformat/matroskaenc: write a DisplayUnit element when aspect ratio is unknown

2016-10-15 Thread Kieran O Leary
Hi, On Sat, Oct 15, 2016 at 11:09 PM, James Almer wrote: > > -#sar 0: 1/1 > +#sar 0: 0/1 > This commit looks very useful. A few archivists (including myself) encountered this issue, so this is a wonderful contribution! Thanks James! -Kieran. ___ ffmp

[FFmpeg-devel] [PATCH 2/2] avformat/matroskaenc: write a DisplayUnit element when aspect ratio is unknown

2016-10-15 Thread James Almer
We don't currently support values 1 (centimeters), 2 (inches) or 3 (DAR), only the default value 0 (pixels) which doesn't need to be written. The fate refs are updated as unknown SAR is now correctly propagated by the matroska demuxer. Signed-off-by: James Almer --- See the relevant discussion i