Re: [FFmpeg-devel] [PATCH 2/2] avio: do not export avpriv_io_{move, delete}

2021-05-22 Thread Anton Khirnov
Quoting Anton Khirnov (2020-01-13 11:33:01) > Quoting Hendrik Leppkes (2020-01-10 23:40:37) > > On Fri, Jan 10, 2020 at 7:31 PM James Almer wrote: > > > Yes, i agree with this if we were talking about clearly marked > > > non-public structs, fields and defines. In those cases, people using > > >

Re: [FFmpeg-devel] [PATCH 2/2] avio: do not export avpriv_io_{move, delete}

2020-01-13 Thread Anton Khirnov
Quoting Hendrik Leppkes (2020-01-10 23:40:37) > On Fri, Jan 10, 2020 at 7:31 PM James Almer wrote: > > Yes, i agree with this if we were talking about clearly marked > > non-public structs, fields and defines. In those cases, people using > > them should be aware of the consequences. But these

Re: [FFmpeg-devel] [PATCH 2/2] avio: do not export avpriv_io_{move, delete}

2020-01-10 Thread Hendrik Leppkes
On Fri, Jan 10, 2020 at 7:31 PM James Almer wrote: > > On 1/10/2020 11:30 AM, Anton Khirnov wrote: > > Quoting James Almer (2020-01-10 14:33:06) > >> On 1/10/2020 8:21 AM, Anton Khirnov wrote: > >>> They are private and not used by anything outside of lavf. There is no > >>> reason for them to be

Re: [FFmpeg-devel] [PATCH 2/2] avio: do not export avpriv_io_{move, delete}

2020-01-10 Thread James Almer
On 1/10/2020 11:30 AM, Anton Khirnov wrote: > Quoting James Almer (2020-01-10 14:33:06) >> On 1/10/2020 8:21 AM, Anton Khirnov wrote: >>> They are private and not used by anything outside of lavf. There is no >>> reason for them to be exported. >>> --- >>> libavformat/avio.c| 4 ++-- >>>

Re: [FFmpeg-devel] [PATCH 2/2] avio: do not export avpriv_io_{move, delete}

2020-01-10 Thread Marton Balint
On Fri, 10 Jan 2020, Anton Khirnov wrote: Quoting James Almer (2020-01-10 14:33:06) On 1/10/2020 8:21 AM, Anton Khirnov wrote: > They are private and not used by anything outside of lavf. There is no > reason for them to be exported. > --- > libavformat/avio.c| 4 ++-- >

Re: [FFmpeg-devel] [PATCH 2/2] avio: do not export avpriv_io_{move, delete}

2020-01-10 Thread Anton Khirnov
Quoting James Almer (2020-01-10 14:33:06) > On 1/10/2020 8:21 AM, Anton Khirnov wrote: > > They are private and not used by anything outside of lavf. There is no > > reason for them to be exported. > > --- > > libavformat/avio.c| 4 ++-- > > libavformat/avio.h| 19 --- > >

Re: [FFmpeg-devel] [PATCH 2/2] avio: do not export avpriv_io_{move, delete}

2020-01-10 Thread James Almer
On 1/10/2020 8:21 AM, Anton Khirnov wrote: > They are private and not used by anything outside of lavf. There is no > reason for them to be exported. > --- > libavformat/avio.c| 4 ++-- > libavformat/avio.h| 19 --- > libavformat/dashenc.c | 10 +- >

[FFmpeg-devel] [PATCH 2/2] avio: do not export avpriv_io_{move, delete}

2020-01-10 Thread Anton Khirnov
They are private and not used by anything outside of lavf. There is no reason for them to be exported. --- libavformat/avio.c| 4 ++-- libavformat/avio.h| 19 --- libavformat/dashenc.c | 10 +- libavformat/url.h | 20 4 files changed, 27