Re: [FFmpeg-devel] [PATCH 2/2] libavformat/mxfenc: add support for muxing mxf opatom audio

2015-03-27 Thread Tomas Härdin
On Wed, 2015-03-25 at 15:43 -0700, Mark Reid wrote: > On Mar 24, 2015 7:05 AM, "Tomas Härdin" wrote: > > > > On Sat, 2015-03-21 at 16:45 -0700, Mark Reid wrote: > > > --- > > > libavformat/mxfenc.c | 100 > ++- > > > 1 file changed, 83 insertions(+)

Re: [FFmpeg-devel] [PATCH 2/2] libavformat/mxfenc: add support for muxing mxf opatom audio

2015-03-25 Thread Mark Reid
On Mar 24, 2015 7:05 AM, "Tomas Härdin" wrote: > > On Sat, 2015-03-21 at 16:45 -0700, Mark Reid wrote: > > --- > > libavformat/mxfenc.c | 100 ++- > > 1 file changed, 83 insertions(+), 17 deletions(-) > > Looks fine as far as I can tell. My only nit

Re: [FFmpeg-devel] [PATCH 2/2] libavformat/mxfenc: add support for muxing mxf opatom audio

2015-03-23 Thread Tomas Härdin
On Sat, 2015-03-21 at 16:45 -0700, Mark Reid wrote: > --- > libavformat/mxfenc.c | 100 > ++- > 1 file changed, 83 insertions(+), 17 deletions(-) Looks fine as far as I can tell. My only nitpick is that it might be better to call "timecode rate" Ed

[FFmpeg-devel] [PATCH 2/2] libavformat/mxfenc: add support for muxing mxf opatom audio

2015-03-21 Thread Mark Reid
--- libavformat/mxfenc.c | 100 ++- 1 file changed, 83 insertions(+), 17 deletions(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index ac60357..7483ddc 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -313,6 +313,7 @@ ty