Re: [FFmpeg-devel] [PATCH 3/3] avcodec: Implement mpeg4 nvdec hwaccel

2017-11-21 Thread Michael Niedermayer
On Mon, Nov 20, 2017 at 08:10:36PM -0800, Philip Langdale wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On Mon, 20 Nov 2017 22:53:00 +0100 > Michael Niedermayer wrote: > > > On Sun, Nov 19, 2017 at 11:52:28AM -0800, Philip Langdale wrote: > > > This was

Re: [FFmpeg-devel] [PATCH 3/3] avcodec: Implement mpeg4 nvdec hwaccel

2017-11-20 Thread Philip Langdale
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, 20 Nov 2017 22:53:00 +0100 Michael Niedermayer wrote: > On Sun, Nov 19, 2017 at 11:52:28AM -0800, Philip Langdale wrote: > > This was predictably nightmarish, given how ridiculous mpeg4 is. > > I had to stare at the

Re: [FFmpeg-devel] [PATCH 3/3] avcodec: Implement mpeg4 nvdec hwaccel

2017-11-20 Thread Michael Niedermayer
On Sun, Nov 19, 2017 at 11:52:28AM -0800, Philip Langdale wrote: > This was predictably nightmarish, given how ridiculous mpeg4 is. > I had to stare at the cuvid parser output for a long time to work > out what each field was supposed to be, and even then, I still don't > fully understand some of

Re: [FFmpeg-devel] [PATCH 3/3] avcodec: Implement mpeg4 nvdec hwaccel

2017-11-20 Thread Philip Langdale
On Mon, 20 Nov 2017 10:59:52 +0100 Timo Rothenpieler wrote: > > Duplicate. Will remove. > > Can't really tell if the parameters are in any way correct, but I > guess time will tell if some sample comes up that breaks it. > > lgtm with that duplicate removed > Thanks.

Re: [FFmpeg-devel] [PATCH 3/3] avcodec: Implement mpeg4 nvdec hwaccel

2017-11-20 Thread Timo Rothenpieler
Duplicate. Will remove. Can't really tell if the parameters are in any way correct, but I guess time will tell if some sample comes up that breaks it. lgtm with that duplicate removed smime.p7s Description: S/MIME Cryptographic Signature ___

Re: [FFmpeg-devel] [PATCH 3/3] avcodec: Implement mpeg4 nvdec hwaccel

2017-11-19 Thread Carl Eugen Hoyos
2017-11-19 23:35 GMT+01:00 Carl Eugen Hoyos : > 2017-11-19 20:52 GMT+01:00 Philip Langdale : > >> gmc_enabled: This seems to map to mc_sel being non-zero, but I also >> have no samples where that is true. > > Iirc, global motion compensation is

Re: [FFmpeg-devel] [PATCH 3/3] avcodec: Implement mpeg4 nvdec hwaccel

2017-11-19 Thread Philip Langdale
On Sun, 19 Nov 2017 11:52:28 -0800 Philip Langdale wrote: > This was predictably nightmarish, given how ridiculous mpeg4 is. > I had to stare at the cuvid parser output for a long time to work > out what each field was supposed to be, and even then, I still don't > fully

Re: [FFmpeg-devel] [PATCH 3/3] avcodec: Implement mpeg4 nvdec hwaccel

2017-11-19 Thread Philip Langdale
On Sun, 19 Nov 2017 23:35:24 +0100 Carl Eugen Hoyos wrote: > 2017-11-19 20:52 GMT+01:00 Philip Langdale : > > > gmc_enabled: This seems to map to mc_sel being non-zero, but I also > > have no samples where that is true. > > Iirc, global

Re: [FFmpeg-devel] [PATCH 3/3] avcodec: Implement mpeg4 nvdec hwaccel

2017-11-19 Thread Carl Eugen Hoyos
2017-11-19 20:52 GMT+01:00 Philip Langdale : > gmc_enabled: This seems to map to mc_sel being non-zero, but I also > have no samples where that is true. Iirc, global motion compensation is not supported by hardware decoders. Carl Eugen

[FFmpeg-devel] [PATCH 3/3] avcodec: Implement mpeg4 nvdec hwaccel

2017-11-19 Thread Philip Langdale
This was predictably nightmarish, given how ridiculous mpeg4 is. I had to stare at the cuvid parser output for a long time to work out what each field was supposed to be, and even then, I still don't fully understand some of them, particularly: vop_coded: I think this means whether the vop has a