Re: [FFmpeg-devel] [PATCH 3/4] avfilter/vf_ccrepack: Constify filter

2023-07-01 Thread Rémi Denis-Courmont
Le 29 juin 2023 22:42:17 GMT+03:00, Paul B Mahol a écrit : >On Thu, Jun 29, 2023 at 9:35 PM Andreas Rheinhardt < >andreas.rheinha...@outlook.com> wrote: > >> Paul B Mahol: >> > On Thu, Jun 29, 2023 at 8:18 PM Andreas Rheinhardt < >> > andreas.rheinha...@outlook.com> wrote: >> > >> >> The

Re: [FFmpeg-devel] [PATCH 3/4] avfilter/vf_ccrepack: Constify filter

2023-06-29 Thread Andreas Rheinhardt
Paul B Mahol: > On Thu, Jun 29, 2023 at 9:35 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Paul B Mahol: >>> On Thu, Jun 29, 2023 at 8:18 PM Andreas Rheinhardt < >>> andreas.rheinha...@outlook.com> wrote: >>> The discrepancy between the definition and the declaration

Re: [FFmpeg-devel] [PATCH 3/4] avfilter/vf_ccrepack: Constify filter

2023-06-29 Thread James Almer
On 6/29/2023 4:42 PM, Paul B Mahol wrote: On Thu, Jun 29, 2023 at 9:35 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: Paul B Mahol: On Thu, Jun 29, 2023 at 8:18 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: The discrepancy between the definition and the

Re: [FFmpeg-devel] [PATCH 3/4] avfilter/vf_ccrepack: Constify filter

2023-06-29 Thread Paul B Mahol
On Thu, Jun 29, 2023 at 9:35 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Paul B Mahol: > > On Thu, Jun 29, 2023 at 8:18 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> The discrepancy between the definition and the declaration > >> in allfilters.c

Re: [FFmpeg-devel] [PATCH 3/4] avfilter/vf_ccrepack: Constify filter

2023-06-29 Thread Andreas Rheinhardt
Paul B Mahol: > On Thu, Jun 29, 2023 at 8:18 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> The discrepancy between the definition and the declaration >> in allfilters.c is actually UB. >> > > I get no such message with ubsan. > UBSan is a runtime UB-detector, not a

Re: [FFmpeg-devel] [PATCH 3/4] avfilter/vf_ccrepack: Constify filter

2023-06-29 Thread Paul B Mahol
On Thu, Jun 29, 2023 at 8:18 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > The discrepancy between the definition and the declaration > in allfilters.c is actually UB. > I get no such message with ubsan. > > Signed-off-by: Andreas Rheinhardt > --- >

Re: [FFmpeg-devel] [PATCH 3/4] avfilter/vf_ccrepack: Constify filter

2023-06-29 Thread James Almer
On 6/29/2023 3:19 PM, Andreas Rheinhardt wrote: The discrepancy between the definition and the declaration in allfilters.c is actually UB. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_ccrepack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 3/4] avfilter/vf_ccrepack: Constify filter

2023-06-29 Thread Andreas Rheinhardt
The discrepancy between the definition and the declaration in allfilters.c is actually UB. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_ccrepack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_ccrepack.c b/libavfilter/vf_ccrepack.c index