Re: [FFmpeg-devel] [PATCH 3/4] avformat/dvdvideodec: Only free allocated buffers

2024-03-02 Thread Marth64
Nevermind, disregard. They do not, and I misread. Thanks for catching this. On Sat, Mar 2, 2024 at 8:31 PM Marth64 wrote: > FYI: hls, dashdec do the same av_freep(). Doesn't make this right, but > saying that was where I used as an example (so they should probably fixed > too?) > > On Sat, Mar

Re: [FFmpeg-devel] [PATCH 3/4] avformat/dvdvideodec: Only free allocated buffers

2024-03-02 Thread Marth64
FYI: hls, dashdec do the same av_freep(). Doesn't make this right, but saying that was where I used as an example (so they should probably fixed too?) On Sat, Mar 2, 2024 at 10:17 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > James Almer: > > On 3/2/2024 12:47 PM, Andreas

Re: [FFmpeg-devel] [PATCH 3/4] avformat/dvdvideodec: Only free allocated buffers

2024-03-02 Thread Andreas Rheinhardt
James Almer: > On 3/2/2024 12:47 PM, Andreas Rheinhardt wrote: >> Andreas Rheinhardt: >>> Signed-off-by: Andreas Rheinhardt >>> --- >>> How has this slipped through? >> >> Answer: AVIOContext starts with an AVClass* that is unset when using >> ffio_init_context(). Therefore the av_freep() leads

Re: [FFmpeg-devel] [PATCH 3/4] avformat/dvdvideodec: Only free allocated buffers

2024-03-02 Thread James Almer
On 3/2/2024 12:47 PM, Andreas Rheinhardt wrote: Andreas Rheinhardt: Signed-off-by: Andreas Rheinhardt --- How has this slipped through? Answer: AVIOContext starts with an AVClass* that is unset when using ffio_init_context(). Therefore the av_freep() leads to freeing of a NULL pointer which

Re: [FFmpeg-devel] [PATCH 3/4] avformat/dvdvideodec: Only free allocated buffers

2024-03-02 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > How has this slipped through? Answer: AVIOContext starts with an AVClass* that is unset when using ffio_init_context(). Therefore the av_freep() leads to freeing of a NULL pointer which does not segfault. > Btw: This patchset is

[FFmpeg-devel] [PATCH 3/4] avformat/dvdvideodec: Only free allocated buffers

2024-03-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- How has this slipped through? Btw: This patchset is based upon code inspection, not on reading actual files. libavformat/dvdvideodec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c index