Re: [FFmpeg-devel] [PATCH 3/4] ffserver_conf: factorize parse function per config tag

2014-10-22 Thread Reynaldo H. Verdejo Pinochet
Feel free to push after removing the explicit/redundant initialization of FFServerConfig config as Reimar suggested. While you are at this though, can you remove braces on single statement ifs? appreciated. Thanks -- Reynaldo H. Verdejo Pinochet Open Source Group Samsung Research America /

Re: [FFmpeg-devel] [PATCH 3/4] ffserver_conf: factorize parse function per config tag

2014-10-21 Thread Stefano Sabatini
On date Monday 2014-10-20 23:57:01 +0200, Lukasz Marek encoded: Signed-off-by: Lukasz Marek lukasz.m.lu...@gmail.com --- ffserver.c|6 + ffserver_config.c | 1138 ++--- ffserver_config.h |7 + 3 files changed, 566

Re: [FFmpeg-devel] [PATCH 3/4] ffserver_conf: factorize parse function per config tag

2014-10-21 Thread Reimar Döffinger
On 21.10.2014, at 12:15, Stefano Sabatini stefa...@gmail.com wrote: On date Monday 2014-10-20 23:57:01 +0200, Lukasz Marek encoded: Signed-off-by: Lukasz Marek lukasz.m.lu...@gmail.com --- ffserver.c|6 + ffserver_config.c | 1138

[FFmpeg-devel] [PATCH 3/4] ffserver_conf: factorize parse function per config tag

2014-10-20 Thread Lukasz Marek
Signed-off-by: Lukasz Marek lukasz.m.lu...@gmail.com --- ffserver.c|6 + ffserver_config.c | 1138 ++--- ffserver_config.h |7 + 3 files changed, 566 insertions(+), 585 deletions(-) diff --git a/ffserver.c b/ffserver.c index