Re: [FFmpeg-devel] [PATCH 3/7] avformat/assenc: support remuxing old V4 ASS form (SSA)

2014-10-14 Thread Clément Bœsch
On Tue, Oct 14, 2014 at 08:12:38PM +0200, James Darnley wrote: > On 2014-10-11 19:59, Clément Bœsch wrote: > > --- > > libavformat/assenc.c | 11 +-- > > 1 file changed, 9 insertions(+), 2 deletions(-) > > The diff looks fine. So if the code does what you want it to do, push. > Just one

Re: [FFmpeg-devel] [PATCH 3/7] avformat/assenc: support remuxing old V4 ASS form (SSA)

2014-10-14 Thread James Darnley
On 2014-10-11 19:59, Clément Bœsch wrote: > --- > libavformat/assenc.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) The diff looks fine. So if the code does what you want it to do, push. Just one comment below. > +ass->ssa_mode = !strstr(avctx->extradata, "\n[V4+

[FFmpeg-devel] [PATCH 3/7] avformat/assenc: support remuxing old V4 ASS form (SSA)

2014-10-11 Thread Clément Bœsch
--- libavformat/assenc.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/libavformat/assenc.c b/libavformat/assenc.c index d495ce3..8225967 100644 --- a/libavformat/assenc.c +++ b/libavformat/assenc.c @@ -35,6 +35,7 @@ typedef struct ASSContext{ DialogueLine *d