Re: [FFmpeg-devel] [PATCH 6/8] avcodec/h264_redundant_pps_bsf: implement a AVBSFContext.flush() callback

2018-08-02 Thread Michael Niedermayer
On Wed, Aug 01, 2018 at 11:20:46PM +0100, Mark Thompson wrote: > On 28/07/18 22:59, Michael Niedermayer wrote: > > On Fri, Jul 27, 2018 at 11:57:47AM -0300, James Almer wrote: > >> Signed-off-by: James Almer > >> --- > >> I'm not 100% sure this is correct. I also don't know if the CBS contexts >

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/h264_redundant_pps_bsf: implement a AVBSFContext.flush() callback

2018-08-01 Thread James Almer
On 8/1/2018 7:20 PM, Mark Thompson wrote: > The problematic streams repeatedly overwrite PPS id 0 with different > parameters, and that's what we're fixing up here - using a stream like that > in any case with global extradata fails on seeking or fragmenting. So is this patch correct? Should i

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/h264_redundant_pps_bsf: implement a AVBSFContext.flush() callback

2018-08-01 Thread Mark Thompson
On 28/07/18 22:59, Michael Niedermayer wrote: > On Fri, Jul 27, 2018 at 11:57:47AM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> I'm not 100% sure this is correct. I also don't know if the CBS contexts need >> to be fully reinitialized or not in this scenario. Because if so,

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/h264_redundant_pps_bsf: implement a AVBSFContext.flush() callback

2018-07-28 Thread James Almer
On 7/28/2018 6:59 PM, Michael Niedermayer wrote: > On Fri, Jul 27, 2018 at 11:57:47AM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> I'm not 100% sure this is correct. I also don't know if the CBS contexts need >> to be fully reinitialized or not in this scenario. Because if

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/h264_redundant_pps_bsf: implement a AVBSFContext.flush() callback

2018-07-28 Thread Michael Niedermayer
On Fri, Jul 27, 2018 at 11:57:47AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > I'm not 100% sure this is correct. I also don't know if the CBS contexts need > to be fully reinitialized or not in this scenario. Because if so, then every > bsf using cbs will require a flush()

[FFmpeg-devel] [PATCH 6/8] avcodec/h264_redundant_pps_bsf: implement a AVBSFContext.flush() callback

2018-07-27 Thread James Almer
Signed-off-by: James Almer --- I'm not 100% sure this is correct. I also don't know if the CBS contexts need to be fully reinitialized or not in this scenario. Because if so, then every bsf using cbs will require a flush() callback as well. libavcodec/h264_redundant_pps_bsf.c | 9 + 1