Re: [FFmpeg-devel] [PATCH 6/8] x86inc: reduce difference to x264 upstream

2017-11-06 Thread James Almer
On 11/6/2017 5:28 PM, James Darnley wrote: > On 2017-11-06 21:15, James Almer wrote: >> On 11/6/2017 4:56 PM, James Darnley wrote: >>> Line 733 is the align command to align the start of the function. I >>> can't see why it fails here but not on any other function in that file >>> or any other

Re: [FFmpeg-devel] [PATCH 6/8] x86inc: reduce difference to x264 upstream

2017-11-06 Thread James Darnley
On 2017-11-06 21:15, James Almer wrote: > On 11/6/2017 4:56 PM, James Darnley wrote: >> Line 733 is the align command to align the start of the function. I >> can't see why it fails here but not on any other function in that file >> or any other file. >> >> After some cutting and pasting there is

Re: [FFmpeg-devel] [PATCH 6/8] x86inc: reduce difference to x264 upstream

2017-11-06 Thread James Almer
On 11/6/2017 4:56 PM, James Darnley wrote: > On 2017-10-31 04:30, Michael Niedermayer wrote: >> On Mon, Oct 30, 2017 at 02:08:33PM +0100, James Darnley wrote: >>> These changes were commited to x264 in b568a256 "Experimental nasm >>> support" >>> --- >>> libavutil/x86/x86inc.asm | 16

Re: [FFmpeg-devel] [PATCH 6/8] x86inc: reduce difference to x264 upstream

2017-11-06 Thread James Darnley
On 2017-10-31 04:30, Michael Niedermayer wrote: > On Mon, Oct 30, 2017 at 02:08:33PM +0100, James Darnley wrote: >> These changes were commited to x264 in b568a256 "Experimental nasm >> support" >> --- >> libavutil/x86/x86inc.asm | 16 ++-- >> 1 file changed, 14 insertions(+), 2

Re: [FFmpeg-devel] [PATCH 6/8] x86inc: reduce difference to x264 upstream

2017-10-30 Thread Michael Niedermayer
On Mon, Oct 30, 2017 at 02:08:33PM +0100, James Darnley wrote: > These changes were commited to x264 in b568a256 "Experimental nasm > support" > --- > libavutil/x86/x86inc.asm | 16 ++-- > 1 file changed, 14 insertions(+), 2 deletions(-) breaks build: libavcodec/x86/rv34dsp.asm:211:

[FFmpeg-devel] [PATCH 6/8] x86inc: reduce difference to x264 upstream

2017-10-30 Thread James Darnley
These changes were commited to x264 in b568a256 "Experimental nasm support" --- libavutil/x86/x86inc.asm | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm index f3dd2b788a..10e4603a65 100644 ---