Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-08-27 Thread Timo Rothenpieler
There still are some issues in the C side of this filter: You're allocating a lot of stuff on init (integral_img, ...) but never free it. So the filter leaks those. You define a list of supported formats at the top, listing practically all formats that can be in a CUDA frame as of right now.

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-08-22 Thread Timo Rothenpieler
If nobody wants to review the algorithm being implemented, I'm gonna apply this soon. It looks fine by all I can tell, but I never touched the software version of this filter. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-08-15 Thread Dylan Fernando
On Sat, Aug 14, 2021 at 1:03 PM Timo Rothenpieler wrote: > On 14.08.2021 07:49, Dylan Fernando wrote: > > On Sat, Aug 14, 2021 at 9:11 AM Timo Rothenpieler > > > wrote: > > > >> On 13.08.2021 10:42, Dylan Fernando wrote: > >>> Any update on this? > >>> > >>> Kind Regards, > >>> Dylan > >> > >>

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-08-14 Thread Timo Rothenpieler
On 14.08.2021 07:49, Dylan Fernando wrote: On Sat, Aug 14, 2021 at 9:11 AM Timo Rothenpieler wrote: On 13.08.2021 10:42, Dylan Fernando wrote: Any update on this? Kind Regards, Dylan Also, are you sure that exp() function is correct? The CUDA-Function exp() is defined as "double

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-08-14 Thread Timo Rothenpieler
On 14.08.2021 07:49, Dylan Fernando wrote: On Sat, Aug 14, 2021 at 9:11 AM Timo Rothenpieler wrote: On 13.08.2021 10:42, Dylan Fernando wrote: Any update on this? Kind Regards, Dylan Also, are you sure that exp() function is correct? The CUDA-Function exp() is defined as "double

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-08-13 Thread Dylan Fernando
On Sat, Aug 14, 2021 at 9:11 AM Timo Rothenpieler wrote: > On 13.08.2021 10:42, Dylan Fernando wrote: > > Any update on this? > > > > Kind Regards, > > Dylan > > Also, are you sure that exp() function is correct? > > The CUDA-Function exp() is defined as "double exp(double x)" and > calculates

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-08-13 Thread Timo Rothenpieler
On 13.08.2021 10:42, Dylan Fernando wrote: Any update on this? Kind Regards, Dylan Also, are you sure that exp() function is correct? The CUDA-Function exp() is defined as "double exp(double x)" and calculates the base e exponential. While __nvvm_ex2_approx_f reads to me like it does so

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-08-13 Thread Timo Rothenpieler
On 13.08.2021 10:42, Dylan Fernando wrote: Any update on this? Missing license header in both new files (please re-send for this). Missing version bump, though I can add this when pushing as well. The code looks fine to me, though I have no experience with this algorithm at all, so if

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-08-13 Thread Dylan Fernando
Any update on this? Kind Regards, Dylan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-07-27 Thread Timo Rothenpieler
I'm super loaded with work this week already, so I won't have a chance to look at this before some time next week. First glance looks fine though and I'll come back to you with a proper review next week! smime.p7s Description: S/MIME Cryptographic Signature

[FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-07-27 Thread Dylan Fernando
From 2ddd2f5e0d9559bbbf46de3d7cfb7ffbbdbefceb Mon Sep 17 00:00:00 2001 From: Dylan Fernando Date: Tue, 27 Jul 2021 19:25:59 + Subject: [PATCH] lavfi: add nlmeans_cuda filter --- compat/cuda/cuda_runtime.h | 1 + configure | 2 + doc/filters.texi |