Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-05 Thread Carl Eugen Hoyos
2016-09-05 11:06 GMT+02:00 Ali KIZIL : > 2016-09-05 12:04 GMT+03:00 Carl Eugen Hoyos : > >> 2016-09-05 10:53 GMT+02:00 Ali KIZIL : >> >> > Is there any obstacle to release this patch ? >> >> Which patch? > > Sorry Carl, maybe I missed. I mean the patch for "add unscaled > conversion from yuv420p to

Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-05 Thread Carl Eugen Hoyos
2016-09-03 15:25 GMT+02:00 Timo Rothenpieler : > +static int planar8ToP010leWrapper If you want, you can rename this function to planar8ToP01xleWrapper or planar8ToP016leWrapper after removing the binary and. Carl Eugen ___ ffmpeg-devel mailing list ff

Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-05 Thread Ali KIZIL
2016-09-05 12:04 GMT+03:00 Carl Eugen Hoyos : > 2016-09-05 10:53 GMT+02:00 Ali KIZIL : > > > Is there any obstacle to release this patch ? > > Which patch? > > Carl Eugen > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mai

Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-05 Thread Carl Eugen Hoyos
2016-09-05 10:53 GMT+02:00 Ali KIZIL : > Is there any obstacle to release this patch ? Which patch? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-05 Thread Ali KIZIL
2016-09-04 20:34 GMT+03:00 Ronald S. Bultje : > Hi, > > On Sep 4, 2016 5:42 PM, "Timo Rothenpieler" wrote: > > > > On 9/4/2016 4:06 PM, Carl Eugen Hoyos wrote: > > > 2016-09-04 16:02 GMT+02:00 Timo Rothenpieler : > > >> The purpose of this patch is to make conversion from > > >> yuv420p (8 bit) t

Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-04 Thread Ronald S. Bultje
Hi, On Sep 4, 2016 5:42 PM, "Timo Rothenpieler" wrote: > > On 9/4/2016 4:06 PM, Carl Eugen Hoyos wrote: > > 2016-09-04 16:02 GMT+02:00 Timo Rothenpieler : > >> The purpose of this patch is to make conversion from > >> yuv420p (8 bit) to p010 (10 bit) fast. > > > > Do I understand you correctly th

Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-04 Thread Timo Rothenpieler
On 9/4/2016 4:06 PM, Carl Eugen Hoyos wrote: > 2016-09-04 16:02 GMT+02:00 Timo Rothenpieler : >> The purpose of this patch is to make conversion from >> yuv420p (8 bit) to p010 (10 bit) fast. > > Do I understand you correctly that your patch is > faster without the change I suggested? With the &:

Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-04 Thread Ali KIZIL
Hi, On Sep 4, 2016 5:33 PM, "Ronald S. Bultje" wrote: > > Hi, > > On Sun, Sep 4, 2016 at 10:06 AM, Carl Eugen Hoyos > wrote: > > > 2016-09-04 16:02 GMT+02:00 Timo Rothenpieler : > > > The purpose of this patch is to make conversion from > > > yuv420p (8 bit) to p010 (10 bit) fast. > > > > Do I u

Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-04 Thread Ronald S. Bultje
Hi, On Sun, Sep 4, 2016 at 10:06 AM, Carl Eugen Hoyos wrote: > 2016-09-04 16:02 GMT+02:00 Timo Rothenpieler : > > The purpose of this patch is to make conversion from > > yuv420p (8 bit) to p010 (10 bit) fast. > > Do I understand you correctly that your patch is > faster without the change I sug

Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-04 Thread Ali KIZIL
On Sep 4, 2016 5:02 PM, "Timo Rothenpieler" wrote: > > > Finally, with the change, the function can also be used > > for P016, note that I tried to object to P010: It does not > > serve any real purpose, if I remember correctly, the > > explanation for the commit was that there is a bug in > > FFm

Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-04 Thread Carl Eugen Hoyos
2016-09-04 16:02 GMT+02:00 Timo Rothenpieler : > The purpose of this patch is to make conversion from > yuv420p (8 bit) to p010 (10 bit) fast. Do I understand you correctly that your patch is faster without the change I suggested? Carl Eugen ___ ffmpeg-

Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-04 Thread Timo Rothenpieler
> Finally, with the change, the function can also be used > for P016, note that I tried to object to P010: It does not > serve any real purpose, if I remember correctly, the > explanation for the commit was that there is a bug in > FFmpeg's pix_fmt decision routine that needed to > be worked-around

Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-04 Thread Carl Eugen Hoyos
2016-09-04 15:42 GMT+02:00 Hendrik Leppkes : > On Sun, Sep 4, 2016 at 1:18 PM, Carl Eugen Hoyos wrote: >> 2016-09-04 13:10 GMT+02:00 Paul B Mahol : >>> On 9/4/16, Carl Eugen Hoyos wrote: 2016-09-03 15:25 GMT+02:00 Timo Rothenpieler : > +output_pixel(tdstY++, (t | (t << 8

Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-04 Thread Hendrik Leppkes
On Sun, Sep 4, 2016 at 1:18 PM, Carl Eugen Hoyos wrote: > 2016-09-04 13:10 GMT+02:00 Paul B Mahol : >> On 9/4/16, Carl Eugen Hoyos wrote: >>> 2016-09-03 15:25 GMT+02:00 Timo Rothenpieler : >>> +output_pixel(tdstY++, (t | (t << 8)) & 0xFFC0); >>> >>> Please remove the "& 0xFFC0" h

Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-04 Thread Carl Eugen Hoyos
2016-09-04 13:10 GMT+02:00 Paul B Mahol : > On 9/4/16, Carl Eugen Hoyos wrote: >> 2016-09-03 15:25 GMT+02:00 Timo Rothenpieler : >> >>> +output_pixel(tdstY++, (t | (t << 8)) & 0xFFC0); >> >> Please remove the "& 0xFFC0" here and below. > > Please explain your reasoning here. The linke

Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-04 Thread Paul B Mahol
On 9/4/16, Carl Eugen Hoyos wrote: > 2016-09-03 15:25 GMT+02:00 Timo Rothenpieler : > >> +output_pixel(tdstY++, (t | (t << 8)) & 0xFFC0); > > Please remove the "& 0xFFC0" here and below. Please explain your reasoning here. ___ ffmpeg-devel m

Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-04 Thread Carl Eugen Hoyos
2016-09-03 15:25 GMT+02:00 Timo Rothenpieler : > +output_pixel(tdstY++, (t | (t << 8)) & 0xFFC0); Please remove the "& 0xFFC0" here and below. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listin

Re: [FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-03 Thread Timo Rothenpieler
> @@ -236,6 +237,57 @@ static int planarToP010Wrapper(SwsContext *c, const > uint8_t *src8[], > return srcSliceH; > } > > +#if AV_HAVE_BIGENDIAN || 1 Nevermind the || 1, left over from testing speed differences and forgot to remove it. ___ ffmpe

[FFmpeg-devel] [PATCH v2] swscale: add unscaled conversion from yuv420p to p010

2016-09-03 Thread Timo Rothenpieler
--- libswscale/swscale_unscaled.c| 57 tests/ref/fate/filter-pixdesc-p010le | 2 +- tests/ref/fate/filter-pixfmts-copy | 2 +- tests/ref/fate/filter-pixfmts-crop | 2 +- tests/ref/fate/filter-pixfmts-field | 2 +- tests/ref/fate/filter-pixfmts-