Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-11 Thread Nicolas George
Jun Li (12019-05-10): > I think now I understand what you mean"lavfi does not support real > reconfiguration of the stream properties. " > Even we have a perfect filter for this case, we still have to dynamic > turn on/off the filter per frame's metadata. No, that is not what I meant: there is

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-10 Thread Jun Li
On Thu, May 9, 2019 at 1:52 AM Nicolas George wrote: > Jun Li (12019-05-06): > > I agree with it that the patch can't solve the case that "not all frames > > have the same orientation". > > The only way I can think of (correct me if I am wrong) is a filter that > > dynamic do tranformation per

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Paul B Mahol
On 5/9/19, Nicolas George wrote: > Paul B Mahol (12019-05-09): >> Merging of what filters? > > transpose and rotate when it is an integer quarter of turns. But > apparently they are already merged. > >> Your reasoning is illogical. > > Your reasoning is absent. > Give mathematical proof.

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Nicolas George
Paul B Mahol (12019-05-09): > Merging of what filters? transpose and rotate when it is an integer quarter of turns. But apparently they are already merged. > Your reasoning is illogical. Your reasoning is absent. -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Paul B Mahol
On 5/9/19, Nicolas George wrote: > Jun Li (12019-05-09): >> I see transpose filter and vflip/hvlip filter, but could not find >> "transform". > > I do not think I suggested a filter with that name exists. > >> are you suggesting creating a new one achieve both transpose and flip, or >> modify

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Nicolas George
Jun Li (12019-05-09): > I see transpose filter and vflip/hvlip filter, but could not find > "transform". I do not think I suggested a filter with that name exists. > are you suggesting creating a new one achieve both transpose and flip, or > modify transpose to support flip ? You will also

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Jun Li
On Thu, May 9, 2019 at 2:29 AM Nicolas George wrote: > Jun Li (12019-05-09): > > The image's exif ("orientation") info is kept inside of frame metadata, > > maybe the filter can directly read from frame, instead of re-config > > the stream level metadata ? > > That is exactly what I was

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Nicolas George
Jun Li (12019-05-09): > The image's exif ("orientation") info is kept inside of frame metadata, > maybe the filter can directly read from frame, instead of re-config > the stream level metadata ? That is exactly what I was suggesting. Regards, -- Nicolas George signature.asc Description:

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Jun Li
On Thu, May 9, 2019 at 1:52 AM Nicolas George wrote: > Jun Li (12019-05-06): > > I agree with it that the patch can't solve the case that "not all frames > > have the same orientation". > > The only way I can think of (correct me if I am wrong) is a filter that > > dynamic do tranformation per

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Nicolas George
Jun Li (12019-05-06): > I agree with it that the patch can't solve the case that "not all frames > have the same orientation". > The only way I can think of (correct me if I am wrong) is a filter that > dynamic do tranformation per frame. > > From a technical perspective, this kind of media is

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-07 Thread Michael Niedermayer
On Sun, May 05, 2019 at 08:41:28PM -0700, Jun Li wrote: > Fix #6945 > Exif extension has 'Orientaion' field for image flip and rotation. > This change is to add the first frame's exif into stream so that > autorotation would use the info to adjust the frames. > --- > fftools/ffmpeg.c | 52

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-06 Thread Jun Li
On Mon, May 6, 2019 at 3:04 PM Carl Eugen Hoyos wrote: > Am Mo., 6. Mai 2019 um 05:41 Uhr schrieb Jun Li : > > +uint8_t* sd = NULL; > > Wouldn't it simplify the patch if this were a pointer to int32_t? > Or is there a aliasing violation that can't be avoided? > Thanks Carl for review. Will

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-06 Thread Carl Eugen Hoyos
Am Mo., 6. Mai 2019 um 05:41 Uhr schrieb Jun Li : > +uint8_t* sd = NULL; Wouldn't it simplify the patch if this were a pointer to int32_t? Or is there a aliasing violation that can't be avoided? > +if (entry) { > +orientation = atoi(entry->value); > +sd =

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-06 Thread Jun Li
On Mon, May 6, 2019 at 1:52 AM Nicolas George wrote: > Jun Li (12019-05-05): > > Fix #6945 > > Exif extension has 'Orientaion' field for image flip and rotation. > > This change is to add the first frame's exif into stream so that > > autorotation would use the info to adjust the frames. > >

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-06 Thread Nicolas George
Jun Li (12019-05-05): > Fix #6945 > Exif extension has 'Orientaion' field for image flip and rotation. > This change is to add the first frame's exif into stream so that > autorotation would use the info to adjust the frames. What happens if not all frames have the same orientation? Regards, --

[FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-05 Thread Jun Li
Fix #6945 Exif extension has 'Orientaion' field for image flip and rotation. This change is to add the first frame's exif into stream so that autorotation would use the info to adjust the frames. --- fftools/ffmpeg.c | 52 1 file changed, 52