Re: [FFmpeg-devel] [PATCH v4] lavc/audiotoolboxenc: fix noise in encoded audio

2018-01-03 Thread James Almer
On 1/3/2018 1:54 AM, zhangjiejun1...@gmail.com wrote: > From: Jiejun Zhang > > This fixes #6940 > > Although undocumented, AudioToolbox seems to require the data supplied > by the callback (i.e. ffat_encode_callback) being unchanged until the > next time the callback is called. In the old implem

Re: [FFmpeg-devel] [PATCH v4] lavc/audiotoolboxenc: fix noise in encoded audio

2018-01-03 Thread Jiejun Zhang
On Wed, Jan 3, 2018 at 2:24 PM, Bang He wrote: > maybe you should return 1, not return ret returning ret in callback will make AudioConverterFillComplexBuffer return ret. so i think returning ret is better. furthermore 1 is not treated as an error code in the current implementation of ffat_encod

Re: [FFmpeg-devel] [PATCH v4] lavc/audiotoolboxenc: fix noise in encoded audio

2018-01-02 Thread Bang He
maybe you should return 1, not return ret On Wed, Jan 3, 2018 at 12:54 PM, wrote: > From: Jiejun Zhang > > This fixes #6940 > > Although undocumented, AudioToolbox seems to require the data supplied > by the callback (i.e. ffat_encode_callback) being unchanged until the > next time the callbac

[FFmpeg-devel] [PATCH v4] lavc/audiotoolboxenc: fix noise in encoded audio

2018-01-02 Thread zhangjiejun1992
From: Jiejun Zhang This fixes #6940 Although undocumented, AudioToolbox seems to require the data supplied by the callback (i.e. ffat_encode_callback) being unchanged until the next time the callback is called. In the old implementation, the AVBuffer backing the frame is recycled after the frame