Re: [FFmpeg-devel] [PATCH v4 0/4] Fix MSVC build without optimizations

2023-07-29 Thread L. E. Segovia
Hi all, Yes, the linking step bails out with optimizations disabled under MSVC. The rest of the compilers perform DCE even at -O0, but under Windows, the /FORCE:UNRESOLVED linker flag is needed to work around this. As for the stub generation -- given the amount of places that these patches

Re: [FFmpeg-devel] [PATCH v4 0/4] Fix MSVC build without optimizations

2023-07-28 Thread Matt Oliver
On Fri, 28 Jul 2023 at 20:55, Nicolas George wrote: > Reimar Döffinger (12023-07-28): > > I assume the issue is missing symbols during linking? > > If you really want this, why not create a file that provides dummy > > symbols for all that are missing, concentrating the #if mess in > > a single

Re: [FFmpeg-devel] [PATCH v4 0/4] Fix MSVC build without optimizations

2023-07-28 Thread Nicolas George
Reimar Döffinger (12023-07-28): > I assume the issue is missing symbols during linking? > If you really want this, why not create a file that provides dummy > symbols for all that are missing, concentrating the #if mess in > a single place and avoiding affecting any of the regular code, and thus >

Re: [FFmpeg-devel] [PATCH v4 0/4] Fix MSVC build without optimizations

2023-07-28 Thread Reimar Döffinger
> On 28 Jul 2023, at 12:40, Reimar Döffinger wrote: > > >> On 28 Jul 2023, at 03:37, L. E. Segovia wrote: >> >> Updated for 6.0, any constructive feedback will be appreciated. > > Using #if means the code will not even be compile tested if the > feature is disabled, this makes maintenance

Re: [FFmpeg-devel] [PATCH v4 0/4] Fix MSVC build without optimizations

2023-07-28 Thread Reimar Döffinger
> On 28 Jul 2023, at 03:37, L. E. Segovia wrote: > > Updated for 6.0, any constructive feedback will be appreciated. Using #if means the code will not even be compile tested if the feature is disabled, this makes maintenance especially of rare features much harder (nevermind code readability).

[FFmpeg-devel] [PATCH v4 0/4] Fix MSVC build without optimizations

2023-07-27 Thread L. E. Segovia
Updated for 6.0, any constructive feedback will be appreciated. L. E. Segovia (4): all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2 all: Replace if (CONFIG_FOO) checks by #if CONFIG_FOO all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM all: Guard if (EXTERNAL*) checks with