Re: [FFmpeg-devel] [PATCH v5] Add SUP/PGS subtitle demuxer

2014-09-03 Thread Petri Hintukainen
On ma, 2014-09-01 at 16:40 +0200, wm4 wrote: > On Mon, 01 Sep 2014 13:37:23 +0300 > Petri Hintukainen wrote: > > > On ma, 2014-09-01 at 10:05 +0200, Hendrik Leppkes wrote: > > > On Mon, Sep 1, 2014 at 10:01 AM, Petri Hintukainen > > > wrote: > > > > On ma, 2014-09-01 at 00:34 +0200, wm4 wrote:

Re: [FFmpeg-devel] [PATCH v5] Add SUP/PGS subtitle demuxer

2014-09-03 Thread Petri Hintukainen
On ma, 2014-09-01 at 16:45 +0200, wm4 wrote: > On Mon, 1 Sep 2014 08:34:52 + (UTC) > Carl Eugen Hoyos wrote: > > > wm4 googlemail.com> writes: > > > +full_packet_size = AV_RB16(buf + 10 + 1) + 10 + 3; > > > +if (buf_size < full_packet_size) > > > +break; > > > > I

Re: [FFmpeg-devel] [PATCH v5] Add SUP/PGS subtitle demuxer

2014-09-01 Thread wm4
On Mon, 1 Sep 2014 08:34:52 + (UTC) Carl Eugen Hoyos wrote: > wm4 googlemail.com> writes: > > > +avio_rb32(s->pb); /* discard DTS (usually 0, and useless) */ > > Would it be an option to set it dts to AV_NOPTS_VALUE > if this value is 0 but use the value otherwise? > Or is there no ad

Re: [FFmpeg-devel] [PATCH v5] Add SUP/PGS subtitle demuxer

2014-09-01 Thread wm4
On Mon, 01 Sep 2014 13:37:23 +0300 Petri Hintukainen wrote: > On ma, 2014-09-01 at 10:05 +0200, Hendrik Leppkes wrote: > > On Mon, Sep 1, 2014 at 10:01 AM, Petri Hintukainen > > wrote: > > > On ma, 2014-09-01 at 00:34 +0200, wm4 wrote: > > >> --- > > >> Use AV_RB16 instead of memcpy. > > >> Don

Re: [FFmpeg-devel] [PATCH v5] Add SUP/PGS subtitle demuxer

2014-09-01 Thread Petri Hintukainen
On ma, 2014-09-01 at 10:05 +0200, Hendrik Leppkes wrote: > On Mon, Sep 1, 2014 at 10:01 AM, Petri Hintukainen wrote: > > On ma, 2014-09-01 at 00:34 +0200, wm4 wrote: > >> --- > >> Use AV_RB16 instead of memcpy. > >> Don't use AVPROBE_SCORE_EXTENSION. > >> --- > >> libavformat/Makefile | 1 +

Re: [FFmpeg-devel] [PATCH v5] Add SUP/PGS subtitle demuxer

2014-09-01 Thread Carl Eugen Hoyos
wm4 googlemail.com> writes: > +avio_rb32(s->pb); /* discard DTS (usually 0, and useless) */ Would it be an option to set it dts to AV_NOPTS_VALUE if this value is 0 but use the value otherwise? Or is there no advantage? > +full_packet_size = AV_RB16(buf + 10 + 1) + 10 + 3; > +

Re: [FFmpeg-devel] [PATCH v5] Add SUP/PGS subtitle demuxer

2014-09-01 Thread Hendrik Leppkes
On Mon, Sep 1, 2014 at 10:01 AM, Petri Hintukainen wrote: > On ma, 2014-09-01 at 00:34 +0200, wm4 wrote: >> --- >> Use AV_RB16 instead of memcpy. >> Don't use AVPROBE_SCORE_EXTENSION. >> --- >> libavformat/Makefile | 1 + >> libavformat/allformats.c | 1 + >> libavformat/supdec.c | 10

Re: [FFmpeg-devel] [PATCH v5] Add SUP/PGS subtitle demuxer

2014-09-01 Thread Petri Hintukainen
On ma, 2014-09-01 at 00:34 +0200, wm4 wrote: > --- > Use AV_RB16 instead of memcpy. > Don't use AVPROBE_SCORE_EXTENSION. > --- > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/supdec.c | 107 > +++ > 3 files chan

Re: [FFmpeg-devel] [PATCH v5] Add SUP/PGS subtitle demuxer

2014-09-01 Thread Reimar Döffinger
On 01.09.2014, at 00:34, wm4 wrote: > --- > Use AV_RB16 instead of memcpy. > Don't use AVPROBE_SCORE_EXTENSION. Looks good to me, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH v5] Add SUP/PGS subtitle demuxer

2014-08-31 Thread wm4
--- Use AV_RB16 instead of memcpy. Don't use AVPROBE_SCORE_EXTENSION. --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/supdec.c | 107 +++ 3 files changed, 109 insertions(+) create mode 100644 libavformat/supdec.c