Re: [FFmpeg-devel] [PATCH v6 1/5] avformat: Add av_stream_add_coded_side_data()

2020-01-14 Thread Anton Khirnov
Quoting Gaullier Nicolas (2020-01-13 23:16:44) > >If the intention is to use this code from avformat_find_stream_info(), > >then why should it be public? The documentation is very unclear as to > >when/how an API user is supposed to call it. > > > >Anton Khirnov > > Sorry about that, I should

Re: [FFmpeg-devel] [PATCH v6 1/5] avformat: Add av_stream_add_coded_side_data()

2020-01-13 Thread Gaullier Nicolas
>If the intention is to use this code from avformat_find_stream_info(), >then why should it be public? The documentation is very unclear as to >when/how an API user is supposed to call it. > >Anton Khirnov Sorry about that, I should have explained this in the cover letter, or maybe even in the

Re: [FFmpeg-devel] [PATCH v6 1/5] avformat: Add av_stream_add_coded_side_data()

2020-01-13 Thread Anton Khirnov
Quoting Nicolas Gaullier (2020-01-13 19:54:55) > This will allow avformat_find_stream_info() get side data from the codec > context. If the intention is to use this code from avformat_find_stream_info(), then why should it be public? The documentation is very unclear as to when/how an API user

[FFmpeg-devel] [PATCH v6 1/5] avformat: Add av_stream_add_coded_side_data()

2020-01-13 Thread Nicolas Gaullier
This will allow avformat_find_stream_info() get side data from the codec context. --- doc/APIchanges | 3 +++ libavformat/avformat.h | 11 +++ libavformat/utils.c| 15 +++ libavformat/version.h | 4 ++-- 4 files changed, 31 insertions(+), 2 deletions(-) diff