Re: [FFmpeg-devel] [PATCH v7] VideoToolbox H.264 Encoder

2016-02-29 Thread Nicolas George
Le primidi 11 ventôse, an CCXXIV, Richard Kern a écrit : > No, doesn’t look like it. The VideoToolbox constants aren’t 1-to-1 with the > command line options. They do not need to be, you can use intermediate integer constants just as well as you currently use string constants, with the extra bene

Re: [FFmpeg-devel] [PATCH v7] VideoToolbox H.264 Encoder

2016-02-29 Thread Richard Kern
Please ignore this patch - the options code need to be updated. > On Feb 29, 2016, at 11:58 PM, wm4 wrote: > > On Mon, 29 Feb 2016 23:14:17 +0800 > Rick Kern wrote: > >> Autodetected by default. Encode using -codec:v vtenc. >> >> Signed-off-by: Rick Kern >> --- > > OK, autodetection seems t

Re: [FFmpeg-devel] [PATCH v7] VideoToolbox H.264 Encoder

2016-02-29 Thread Richard Kern
> On Feb 29, 2016, at 11:19 PM, Clément Bœsch wrote: > > On Mon, Feb 29, 2016 at 11:14:17PM +0800, Rick Kern wrote: > [...] >> +if (!profile) { >> +//VideoToolbox auto-selects profile and level. >> +return true; >> +} else if (!av_strcasecmp("baseline", profile)) { >> +

Re: [FFmpeg-devel] [PATCH v7] VideoToolbox H.264 Encoder

2016-02-29 Thread wm4
On Mon, 29 Feb 2016 23:14:17 +0800 Rick Kern wrote: > Autodetected by default. Encode using -codec:v vtenc. > > Signed-off-by: Rick Kern > --- OK, autodetection seems to work properly on non-OSX too. I'll apply in 18 hours or so. ___ ffmpeg-devel mai

Re: [FFmpeg-devel] [PATCH v7] VideoToolbox H.264 Encoder

2016-02-29 Thread Clément Bœsch
On Mon, Feb 29, 2016 at 11:14:17PM +0800, Rick Kern wrote: [...] > +if (!profile) { > +//VideoToolbox auto-selects profile and level. > +return true; > +} else if (!av_strcasecmp("baseline", profile)) { > +if (!strcmp("auto", level)) *profile_level_val = > kVTP

[FFmpeg-devel] [PATCH v7] VideoToolbox H.264 Encoder

2016-02-29 Thread Rick Kern
Autodetected by default. Encode using -codec:v vtenc. Signed-off-by: Rick Kern --- MAINTAINERS|1 + configure | 19 + libavcodec/Makefile|1 + libavcodec/allcodecs.c |1 + libavcodec/vtenc.c | 1320 5