Re: [FFmpeg-devel] [RFC] libavfilter query_format() related functions error handling

2015-03-14 Thread Clément Bœsch
On Sat, Mar 14, 2015 at 03:25:19PM +0100, Michael Niedermayer wrote: > On Sat, Mar 14, 2015 at 03:11:28PM +0100, Clément Bœsch wrote: > > On Sat, Mar 14, 2015 at 01:33:12PM +0100, Nicolas George wrote: > > > Le quartidi 24 ventôse, an CCXXIII, Michael Niedermayer a écrit : > > > > ff_set_common

Re: [FFmpeg-devel] [RFC] libavfilter query_format() related functions error handling

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 03:11:28PM +0100, Clément Bœsch wrote: > On Sat, Mar 14, 2015 at 01:33:12PM +0100, Nicolas George wrote: > > Le quartidi 24 ventôse, an CCXXIII, Michael Niedermayer a écrit : > > > ff_set_common_channel_layouts(ctx, ff_all_channel_layouts()); > > > ff_set_common_form

Re: [FFmpeg-devel] [RFC] libavfilter query_format() related functions error handling

2015-03-14 Thread Clément Bœsch
On Sat, Mar 14, 2015 at 01:33:12PM +0100, Nicolas George wrote: > Le quartidi 24 ventôse, an CCXXIII, Michael Niedermayer a écrit : > > ff_set_common_channel_layouts(ctx, ff_all_channel_layouts()); > > ff_set_common_formats(ctx, ff_make_format_list(sample_fmts)); > > ff_set_common_sampl

Re: [FFmpeg-devel] [RFC] libavfilter query_format() related functions error handling

2015-03-14 Thread Nicolas George
Le quartidi 24 ventôse, an CCXXIII, Michael Niedermayer a écrit : > ff_set_common_channel_layouts(ctx, ff_all_channel_layouts()); > ff_set_common_formats(ctx, ff_make_format_list(sample_fmts)); > ff_set_common_samplerates(ctx, ff_all_samplerates()); > > return ctx->ff_errno; I wan

Re: [FFmpeg-devel] [RFC] libavfilter query_format() related functions error handling

2015-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2015 at 12:18:51PM +0100, Clément Bœsch wrote: > Hi, > > I'm adding error handling in the following functions: > > ff_formats_ref() > ff_channel_layouts_ref() > ff_set_common_formats() > ff_set_common_samplerates() > ff_set_common_channel_layouts() > > (I may have forgo

[FFmpeg-devel] [RFC] libavfilter query_format() related functions error handling

2015-03-14 Thread Clément Bœsch
Hi, I'm adding error handling in the following functions: ff_formats_ref() ff_channel_layouts_ref() ff_set_common_formats() ff_set_common_samplerates() ff_set_common_channel_layouts() (I may have forgotten some) So basically these functions would return AVERROR(ENOMEM) (or whatever el