Re: [FFmpeg-devel] [libav-devel] [PATCH] opus_silk: fix out of array read in silk_lsf2lpc

2015-12-16 Thread Andreas Cadhalpun
On 16.12.2015 02:02, Michael Niedermayer wrote: > On Tue, Dec 15, 2015 at 10:41:15PM +0100, Andreas Cadhalpun wrote: >> opus_silk.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> 253c6f7d87dcadf712840f45dde18f5698b9c1d4 >> 0001-opus_silk-fix-typo-causing-overflow-in-silk_stabiliz

Re: [FFmpeg-devel] [libav-devel] [PATCH] opus_silk: fix out of array read in silk_lsf2lpc

2015-12-15 Thread Michael Niedermayer
On Tue, Dec 15, 2015 at 10:41:15PM +0100, Andreas Cadhalpun wrote: > On 15.12.2015 08:17, Anton Khirnov wrote: > > Can you share the sample that shows the problem? > > I could, but it's of no use for comparing with libopus, because their > decoder errors out in an unrelated check. > > > From what

Re: [FFmpeg-devel] [libav-devel] [PATCH] opus_silk: fix out of array read in silk_lsf2lpc

2015-12-15 Thread Andreas Cadhalpun
On 15.12.2015 08:17, Anton Khirnov wrote: > Can you share the sample that shows the problem? I could, but it's of no use for comparing with libopus, because their decoder errors out in an unrelated check. > From what I can see, libopus does not do any clipping at that point, so > something else m

Re: [FFmpeg-devel] [libav-devel] [PATCH] opus_silk: fix out of array read in silk_lsf2lpc

2015-12-14 Thread Andreas Cadhalpun
On 14.12.2015 22:34, Luca Barbato wrote: > On 14/12/15 20:43, Andreas Cadhalpun wrote: >> +nlsf[i] = FFMIN(nlsf[i - 1] + min_delta[i], INT16_MAX); > > maybe av_clip_int16 ? Sure, updated patch attached. Best regards, Andreas >From 2894ea930251562c1551b1c5326fc4af231e015a Mon Sep 17